From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6803C432BE for ; Thu, 29 Jul 2021 04:30:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A159D61059 for ; Thu, 29 Jul 2021 04:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229485AbhG2Ea0 (ORCPT ); Thu, 29 Jul 2021 00:30:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233763AbhG2Ea0 (ORCPT ); Thu, 29 Jul 2021 00:30:26 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B420C061765 for ; Wed, 28 Jul 2021 21:30:23 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id pf12-20020a17090b1d8cb0290175c085e7a5so13629367pjb.0 for ; Wed, 28 Jul 2021 21:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=r5qJLsWAEhPcHvajOIKkhTOz7l5fXoAdAbtdJ9zbKtk=; b=Q86TpW5I0znqVc+apP3BPb/AIu+ZMA7Y7RBJURS9q38hVOM5CB6KzIfy5NFXTmi2A2 5OvecmcEubsVRmQJA7Qf+/gcM6S9x0MnhYuWtWkO4usV+lBskgriqJ0BEW3SQuaHH61X CSnYLol3lLvPAKivObS8tfJ/Gc70QVEnJqEz4wtfQrXED1yNBuDc+v5Wn5hmS2ZDyYuX vykBxBxLjRsFdpC4q/e4oIDDLLvqklQBHyAkV/SX71d+0Jro+i8hrU/KPZZbjX89MQdt w65N9mbpRg5uMPiCmAa9m46aRoMLdExB3v6VoCqHPU38QxjJ76ugMsEeaE3jhDMmHnv1 WbUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=r5qJLsWAEhPcHvajOIKkhTOz7l5fXoAdAbtdJ9zbKtk=; b=sJ7OhR1IhID+9kQxiEGALNzdmjpq0U569lX49yPAYmOPOvntHKWNrlO1AbBGnisxAu 9LqQhQJglVUY/0z2oHKjqbgC5icE7GVhRmgDUgZHAZKwiUh8BprzoOc5BFXhpnlsFwQk e/DGr3e/Zej4F0yLpHbFHmoLh0aMwl6t9NRtV84lfbkF+6QYoc1oRmQ7w6+WrodSpOHZ /bbd5QzYEBR8q1qWLaMPsNttDYla6Vi8obVieWOxEnlCyz8EskdxK0wy//yctOxcS1TN 64Oj/xNnuQDlEe7ILNo35Eege2ED2RC4lPmu9z6hU1t63UXTO2I9TovqD/I2wSTViWai wlgw== X-Gm-Message-State: AOAM5318H4ofKE9eXLJuyyPh3jOtnhCeVcKDwl0mONWWpBx5QKwWIJ1D CTIykcWMq10lNFOjqEXc6jREdQ== X-Google-Smtp-Source: ABdhPJw3SvJQlvvPQ4XX9lqXTB2Eg+0Y5qeOAYr7uHk8BfoCC2cp0TE4CD8Kga1iRtVepSUFZ9yVYw== X-Received: by 2002:a17:902:dacd:b029:12b:acab:b878 with SMTP id q13-20020a170902dacdb029012bacabb878mr2857505plx.4.1627533022446; Wed, 28 Jul 2021 21:30:22 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id u188sm1720773pfc.115.2021.07.28.21.30.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 21:30:20 -0700 (PDT) Date: Wed, 28 Jul 2021 21:30:20 -0700 (PDT) X-Google-Original-Date: Wed, 28 Jul 2021 20:38:34 PDT (-0700) Subject: Re: [RFC PATCH v2 00/11] Linux RISC-V ACLINT Support In-Reply-To: CC: Marc Zyngier , Paul Walmsley , tglx@linutronix.de, daniel.lezcano@linaro.org, robh+dt@kernel.org, Atish Patra , Alistair Francis , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Anup Patel From: Palmer Dabbelt To: anup@brainfault.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 26 Jul 2021 06:01:01 PDT (-0700), anup@brainfault.org wrote: > Hi Marc, > > On Mon, Jul 26, 2021 at 8:02 PM Marc Zyngier wrote: >> >> On Mon, 26 Jul 2021 13:45:20 +0100, >> Anup Patel wrote: >> > >> > Hi Marc, >> > >> > I have taken the approach of IPI domains (like you suggested) in this series. >> > >> > What do you think ? >> >> I have commented on the irqchip driver. >> >> As for the RISC-V specific code, I'll let the architecture maintainers >> look into it. I guess the elephant in the room is that this spec seems >> to be evolving, and that there is no HW implementation (how this >> driver maps on SF's CLINT is anybody's guess). There's a long history of interrupt controller efforts from the RISC-V foundation, and we've yet to have any of them result in hardware. > The SiFive CLINT is a more convoluted device and provides M-level > timer functionality and M-level IPI functionality in one MMIO device. > > The RISC-V ACLINT specification is more modular and backward > compatible with the SiFive CLINT. In fact, a SiFive CLINT device > can be viewed as a ACLINT MSWI device + ACLINT MTIMER device. > This means existing RISC-V boards having SiFive CLINT will be > automatically compliant to the RISC-V ACLINT specification. So is there any hardware that this new specification enables? It seems to be a more convoluted way to describe the same mess we're already in. I'm not really inclined to take a bunch of code that just does the same thing via a more complicated specification. > Here's the RISC-V ACLINT spec: > https://github.com/riscv/riscv-aclint/blob/main/riscv-aclint.adoc > > The RISC-V ACLINT spec is quite stable and we are not seeing any > further changes hence I sent out RFC PATCHes to get feedback. The > RISC-V ACLINT spec will be frozen before 2021 end (i.e. before next > RISC-V summit). Have you talked to the other ISA folks about that? As far as I can tell this new spec allows for multiple MTIME registers, which seems to be in direct contradiction to the single -MTIME register as defined in the ISA manual. It also seems to be vaguely incompatible WRT the definition of SSIP, but I'm not sure that one really matters all that much as it's not like old software can write the new registers. I just talked to Krste and Andrew, they say they haven't heard of any of this. I don't know what's going on over there, but it's very hard to review anything when I can't even tell where the ISA is defined. > The Linux NoMMU kernel (M-level) will use an ACLINT MSWI device > for IPI support whereas the regular Linux MMU kernel (S-level) will > use an ACLINT SSWI device for IPI support. > > The ACLINT SWI driver is a common IPI driver for both ACLINT > MSWI (Linux NoMMU) and ACLINT SSWI (Linux MMU). In fact, > the ACLINT SWI also works for IPI part (i.e. MSWI) of SiFive CLINT. > > Regards, > Anup > >> >> M. >> >> -- >> Without deviation from the norm, progress is not possible.