From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A5FDC35242 for ; Fri, 14 Feb 2020 06:10:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F21024649 for ; Fri, 14 Feb 2020 06:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581660623; bh=z9Q3A4p/YuRxSKXwFUkfWRY4BWOu3yIZZGFKszBfx78=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TA597nKJ2mTQHX1u++8SnQgV3xP3xbsb4+KIJqoWmu0NhsPVLGXyAqlhBe8DLjf9S +El1WzpVeUrKUheNT4VhFiqlP40t2j3EKIh8v8jZPJWErd1Xia+j/l91HCrXaitiG8 359rgnIAUNwnH8TNQbAaQdrpB9CuS2Jb5W1wehx0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727965AbgBNGKW (ORCPT ); Fri, 14 Feb 2020 01:10:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:58664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbgBNGKW (ORCPT ); Fri, 14 Feb 2020 01:10:22 -0500 Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71CDC22314; Fri, 14 Feb 2020 06:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581660622; bh=z9Q3A4p/YuRxSKXwFUkfWRY4BWOu3yIZZGFKszBfx78=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nWDy4oWH1U/rDG5s12yhsyukQ3cGcA3yVzr13jGELJBTkMjkElDFUi7Six1mlPmpP CCVVcwrfc6lB30KRfgQQl8hv4zXqNIwbG7wb/vRHlwbSei2xm19aWIbitYLlEL8WCM 5ScJFzT6Rya7GRaZz0cYQNTrljITpWj97l4+s9xA= From: Masami Hiramatsu To: linux-kernel@vger.kernel.org Cc: kernel-team@android.com, Mark Salyzyn , Theodore Ts'o , Arnd Bergmann , Greg Kroah-Hartman , Richard Henderson , Mark Brown , Kees Cook , Hsin-Yi Wang , Vasily Gorbik , Andrew Morton , Masami Hiramatsu , Steven Rostedt , Mike Rapoport , Arvind Sankar , Dominik Brodowski , Thomas Gleixner , Alexander Potapenko , Jonathan Corbet , Mauro Carvalho Chehab , Josh Poimboeuf , Pawan Gupta , Juergen Gross , Rob Herring , linux-doc@vger.kernel.org Subject: [PATCH 1/3] bootconfig: Support non-ascii characters in value Date: Fri, 14 Feb 2020 15:10:14 +0900 Message-Id: <158166061395.9887.16192852210178543724.stgit@devnote2> X-Mailer: git-send-email 2.20.1 In-Reply-To: <158166060044.9887.549561499483343724.stgit@devnote2> References: <158166060044.9887.549561499483343724.stgit@devnote2> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Support non-ascii (u8 code > 128) characters in the value data. This will allow user to pass utf-8 data as a value in a bootconfig. (Note that ascii non- printable characters are still not allowed.) Signed-off-by: Masami Hiramatsu --- lib/bootconfig.c | 2 +- tools/bootconfig/samples/good-non-ascii.bconf | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 tools/bootconfig/samples/good-non-ascii.bconf diff --git a/lib/bootconfig.c b/lib/bootconfig.c index 3ea601a2eba5..9f15b8bef3a0 100644 --- a/lib/bootconfig.c +++ b/lib/bootconfig.c @@ -466,7 +466,7 @@ static int __init __xbc_parse_value(char **__v, char **__n) } p = v - 1; while ((c = *++p)) { - if (!isprint(c) && !isspace(c)) + if (c >= 0 && !isprint(c) && !isspace(c)) return xbc_parse_error("Non printable value", p); if (quotes) { if (c != quotes) diff --git a/tools/bootconfig/samples/good-non-ascii.bconf b/tools/bootconfig/samples/good-non-ascii.bconf new file mode 100644 index 000000000000..b6cb4c24fad6 --- /dev/null +++ b/tools/bootconfig/samples/good-non-ascii.bconf @@ -0,0 +1 @@ +hello.japanese = "こんにちは"