From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A0CC35242 for ; Fri, 14 Feb 2020 06:10:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7251A24670 for ; Fri, 14 Feb 2020 06:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581660636; bh=ccWxPqghqqwusF6IA8zulp1Gnt4scD6yp6+04wbics0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sziOumMGPsyr1MENqoW1TZzrumCaOmuwQgrMuINRhgTPhSVULWwP3ubQyoY8boLHm 337fhMDwqDQUe/LwSDwi3uRqBBWxsdcp7TpeNCSvdGGe9q/a6Kun+AWLjQt+ebFRhH FKG4PtdDc4Lfz/lMacz8sqgyAD2TsLzFkveat6gM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728253AbgBNGKg (ORCPT ); Fri, 14 Feb 2020 01:10:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:58764 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbgBNGKf (ORCPT ); Fri, 14 Feb 2020 01:10:35 -0500 Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A620624650; Fri, 14 Feb 2020 06:10:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581660635; bh=ccWxPqghqqwusF6IA8zulp1Gnt4scD6yp6+04wbics0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lR6AwgcjCO7+wJbsnAEFnaKZlPV90BOQTlMxKI1ERhqD8qZox/VacBYmMrN/HBcIT E9kew8MNgv/YJpWFyFuI9MAax2zxlRoqdHzw+prgBTcKf90GmgV5Bn1XIye8Kzi6Ku mEj94052Pck9O121ozzIahbftmL69eitJefDtoyM= From: Masami Hiramatsu To: linux-kernel@vger.kernel.org Cc: kernel-team@android.com, Mark Salyzyn , Theodore Ts'o , Arnd Bergmann , Greg Kroah-Hartman , Richard Henderson , Mark Brown , Kees Cook , Hsin-Yi Wang , Vasily Gorbik , Andrew Morton , Masami Hiramatsu , Steven Rostedt , Mike Rapoport , Arvind Sankar , Dominik Brodowski , Thomas Gleixner , Alexander Potapenko , Jonathan Corbet , Mauro Carvalho Chehab , Josh Poimboeuf , Pawan Gupta , Juergen Gross , Rob Herring , linux-doc@vger.kernel.org Subject: [PATCH 2/3] random: rng-seed source is utf-8 Date: Fri, 14 Feb 2020 15:10:27 +0900 Message-Id: <158166062748.9887.15284887096084339722.stgit@devnote2> X-Mailer: git-send-email 2.20.1 In-Reply-To: <158166060044.9887.549561499483343724.stgit@devnote2> References: <158166060044.9887.549561499483343724.stgit@devnote2> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org From: Mark Salyzyn commit 428826f5358c922dc378830a1717b682c0823160 ("fdt: add support for rng-seed") makes the assumption that the data in rng-seed is binary, when it is typically constructed of utf-8 characters which has a bitness of roughly 6 to give appropriate credit due for the entropy. Fixes: 428826f5358c ("fdt: add support for rng-seed") Signed-off-by: Mark Salyzyn Cc: linux-kernel@vger.kernel.org Cc: kernel-team@android.com Cc: Kees Cook Cc: Theodore Y. Ts'o --- drivers/char/random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/random.c b/drivers/char/random.c index c7f9584de2c8..ee21a6a584b1 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -2306,7 +2306,7 @@ EXPORT_SYMBOL_GPL(add_hwgenerator_randomness); void add_bootloader_randomness(const void *buf, unsigned int size) { if (IS_ENABLED(CONFIG_RANDOM_TRUST_BOOTLOADER)) - add_hwgenerator_randomness(buf, size, size * 8); + add_hwgenerator_randomness(buf, size, size * 6); else add_device_randomness(buf, size); }