linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alexander A. Klimov" <grandmaster@al2klimov.de>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: documentation
Date: Sun, 17 May 2020 22:18:23 +0200	[thread overview]
Message-ID: <1bc96da4-49d7-1c8e-de15-858641aba59f@al2klimov.de> (raw)
In-Reply-To: <20200517134544.7d649bbb@lwn.net>



Am 17.05.20 um 21:45 schrieb Jonathan Corbet:
> On Sat, 16 May 2020 14:27:40 +0200
> "Alexander A. Klimov" <grandmaster@al2klimov.de> wrote:
> 
>> ... for security reasons.
>>
>> No breaking changes as either the HTTP vhost redirects to HTTPS
>> or both vhosts redirect to the same location
>> or both serve the same content.
> 
> We're getting closer, but...
> 
>   - There is still too much stuff here.  Remember that somebody has to look
>     at and review this stuff.
OK.

> 
>   - A quick check shows that a fair number of these links are broken or
>     redirect to somewhere else.  What is the value of adding "https" to a
>     broken link?
Literally none. Either some vhosts broke since I have created the first 
prototype of this or (more likely) I was wrong that checking for no 
breaking changes at vhost level is enough.

> 
>   - Various documents have maintainers who are likely to be interested in
>     changes and should be copied; that is what the get_maintainer.pl script
>     is for.  If that generates a massive list of recipients, that's a cue
>     that your patch is too large.
Huh? I *did* run that script (automated) per file and grouped files per 
identical set of patch recipients. I.e. this patch should contain only 
changes for the recipients I've sent it to.
If your invocation of the script doesn't agree with me, please share the 
output and how to reproduce (as if I had just my own patch eMail, the 
upstream Git repo and all the tools of course).
Note that I'm not arguing with you, nor not believing you, exactly the 
opposite: The more pieces I shall split this stuff into, the less errors 
I want to make (and have to correct for every single piece) in the future.

> 
> If you really want to push this forward, please:
> 
>   - narrow down further.  Start with, say, Documentation/maintainer and
>     just do that.
OK.

> 
>   - Make sure every link you touch actually works.  If they don't, don't
>     just add "https", figure out what the link should be or, if no
>     applicable link exists, delete them.
OK, I'll switch from vhost level to link level (will take some time), 
but I won't touch broken links. IMAO that's a different construction area.

> 
>   - Justify the changes in the changelog; "for security reasons" is not, by
>     itself, particularly convincing.  What security threat are you
>     addressing here?
OK.

> 
> Then, maybe, we'll have patches that can be reviewed and applied.
> 
> Thanks,
> 
> jon
> 

  parent reply	other threads:[~2020-05-17 20:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200516122740.30665-1-grandmaster@al2klimov.de>
2020-05-17 19:45 ` [PATCH] Replace HTTP links with HTTPS ones: documentation Jonathan Corbet
2020-05-17 20:00   ` Matthew Wilcox
2020-05-17 20:18   ` Alexander A. Klimov [this message]
2020-05-19 16:10     ` Jonathan Corbet
2020-05-19 18:50       ` Alexander A. Klimov
2020-05-19 19:43         ` Jonathan Corbet
2020-05-19 20:49 ` Andy Shevchenko
2020-05-19 22:04   ` Alexander A. Klimov
2020-05-20  8:25     ` Andy Shevchenko
2020-05-20 20:00 Alexander A. Klimov
     [not found] ` <CAHZk5We1y7o+s7LG=7Q4mVynj5CvJ7RdXLx6WFd-k0yyk=DyPw@mail.gmail.com>
2020-05-22  9:18   ` Alexander A. Klimov
2020-05-25 16:28 ` Jonathan Corbet
2020-05-25 18:01   ` Alexander A. Klimov
2020-05-25 18:24     ` Joe Perches
2020-05-25 18:32       ` Alexander A. Klimov
2020-05-25 19:41     ` Jonathan Corbet
2020-05-26  6:05 Alexander A. Klimov
2020-06-08 15:33 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bc96da4-49d7-1c8e-de15-858641aba59f@al2klimov.de \
    --to=grandmaster@al2klimov.de \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).