From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Jonathan Corbet <corbet@lwn.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Harish Jenny K N <harish_kandiga@mentor.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Alexander Graf <graf@amazon.com>,
Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Phil Reid <preid@electromag.com.au>,
Marc Zyngier <marc.zyngier@arm.com>,
Christoffer Dall <christoffer.dall@arm.com>,
Magnus Damm <magnus.damm@gmail.com>, <linux-gpio@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <qemu-devel@nongnu.org>,
Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [PATCH v3 1/7] gpiolib: Add GPIOCHIP_NAME definition
Date: Mon, 2 Dec 2019 22:17:37 +0100 [thread overview]
Message-ID: <20191202211737.GA27915@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <20191127084253.16356-2-geert+renesas@glider.be>
Hi Geert,
On Wed, Nov 27, 2019 at 09:42:47AM +0100, Geert Uytterhoeven wrote:
> The string literal "gpiochip" is used in several places.
> Add a definition for it, and use it everywhere, to make sure everything
> stays in sync.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
> - New.
> ---
> drivers/gpio/gpiolib-sysfs.c | 7 +++----
> drivers/gpio/gpiolib.c | 4 ++--
> drivers/gpio/gpiolib.h | 2 ++
> 3 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h
> index ca9bc1e4803c2979..a4a759920faa48ab 100644
> --- a/drivers/gpio/gpiolib.h
> +++ b/drivers/gpio/gpiolib.h
> @@ -16,6 +16,8 @@
> #include <linux/module.h>
> #include <linux/cdev.h>
>
> +#define GPIOCHIP_NAME "gpiochip"
[.02$/nit] I wonder if GPIOCHIP_NAME is actually an essential
part of kernel-user contract [1-2], in which case it could
probably be moved to include/uapi/linux/gpio.h ?
Regardless:
Reviewed-by: Eugeniu Rosca <erosca@de.adit-jv.com>
[1] linux (v5.4) git grep '"gpiochip' -- tools/
tools/gpio/lsgpio.c: if (check_prefix(ent->d_name, "gpiochip")) {
tools/testing/selftests/gpio/gpio-mockup-chardev.c: if (check_prefix(ent->d_name, "gpiochip")) {
[2] libgpiod (v1.4-76-g00418dfdfc8b) git grep '"gpiochip'
lib/iter.c: return !strncmp(dir->d_name, "gpiochip", 8);
tests/mockup/gpio-mockup.c: rv = sscanf(sysname, "gpiochip%u", &chip->num);
tools/gpioget.c: die("gpiochip must be specified");
tools/gpiomon.c: die("gpiochip must be specified");
tools/gpioset.c: die("gpiochip must be specified");
--
Best Regards,
Eugeniu
next prev parent reply other threads:[~2019-12-02 21:17 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 8:42 [PATCH v3 0/7] gpio: Add GPIO Aggregator/Repeater Geert Uytterhoeven
2019-11-27 8:42 ` [PATCH v3 1/7] gpiolib: Add GPIOCHIP_NAME definition Geert Uytterhoeven
2019-11-28 3:38 ` Ulrich Hecht
2019-12-02 21:17 ` Eugeniu Rosca [this message]
2019-12-12 10:37 ` Linus Walleij
2019-11-27 8:42 ` [PATCH v3 2/7] gpiolib: Add support for gpiochipN-based table lookup Geert Uytterhoeven
2019-11-28 3:38 ` Ulrich Hecht
2019-12-12 13:20 ` Linus Walleij
2019-12-12 13:33 ` Geert Uytterhoeven
2019-12-12 14:36 ` Linus Walleij
2019-11-27 8:42 ` [PATCH v3 3/7] gpiolib: Add support for GPIO line " Geert Uytterhoeven
2019-11-28 3:39 ` Ulrich Hecht
2019-12-12 13:40 ` Linus Walleij
2019-11-27 8:42 ` [PATCH v3 4/7] dt-bindings: gpio: Add gpio-repeater bindings Geert Uytterhoeven
2019-11-28 3:39 ` Ulrich Hecht
2019-12-03 5:51 ` Harish Jenny K N
2019-12-05 21:06 ` Rob Herring
2019-12-06 9:17 ` Geert Uytterhoeven
2019-12-06 15:03 ` Rob Herring
2020-01-06 8:12 ` Geert Uytterhoeven
2020-01-07 9:22 ` Harish Jenny K N
2020-01-16 5:09 ` Harish Jenny K N
2019-11-27 8:42 ` [PATCH v3 5/7] gpio: Add GPIO Aggregator/Repeater driver Geert Uytterhoeven
2019-11-27 14:15 ` Eugeniu Rosca
2019-11-27 14:33 ` Geert Uytterhoeven
2019-11-28 3:40 ` Ulrich Hecht
2019-12-03 5:42 ` Harish Jenny K N
2019-12-03 8:17 ` Geert Uytterhoeven
2019-12-03 8:51 ` Harish Jenny K N
2019-12-03 10:51 ` Eugeniu Rosca
2020-01-09 13:35 ` Geert Uytterhoeven
2020-01-09 13:49 ` Eugeniu Rosca
2019-12-12 14:34 ` Linus Walleij
2019-12-12 15:24 ` Geert Uytterhoeven
2020-01-04 0:38 ` Linus Walleij
2020-01-06 8:23 ` Geert Uytterhoeven
2020-01-08 23:12 ` Linus Walleij
2019-11-27 8:42 ` [PATCH v3 6/7] docs: gpio: Add GPIO Aggregator/Repeater documentation Geert Uytterhoeven
2019-11-28 3:41 ` Ulrich Hecht
2019-12-12 14:42 ` Linus Walleij
2019-12-12 14:48 ` Geert Uytterhoeven
2020-01-04 0:21 ` Linus Walleij
2020-01-06 8:06 ` Geert Uytterhoeven
2019-11-27 8:42 ` [PATCH v3 7/7] MAINTAINERS: Add GPIO Aggregator/Repeater section Geert Uytterhoeven
2019-12-03 5:38 ` Harish Jenny K N
2020-01-18 1:46 ` [PATCH v3 0/7] gpio: Add GPIO Aggregator/Repeater Eugeniu Rosca
2020-01-20 9:33 ` Geert Uytterhoeven
2020-01-20 12:14 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202211737.GA27915@vmlxhi-102.adit-jv.com \
--to=erosca@de.adit-jv.com \
--cc=bgolaszewski@baylibre.com \
--cc=christoffer.dall@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=graf@amazon.com \
--cc=harish_kandiga@mentor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=preid@electromag.com.au \
--cc=qemu-devel@nongnu.org \
--cc=robh+dt@kernel.org \
--cc=roscaeugeniu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).