From: Rob Herring <robh@kernel.org>
To: shubhrajyoti.datta@gmail.com
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, corbet@lwn.net,
gregkh@linuxfoundation.org, arnd@arndb.de,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Subject: Re: [PATCH 1/3] dt-bindings: Add dt bindings for flex noc Performance Monitor
Date: Thu, 5 Dec 2019 12:17:40 -0600 [thread overview]
Message-ID: <20191205181740.GA26684@bogus> (raw)
In-Reply-To: <1574679352-2989-1-git-send-email-shubhrajyoti.datta@gmail.com>
On Mon, Nov 25, 2019 at 04:25:50PM +0530, shubhrajyoti.datta@gmail.com wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> Add dt bindings for flexnoc Performance Monitor.
> The flexnoc counters for read and write response and requests are
> supported.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> changes from RFC:
> moved to schema / yaml
>
> .../devicetree/bindings/perf/xlnx-flexnoc-pm.yaml | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/perf/xlnx-flexnoc-pm.yaml
>
> diff --git a/Documentation/devicetree/bindings/perf/xlnx-flexnoc-pm.yaml b/Documentation/devicetree/bindings/perf/xlnx-flexnoc-pm.yaml
> new file mode 100644
> index 0000000..bd0f345
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/perf/xlnx-flexnoc-pm.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause
() around the licenses.
Are you good with GPL v10? Make it 'GPL-2.0-only' instead.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/perf/xlnx-flexnoc-pm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Xilinx flexnoc Performance Monitor device tree bindings
> +
> +maintainers:
> + - Arnd Bergmann <arnd@arndb.de>
> + - Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This should be someone familar with this h/w (you).
> +
> +properties:
> + compatible:
> + # Versal SoC based boards
> + items:
> + - enum:
> + - xlnx,flexnoc-pm-2.7
> +
> + reg:
> + items:
> + - description: funnel registers
> + - description: baselpd registers
> + - description: basefpd registers
> +
> + reg-names:
> + # The core schema enforces this is a string array
> + items:
> + - const: funnel
> + - const: baselpd
> + - const: basefpd
> +
> +required:
> + - compatible
> + - reg
No point having 'reg-names' if not required.
Add:
additionalProperties: false
> +
> +examples:
> + - |
> + performance-monitor@f0920000 {
> + compatible = "xlnx,flexnoc-pm-2.7";
> + reg-names = "funnel", "baselpd", "basefpd";
> + reg = <0x0 0xf0920000 0x0 0x1000>,
> + <0x0 0xf0980000 0x0 0x9000>,
> + <0x0 0xf0b80000 0x0 0x9000>;
> + };
> --
> 2.1.1
>
next prev parent reply other threads:[~2019-12-05 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 10:55 [PATCH 1/3] dt-bindings: Add dt bindings for flex noc Performance Monitor shubhrajyoti.datta
2019-11-25 10:55 ` [PATCH 2/3] misc: xilinx_flex: Add support for the " shubhrajyoti.datta
2019-11-25 10:55 ` [PATCH 3/3] Documentation: short descriptions for Flexnoc Performance Monitor driver shubhrajyoti.datta
2019-12-05 18:17 ` Rob Herring [this message]
2019-12-06 5:44 ` [PATCH 1/3] dt-bindings: Add dt bindings for flex noc Performance Monitor Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205181740.GA26684@bogus \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shubhrajyoti.datta@gmail.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).