From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B72C33CAD for ; Mon, 13 Jan 2020 12:12:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87F3F2080D for ; Mon, 13 Jan 2020 12:12:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578917568; bh=jrKOx7fdYO/hgwOXZereFYrzknBNVlPV0cWc5JJ1418=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qN51DmptInQfOeRM0UsL4rJVaV/z1xfSzPfo2i94/39uuzLYgXlcUsVrZE4ryYlk2 inqVVd9TDQkr7MqAlw5Lc8VYp5vLwbbSnkuS7mEOllYhE/JRQw6Il1Sd1/CY+vNJMw 8XhGP8lUqrmQKUhPU4voH4Xelxl1ReWvAduUYvsE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726127AbgAMMMs (ORCPT ); Mon, 13 Jan 2020 07:12:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:52768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbgAMMMs (ORCPT ); Mon, 13 Jan 2020 07:12:48 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A2602075B; Mon, 13 Jan 2020 12:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578917567; bh=jrKOx7fdYO/hgwOXZereFYrzknBNVlPV0cWc5JJ1418=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kE2bX48Ij3Lcc8WQScofYgYFGjjwfqDqH83qLTdcOcI2aZ5mXA2CThEiocaWgQ+V5 WRtPBjxDkvffPZMCQIsNDIJVhxwT+WOOVIi9qDCDwlN6nxuJt2W12nScVYpTS+8AE7 pVt9HDLXBQPMkGUKJ5MBkeSkRs86GPSr4a7Fkk1Q= Date: Mon, 13 Jan 2020 12:12:41 +0000 From: Will Deacon To: Zengruan Ye Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-doc@vger.kernel.org, virtualization@lists.linux-foundation.org, maz@kernel.org, james.morse@arm.com, linux@armlinux.org.uk, suzuki.poulose@arm.com, julien.thierry.kdev@gmail.com, catalin.marinas@arm.com, mark.rutland@arm.com, steven.price@arm.com, daniel.lezcano@linaro.org, peterz@infradead.org Subject: Re: [PATCH v2 0/6] KVM: arm64: VCPU preempted check support Message-ID: <20200113121240.GC3260@willie-the-truck> References: <20191226135833.1052-1-yezengruan@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191226135833.1052-1-yezengruan@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org [+PeterZ] On Thu, Dec 26, 2019 at 09:58:27PM +0800, Zengruan Ye wrote: > This patch set aims to support the vcpu_is_preempted() functionality > under KVM/arm64, which allowing the guest to obtain the VCPU is > currently running or not. This will enhance lock performance on > overcommitted hosts (more runnable VCPUs than physical CPUs in the > system) as doing busy waits for preempted VCPUs will hurt system > performance far worse than early yielding. > > We have observed some performace improvements in uninx benchmark tests. > > unix benchmark result: > host: kernel 5.5.0-rc1, HiSilicon Kunpeng920, 8 CPUs > guest: kernel 5.5.0-rc1, 16 VCPUs > > test-case | after-patch | before-patch > ----------------------------------------+-------------------+------------------ > Dhrystone 2 using register variables | 334600751.0 lps | 335319028.3 lps > Double-Precision Whetstone | 32856.1 MWIPS | 32849.6 MWIPS > Execl Throughput | 3662.1 lps | 2718.0 lps > File Copy 1024 bufsize 2000 maxblocks | 432906.4 KBps | 158011.8 KBps > File Copy 256 bufsize 500 maxblocks | 116023.0 KBps | 37664.0 KBps > File Copy 4096 bufsize 8000 maxblocks | 1432769.8 KBps | 441108.8 KBps > Pipe Throughput | 6405029.6 lps | 6021457.6 lps > Pipe-based Context Switching | 185872.7 lps | 184255.3 lps > Process Creation | 4025.7 lps | 3706.6 lps > Shell Scripts (1 concurrent) | 6745.6 lpm | 6436.1 lpm > Shell Scripts (8 concurrent) | 998.7 lpm | 931.1 lpm > System Call Overhead | 3913363.1 lps | 3883287.8 lps > ----------------------------------------+-------------------+------------------ > System Benchmarks Index Score | 1835.1 | 1327.6 Interesting, thanks for the numbers. So it looks like there is a decent improvement to be had from targetted vCPU wakeup, but I really dislike the explicit PV interface and it's already been shown to interact badly with the WFE-based polling in smp_cond_load_*(). Rather than expose a divergent interface, I would instead like to explore an improvement to smp_cond_load_*() and see how that performs before we commit to something more intrusive. Marc and I looked at this very briefly in the past, and the basic idea is to register all of the WFE sites with the hypervisor, indicating which register contains the address being spun on and which register contains the "bad" value. That way, you don't bother rescheduling a vCPU if the value at the address is still bad, because you know it will exit immediately. Of course, the devil is in the details because when I say "address", that's a guest virtual address, so you need to play some tricks in the hypervisor so that you have a separate mapping for the lockword (it's enough to keep track of the physical address). Our hacks are here but we basically ran out of time to work on them beyond an unoptimised and hacky prototype: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/pvcy Marc -- how would you prefer to handle this? Will