From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
maz@kernel.org, suzuki.poulose@arm.com, sudeep.holla@arm.com,
lukasz.luba@arm.com, rjw@rjwysocki.net, peterz@infradead.org,
mingo@redhat.com, vincent.guittot@linaro.org,
viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 7/7] clocksource/drivers/arm_arch_timer: validate arch_timer_rate
Date: Wed, 12 Feb 2020 10:32:49 +0000 [thread overview]
Message-ID: <20200212103249.GA19041@arm.com> (raw)
In-Reply-To: <05e257b6-0a39-135d-8117-7883739538c3@arm.com>
Hi Valentin,
On Wednesday 12 Feb 2020 at 09:30:34 (+0000), Valentin Schneider wrote:
> On 11/02/2020 18:45, Ionela Voinescu wrote:
> > From: Valentin Schneider <valentin.schneider@arm.com>
> >
> > Using an arch timer with a frequency of less than 1MHz can result in an
> > incorrect functionality of the system which assumes a reasonable rate.
> >
> > One example is the use of activity monitors for frequency invariance
> > which uses the rate of the arch timer as the known rate of the constant
> > cycle counter in computing its ratio compared to the maximum frequency
> > of a CPU. For arch timer frequencies less than 1MHz this ratio could
> > end up being 0 which is an invalid value for its use.
> >
>
> I'm being pedantic here (as usual), but I'd contrast this a bit more. The
> activity monitor code checks by itself that the ratio doesn't end up being
> 0, which is why we don't slam the brakes if the arch timer freq is < 1MHz.
>
> It's just a CNTFRQ sanity check that goes a bit beyond the 0 value check,
> IMO.
>
I agree, but this part was just given as an example of functionality
that relies on a reasonable arch timer rate. The AMU code checks for the
ratio not to be 0 so it does not end up breaking frequency invariance.
But if the ratio does end up being 0 due to the value of arch_time_rate,
we bypass the use of activity monitors which I'd argue it's incorrect
functionality by disabling a potential better source of information for
frequency invariance.
But I can rewrite this part for more clarity.
> > Therefore, warn if the arch timer rate is below 1MHz which contravenes
> > the recommended architecture interval of 1 to 50MHz.
> >
> > Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Marc Zyngier <maz@kernel.org>
>
> ISTR something somewhere that says the first signoff should be that of the
> author of the patch, and seeing as I just provided an untested diff that
> ought to be you :)
Will do!
Thanks,
Ionela.
next prev parent reply other threads:[~2020-02-12 10:32 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 18:45 [PATCH v3 0/7] arm64: ARMv8.4 Activity Monitors support Ionela Voinescu
2020-02-11 18:45 ` [PATCH v3 1/7] arm64: add support for the AMU extension v1 Ionela Voinescu
2020-02-12 11:30 ` Suzuki Kuruppassery Poulose
2020-02-12 14:54 ` Valentin Schneider
2020-02-12 16:10 ` Ionela Voinescu
2020-02-12 16:20 ` Suzuki Kuruppassery Poulose
2020-02-12 18:20 ` Ionela Voinescu
2020-02-12 19:24 ` Suzuki K Poulose
2020-02-12 20:19 ` Ionela Voinescu
2020-02-12 16:24 ` Vladimir Murzin
2020-02-12 18:27 ` Ionela Voinescu
2020-02-11 18:45 ` [PATCH v3 2/7] arm64: trap to EL1 accesses to AMU counters from EL0 Ionela Voinescu
2020-02-12 11:44 ` Suzuki Kuruppassery Poulose
2020-02-12 15:36 ` Valentin Schneider
2020-02-11 18:45 ` [PATCH v3 3/7] arm64/kvm: disable access to AMU registers from kvm guests Ionela Voinescu
2020-02-12 15:36 ` Valentin Schneider
2020-02-12 16:33 ` Suzuki Kuruppassery Poulose
2020-02-11 18:45 ` [PATCH v3 4/7] Documentation: arm64: document support for the AMU extension Ionela Voinescu
2020-02-12 15:36 ` Valentin Schneider
2020-02-11 18:45 ` [PATCH v3 5/7] cpufreq: add function to get the hardware max frequency Ionela Voinescu
2020-02-12 4:14 ` Viresh Kumar
2020-02-13 11:59 ` Valentin Schneider
2020-02-13 12:59 ` Ionela Voinescu
2020-02-13 15:22 ` Valentin Schneider
2020-02-11 18:45 ` [PATCH v3 6/7] arm64: use activity monitors for frequency invariance Ionela Voinescu
2020-02-12 18:59 ` Lukasz Luba
2020-02-13 9:47 ` Ionela Voinescu
2020-02-17 16:59 ` Valentin Schneider
2020-02-23 18:49 ` Ionela Voinescu
2020-02-11 18:45 ` [PATCH v3 7/7] clocksource/drivers/arm_arch_timer: validate arch_timer_rate Ionela Voinescu
2020-02-12 9:30 ` Valentin Schneider
2020-02-12 10:32 ` Ionela Voinescu [this message]
2020-02-12 10:01 ` Lukasz Luba
2020-02-12 10:12 ` Marc Zyngier
2020-02-12 10:54 ` Ionela Voinescu
2020-02-12 10:55 ` Lukasz Luba
2020-02-12 11:10 ` Marc Zyngier
2020-02-12 11:43 ` Lukasz Luba
2020-02-12 11:12 ` Valentin Schneider
2020-02-14 0:35 ` Thomas Gleixner
2020-02-14 15:45 ` Ionela Voinescu
2020-02-14 15:57 ` Ionela Voinescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212103249.GA19041@arm.com \
--to=ionela.voinescu@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).