From: Jonathan Corbet <corbet@lwn.net>
To: Stephen Kitt <steve@sk2.org>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] docs: merge debugging-modules.txt into sysctl/kernel.rst
Date: Thu, 13 Feb 2020 11:55:42 -0700 [thread overview]
Message-ID: <20200213115542.79a86048@lwn.net> (raw)
In-Reply-To: <20200213174701.3200366-3-steve@sk2.org>
On Thu, 13 Feb 2020 18:46:57 +0100
Stephen Kitt <steve@sk2.org> wrote:
> This fits nicely in sysctl/kernel.rst, merge it (and rephrase it)
> instead of linking to it.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---
> Documentation/admin-guide/sysctl/kernel.rst | 16 ++++++++++++++-
> Documentation/debugging-modules.txt | 22 ---------------------
> 2 files changed, 15 insertions(+), 23 deletions(-)
> delete mode 100644 Documentation/debugging-modules.txt
One quick comment here:
> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
> index 1de8f0b199b1..1aacd7a24f5a 100644
> --- a/Documentation/admin-guide/sysctl/kernel.rst
> +++ b/Documentation/admin-guide/sysctl/kernel.rst
> @@ -388,7 +388,21 @@ This flag controls the L2 cache of G3 processor boards. If
> modprobe
> ========
>
> -See Documentation/debugging-modules.txt.
> +This gives the full path of the modprobe command which the kernel will
> +use to load modules. This can be used to debug module loading
> +requests:
> +
> +::
This can be more readably written as just:
requests::
No need for the separate "::" line.
Thanks,
jon
next prev parent reply other threads:[~2020-02-13 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 17:46 [PATCH 0/6] docs: sysctl/kernel.rst rework Stephen Kitt
2020-02-13 17:46 ` [PATCH 1/6] docs: pretty up sysctl/kernel.rst Stephen Kitt
2020-02-13 18:52 ` Jonathan Corbet
2020-02-13 19:21 ` Stephen Kitt
2020-02-13 17:46 ` [PATCH 2/6] docs: merge debugging-modules.txt into sysctl/kernel.rst Stephen Kitt
2020-02-13 18:55 ` Jonathan Corbet [this message]
2020-02-13 17:46 ` [PATCH 3/6] docs: drop l2cr from sysctl/kernel.rst Stephen Kitt
2020-02-13 17:46 ` [PATCH 4/6] docs: add missing IPC documentation in sysctl/kernel.rst Stephen Kitt
2020-02-13 17:47 ` [PATCH 5/6] docs: document stop-a " Stephen Kitt
2020-02-13 17:47 ` [PATCH 6/6] docs: document panic fully " Stephen Kitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213115542.79a86048@lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).