From: Pavan Kondeti <pkondeti@codeaurora.org>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
maz@kernel.org, suzuki.poulose@arm.com, sudeep.holla@arm.com,
lukasz.luba@arm.com, valentin.schneider@arm.com,
dietmar.eggemann@arm.com, rjw@rjwysocki.net,
peterz@infradead.org, mingo@redhat.com,
vincent.guittot@linaro.org, viresh.kumar@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 6/7] arm64: use activity monitors for frequency invariance
Date: Wed, 26 Feb 2020 15:21:34 +0530 [thread overview]
Message-ID: <20200226095134.GM28029@codeaurora.org> (raw)
In-Reply-To: <20200224141142.25445-7-ionela.voinescu@arm.com>
On Mon, Feb 24, 2020 at 02:11:41PM +0000, Ionela Voinescu wrote:
[...]
> +static int __init init_amu_fie(void)
> +{
> + cpumask_var_t valid_cpus;
> + bool have_policy = false;
> + int cpu;
> +
> + if (!zalloc_cpumask_var(&valid_cpus, GFP_KERNEL) ||
> + !zalloc_cpumask_var(&amu_fie_cpus, GFP_KERNEL))
> + return -ENOMEM;
The patch looks good to me. one minor comment here. In an unlikely
scenario, valid_cpus which is a temporary mask can get allocated
but amu_fie_cpus may not. In that case, we have to free valid_cpus
here. I have seen some static code inspection tools catching these
type of errors. If you happen to rebase this series, fix this.
Thanks,
Pavan
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-02-26 9:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 14:11 [PATCH v4 0/7] arm64: ARMv8.4 Activity Monitors support Ionela Voinescu
2020-02-24 14:11 ` [PATCH v4 1/7] arm64: add support for the AMU extension v1 Ionela Voinescu
2020-02-24 18:39 ` Valentin Schneider
2020-02-24 14:11 ` [PATCH v4 2/7] arm64: trap to EL1 accesses to AMU counters from EL0 Ionela Voinescu
2020-02-24 14:11 ` [PATCH v4 3/7] arm64/kvm: disable access to AMU registers from kvm guests Ionela Voinescu
2020-02-24 14:11 ` [PATCH v4 4/7] Documentation: arm64: document support for the AMU extension Ionela Voinescu
2020-02-24 14:11 ` [PATCH v4 5/7] cpufreq: add function to get the hardware max frequency Ionela Voinescu
2020-02-24 18:44 ` Valentin Schneider
2020-02-24 14:11 ` [PATCH v4 6/7] arm64: use activity monitors for frequency invariance Ionela Voinescu
2020-02-24 18:40 ` Valentin Schneider
2020-02-25 9:59 ` Lukasz Luba
2020-02-26 10:18 ` Ionela Voinescu
2020-02-26 9:51 ` Pavan Kondeti [this message]
2020-02-26 10:22 ` Ionela Voinescu
2020-02-24 14:11 ` [PATCH v4 7/7] clocksource/drivers/arm_arch_timer: validate arch_timer_rate Ionela Voinescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226095134.GM28029@codeaurora.org \
--to=pkondeti@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).