From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04BFEC3F2C4 for ; Thu, 27 Feb 2020 22:13:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0E582469F for ; Thu, 27 Feb 2020 22:13:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="hCxh6qfD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729831AbgB0WNm (ORCPT ); Thu, 27 Feb 2020 17:13:42 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:44722 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729773AbgB0WNl (ORCPT ); Thu, 27 Feb 2020 17:13:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=TLyRnJ1kCDzmRuRPTz7K92VaFFh1/vMyyOGH0HaTtQU=; b=hCxh6qfDzl2vp7DfzH7YiKHP4 DhRLp6tdz6Pf8sxKQD3D3uLhUeE+80ZYoKZT3UyLGQSdNw2BZ2vr/HFjStzNnKnsTYpuy/9jOOGfk 6he1mGrm1X7/9X5DeNZUs1Z0YBlJbGOhyg/Mxqn/zwJREwIsRGrpgC623yJdZzyZ7xB5x/DQCzdNa fm5KA+xAB23YrLCSiNZBi0hBMiSRKZamKETgxTXepn1R/l59dEmUXwWzllDpEEhgRZJDxCjgOc3kp mQO+YUx+2XZASMjQcq5zZM75k/L8YzXGdqB7mqjRvkBPzH4TlE6bzD5IbwetU/vIwC7WwXYqo+UDW J0cfEvkEA==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:53650) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j7RPK-0008OF-2y; Thu, 27 Feb 2020 22:13:26 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j7RP9-0001Kj-JH; Thu, 27 Feb 2020 22:13:15 +0000 Date: Thu, 27 Feb 2020 22:13:15 +0000 From: Russell King - ARM Linux admin To: David Miller Cc: andrew@lunn.ch, linux-doc@vger.kernel.org, thomas.petazzoni@bootlin.com, ioana.ciornei@nxp.com, linux-stm32@st-md-mailman.stormreply.com, f.fainelli@gmail.com, corbet@lwn.net, michal.simek@xilinx.com, joabreu@synopsys.com, kuba@kernel.org, Mark-MC.Lee@mediatek.com, sean.wang@mediatek.com, alexandre.torgue@st.com, hauke@hauke-m.de, radhey.shyam.pandey@xilinx.com, linux-mediatek@lists.infradead.org, john@phrozen.org, matthias.bgg@gmail.com, peppe.cavallaro@st.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, vivien.didelot@gmail.com, mcoquelin.stm32@gmail.com, nbd@nbd.name, olteanv@gmail.com, hkallweit1@gmail.com Subject: Re: [PATCH net-next v2 0/8] rework phylink interface for split MAC/PCS support Message-ID: <20200227221315.GS25745@shell.armlinux.org.uk> References: <20200226102312.GX25745@shell.armlinux.org.uk> <20200227.120254.241641132362203475.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200227.120254.241641132362203475.davem@davemloft.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, Feb 27, 2020 at 12:02:54PM -0800, David Miller wrote: > From: Russell King - ARM Linux admin > Date: Wed, 26 Feb 2020 10:23:12 +0000 > > > The following series changes the phylink interface to allow us to > > better support split MAC / MAC PCS setups. The fundamental change > > required for this turns out to be quite simple. > > > > Today, mac_config() is used for everything to do with setting the > > parameters for the MAC, and mac_link_up() is used to inform the > > MAC driver that the link is now up (and so to allow packet flow.) > > mac_config() also has had a few implementation issues, with folk > > who believe that members such as "speed" and "duplex" are always > > valid, where "link" gets used inappropriately, etc. > > > > With the proposed patches, all this changes subtly - but in a > > backwards compatible way at this stage. > > > > We pass the the full resolved link state (speed, duplex, pause) to > > mac_link_up(), and it is now guaranteed that these parameters to > > this function will always be valid (no more SPEED_UNKNOWN or > > DUPLEX_UNKNOWN here - unless phylink is fed with such things.) > > > > Drivers should convert over to using the state in mac_link_up() > > rather than configuring the speed, duplex and pause in the > > mac_config() method. The patch series includes a number of MAC > > drivers which I've thought have been easy targets - I've left the > > remainder as I think they need maintainer input. However, *all* > > drivers will need conversion for future phylink development. > > > > v2: add ocelot/felix and qca/ar9331 DSA drivers to patch 2, add > > received tested-by so far. > > In order to end the storm in a teacup, I've applied this series. > > :-) > > Thanks Russell. Thanks David, I was getting concerned that the teacup might break! :p -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up