From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B2C9C3F2D1 for ; Mon, 9 Mar 2020 19:21:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0500121927 for ; Mon, 9 Mar 2020 19:21:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PKCtKC7u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726199AbgCITVU (ORCPT ); Mon, 9 Mar 2020 15:21:20 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:41089 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726266AbgCITVU (ORCPT ); Mon, 9 Mar 2020 15:21:20 -0400 Received: by mail-pg1-f194.google.com with SMTP id b1so5153281pgm.8 for ; Mon, 09 Mar 2020 12:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/Ve3mrSvm1dOHAsegEEjiuaMrFQOijqF+lr2yreUyLE=; b=PKCtKC7uyC8i/DN0MO+jBy7A9dYjm0BvRQHCcABOBfgDupKb+axXLHJ1pIr5+0N6v+ EOZwJYSIfs2miXWm90Qjb6yE5EBWGSBAsw/IRyuFapS9v6j5tiHTfsj8sy8fndA4ooO9 UKs1UUhQk1xKwDJGKHHRiGZ4SR4ShkUpFn6QuntqJF3mhLrBK3keXR9SOUl0Epx2yryK dqYB3wkDKVT3frMmHokgUdQyCvgwBogJgN9Hy0rbNBvNYsfsuDcnCMas98lYqxyv775v T7xrFLTYcuTQgavNN3+2Qvly5vFOFiA8Upap+DllXIKkLvxGERM74sfSGkAAiWy7yk2p JNtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/Ve3mrSvm1dOHAsegEEjiuaMrFQOijqF+lr2yreUyLE=; b=knQfRkbwfu9jpZScyoVhzg6KdFtTo6+WxvfaYbfkIEbvY2mIXtSiRPp04Vigz4y904 4DufCy1ezj0oXHF4oODuyewnorDDgFQpsrqdh7IfDa665srFft45/IXDaUfVVpZp4gkH b8PuPGTcB4BJjMblgpaK0TWnsA4y56doma/RCADJfNmAlap7Z8eRPVE0cX72JUZIiY28 m+4Wfu4M0CUan5pNB7DeIMR8bWppuZH90/ITxO1rsGrqC5Fm95OgP4VacPRIyB657KG8 W6bgwGwytoFfjQoy5J8Hf/4ZgRLz+S5Mqo0fTsw7eTB7zTDjGvOXpvE8lYcJMhwcn6gV R7ow== X-Gm-Message-State: ANhLgQ1LcxSx9iSdVPbMym6DTZ9IwyDhnR9FM/iQr63VVlfmS4jZyy7I 9n0W/31kX0Q+XZelag8rGCD5BQ== X-Google-Smtp-Source: ADFU+vv4DHskMayr9V263F+RoX6mwXATWLbep1JlrTDrd3s5h6v5M8VMmhrUgv94rrg0OOERe/5wyg== X-Received: by 2002:a62:25c3:: with SMTP id l186mr18053778pfl.52.1583781678971; Mon, 09 Mar 2020 12:21:18 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id u14sm27167815pgg.67.2020.03.09.12.21.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2020 12:21:18 -0700 (PDT) Date: Mon, 9 Mar 2020 13:21:15 -0600 From: Mathieu Poirier To: Clement Leger Cc: Ohad Ben-Cohen , Bjorn Andersson , Jonathan Corbet , Shawn Guo , Sascha Hauer , linux-remoteproc@vger.kernel.org, Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Patrice Chotard , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Arnaud Pouliquen , Loic PALLARDY , s-anna Subject: Re: [PATCH v5 2/8] remoteproc: Use size_t instead of int for rproc_mem_entry len Message-ID: <20200309192115.GB1399@xps15> References: <20200210162209.23149-1-cleger@kalray.eu> <20200302093902.27849-1-cleger@kalray.eu> <20200302093902.27849-3-cleger@kalray.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200302093902.27849-3-cleger@kalray.eu> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Mar 02, 2020 at 10:38:56AM +0100, Clement Leger wrote: > Now that rproc_da_to_va uses a size_t for length, use a size_t for len field > of rproc_mem_entry. Function used to create such structures now takes > a size_t instead of int to allow full size range to be handled. > > Signed-off-by: Clement Leger With the checkpatch warning fixed: Reviewed-by: Mathieu Poirier > --- > drivers/remoteproc/remoteproc_core.c | 14 ++++++++------ > drivers/remoteproc/remoteproc_debugfs.c | 2 +- > include/linux/remoteproc.h | 6 +++--- > 3 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index 5ab094fc1b55..4bfaf4a3c4a3 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -318,8 +318,9 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i) > struct device *dev = &rproc->dev; > struct rproc_vring *rvring = &rvdev->vring[i]; > struct fw_rsc_vdev *rsc; > - int ret, size, notifyid; > + int ret, notifyid; > struct rproc_mem_entry *mem; > + size_t size; > > /* actual size of vring (in bytes) */ > size = PAGE_ALIGN(vring_size(rvring->len, rvring->align)); > @@ -746,11 +747,12 @@ static int rproc_alloc_carveout(struct rproc *rproc, > va = dma_alloc_coherent(dev->parent, mem->len, &dma, GFP_KERNEL); > if (!va) { > dev_err(dev->parent, > - "failed to allocate dma memory: len 0x%x\n", mem->len); > + "failed to allocate dma memory: len 0x%zx\n", > + mem->len); > return -ENOMEM; > } > > - dev_dbg(dev, "carveout va %pK, dma %pad, len 0x%x\n", > + dev_dbg(dev, "carveout va %pK, dma %pad, len 0x%zx\n", > va, &dma, mem->len); > > if (mem->da != FW_RSC_ADDR_ANY && !rproc->domain) { > @@ -957,7 +959,7 @@ EXPORT_SYMBOL(rproc_add_carveout); > */ > struct rproc_mem_entry * > rproc_mem_entry_init(struct device *dev, > - void *va, dma_addr_t dma, int len, u32 da, > + void *va, dma_addr_t dma, size_t len, u32 da, > int (*alloc)(struct rproc *, struct rproc_mem_entry *), > int (*release)(struct rproc *, struct rproc_mem_entry *), > const char *name, ...) > @@ -999,7 +1001,7 @@ EXPORT_SYMBOL(rproc_mem_entry_init); > * provided by client. > */ > struct rproc_mem_entry * > -rproc_of_resm_mem_entry_init(struct device *dev, u32 of_resm_idx, int len, > +rproc_of_resm_mem_entry_init(struct device *dev, u32 of_resm_idx, size_t len, > u32 da, const char *name, ...) > { > struct rproc_mem_entry *mem; > @@ -1270,7 +1272,7 @@ static void rproc_resource_cleanup(struct rproc *rproc) > unmapped = iommu_unmap(rproc->domain, entry->da, entry->len); > if (unmapped != entry->len) { > /* nothing much to do besides complaining */ > - dev_err(dev, "failed to unmap %u/%zu\n", entry->len, > + dev_err(dev, "failed to unmap %zx/%zu\n", entry->len, > unmapped); > } > > diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c > index dd93cf04e17f..82dc34b819df 100644 > --- a/drivers/remoteproc/remoteproc_debugfs.c > +++ b/drivers/remoteproc/remoteproc_debugfs.c > @@ -293,7 +293,7 @@ static int rproc_carveouts_show(struct seq_file *seq, void *p) > seq_printf(seq, "\tVirtual address: %pK\n", carveout->va); > seq_printf(seq, "\tDMA address: %pad\n", &carveout->dma); > seq_printf(seq, "\tDevice address: 0x%x\n", carveout->da); > - seq_printf(seq, "\tLength: 0x%x Bytes\n\n", carveout->len); > + seq_printf(seq, "\tLength: 0x%zx Bytes\n\n", carveout->len); > } > > return 0; > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h > index 89215798eaea..bee559330204 100644 > --- a/include/linux/remoteproc.h > +++ b/include/linux/remoteproc.h > @@ -329,7 +329,7 @@ struct rproc; > struct rproc_mem_entry { > void *va; > dma_addr_t dma; > - int len; > + size_t len; > u32 da; > void *priv; > char name[32]; > @@ -599,13 +599,13 @@ void rproc_add_carveout(struct rproc *rproc, struct rproc_mem_entry *mem); > > struct rproc_mem_entry * > rproc_mem_entry_init(struct device *dev, > - void *va, dma_addr_t dma, int len, u32 da, > + void *va, dma_addr_t dma, size_t len, u32 da, > int (*alloc)(struct rproc *, struct rproc_mem_entry *), > int (*release)(struct rproc *, struct rproc_mem_entry *), > const char *name, ...); > > struct rproc_mem_entry * > -rproc_of_resm_mem_entry_init(struct device *dev, u32 of_resm_idx, int len, > +rproc_of_resm_mem_entry_init(struct device *dev, u32 of_resm_idx, size_t len, > u32 da, const char *name, ...); > > int rproc_boot(struct rproc *rproc); > -- > 2.15.0.276.g89ea799 >