From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8392CC18E5A for ; Tue, 10 Mar 2020 19:32:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BCF222525 for ; Tue, 10 Mar 2020 19:32:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O7XNI6K/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727311AbgCJTc6 (ORCPT ); Tue, 10 Mar 2020 15:32:58 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:34611 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727442AbgCJTc6 (ORCPT ); Tue, 10 Mar 2020 15:32:58 -0400 Received: by mail-pf1-f195.google.com with SMTP id 23so5170624pfj.1 for ; Tue, 10 Mar 2020 12:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qMuGgR0+CRDM0BuHZ2Ae6KXyGRvF/Wi0RAPV3JkXST8=; b=O7XNI6K/jach7eBMD0zokAVd37z8MwdLv7WqFDGJUXpzEHJv/6LF5IM1MssL5NHx69 sERBdH0/wvxJRbfXc8ZfBW6WmU/BI5HjmYU5Pwy6aJgYPsoC/QOCaZUUfklrPzeM+LmE PliHwz3PwFW+ET0WFX++nrj0fUsGiY5wb79UMhnPsZ4NSU56/TwfJhVBhRED1eo7IZvY tSQ6LFPA1n/cAURoK6zJWkEVSXYiL6y+KiwY8l+yxV5JDY+n10m2MA3KzHqx7bRV4sL6 CAx0URzemFt5ihkASDeSRezGbX69RIjNEsoJ9YZzp9qrBY5Pp5i1yewl1O6hD70yt0SH wjTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qMuGgR0+CRDM0BuHZ2Ae6KXyGRvF/Wi0RAPV3JkXST8=; b=qLyA1S2aQ3in6E9j1g9NaCS/XMnSjQNx+3v44GojiZdevNC/cSDorji0Dz9PJutdW1 JQC6VEUCilIEfN6cwn+KDcTKVmhADl6FebD8CdG8U2gK8+lRGCj7OGnAXCNmndipYnmn r7RbVcNNgV8QoEur23Pef0ILLkbkXKxHFJexUpS7lunzvWyuNw3k3u4KRZIZKG8G+soH xCl9I09wm0Z8fEfImIOIjc09oz+Mw4O51unUDdoCPvSCpLJ8foqYQbkFdD1UDcp7Arp0 p2AfxmzGHqqBZZ4WTnrZ4oGDbAry8IwhENUYJlbrroBgssvmZmn9SYuOSCcJiT/L2JrE cRTA== X-Gm-Message-State: ANhLgQ0haTZQUDcUpdGTWqzFWuWY3plTAzsjuXUnLyCDV5VmKFcSxP3c 6+G1sxqd6WFPuJqsMy4iXi1L3g== X-Google-Smtp-Source: ADFU+vv+xHc+Rr1UGKn/v70xw8LFUA/EYdzRhMgcJY4xJ9NFuwzP6M5LicOfJuYbs5v5GixSEdrWVA== X-Received: by 2002:a63:7f09:: with SMTP id a9mr22043810pgd.375.1583868777114; Tue, 10 Mar 2020 12:32:57 -0700 (PDT) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id s18sm3003094pjp.24.2020.03.10.12.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 12:32:56 -0700 (PDT) Date: Tue, 10 Mar 2020 12:32:53 -0700 From: Bjorn Andersson To: Cl?ment Leger Cc: Mathieu Poirier , Ohad Ben-Cohen , Jonathan Corbet , Shawn Guo , Sascha Hauer , linux-remoteproc , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Patrice Chotard , linux-doc , linux-kernel , linux-arm-kernel , linux-arm-msm , Arnaud Pouliquen , Loic PALLARDY , s-anna Subject: Re: [PATCH v5 3/8] remoteproc: Use u64 type for boot_addr Message-ID: <20200310193253.GL264362@yoga> References: <20200210162209.23149-1-cleger@kalray.eu> <20200302093902.27849-1-cleger@kalray.eu> <20200302093902.27849-4-cleger@kalray.eu> <20200309195247.GC1399@xps15> <1297722115.9030349.1583827151221.JavaMail.zimbra@kalray.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1297722115.9030349.1583827151221.JavaMail.zimbra@kalray.eu> Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue 10 Mar 00:59 PDT 2020, Cl?ment Leger wrote: > > > ----- On 9 Mar, 2020, at 20:52, Mathieu Poirier mathieu.poirier@linaro.org wrote: > > > On Mon, Mar 02, 2020 at 10:38:57AM +0100, Clement Leger wrote: > >> elf64 entry is defined as a u64. Since boot_addr is used to store the > >> elf entry point, change boot_addr type to u64 to support both elf32 > >> and elf64. In the same time, fix users that were using this variable. > >> > >> Signed-off-by: Clement Leger > >> --- > >> drivers/remoteproc/remoteproc_elf_loader.c | 2 +- > >> drivers/remoteproc/remoteproc_internal.h | 2 +- > >> drivers/remoteproc/st_remoteproc.c | 2 +- > >> include/linux/remoteproc.h | 4 ++-- > >> 4 files changed, 5 insertions(+), 5 deletions(-) > >> > >> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c > >> b/drivers/remoteproc/remoteproc_elf_loader.c > >> index 606aae166eba..c2a9783cfb9a 100644 > >> --- a/drivers/remoteproc/remoteproc_elf_loader.c > >> +++ b/drivers/remoteproc/remoteproc_elf_loader.c > >> @@ -102,7 +102,7 @@ EXPORT_SYMBOL(rproc_elf_sanity_check); > >> * Note that the boot address is not a configurable property of all remote > >> * processors. Some will always boot at a specific hard-coded address. > >> */ > >> -u32 rproc_elf_get_boot_addr(struct rproc *rproc, const struct firmware *fw) > >> +u64 rproc_elf_get_boot_addr(struct rproc *rproc, const struct firmware *fw) > >> { > >> struct elf32_hdr *ehdr = (struct elf32_hdr *)fw->data; > >> > >> diff --git a/drivers/remoteproc/remoteproc_internal.h > >> b/drivers/remoteproc/remoteproc_internal.h > >> index 58580210575c..0deae5f237b8 100644 > >> --- a/drivers/remoteproc/remoteproc_internal.h > >> +++ b/drivers/remoteproc/remoteproc_internal.h > >> @@ -55,7 +55,7 @@ phys_addr_t rproc_va_to_pa(void *cpu_addr); > >> int rproc_trigger_recovery(struct rproc *rproc); > >> > >> int rproc_elf_sanity_check(struct rproc *rproc, const struct firmware *fw); > >> -u32 rproc_elf_get_boot_addr(struct rproc *rproc, const struct firmware *fw); > >> +u64 rproc_elf_get_boot_addr(struct rproc *rproc, const struct firmware *fw); > >> int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw); > >> int rproc_elf_load_rsc_table(struct rproc *rproc, const struct firmware *fw); > >> struct resource_table *rproc_elf_find_loaded_rsc_table(struct rproc *rproc, > > > > The return type of function rproc_get_boot_addr() should also be changed from > > u32 to u64. Or perhaps this is intentional to make sure rproc->bootaddr never > > occupies more than 32bit? > > No, this is a mistake clearly. I haven't been able to test with a 64 bit > boot address since our remote processors always boot in the 32 bits > space. But since the elf64 boot address is on 64 bitsn this was a logical > modification. I will fix that. > Sorry, I forgot to reply to this one. I fixed it up while applying the patch. Thanks, Bjorn > > > >> diff --git a/drivers/remoteproc/st_remoteproc.c > >> b/drivers/remoteproc/st_remoteproc.c > >> index ee13d23b43a9..a3268d95a50e 100644 > >> --- a/drivers/remoteproc/st_remoteproc.c > >> +++ b/drivers/remoteproc/st_remoteproc.c > >> @@ -190,7 +190,7 @@ static int st_rproc_start(struct rproc *rproc) > >> } > >> } > >> > >> - dev_info(&rproc->dev, "Started from 0x%x\n", rproc->bootaddr); > >> + dev_info(&rproc->dev, "Started from 0x%llx\n", rproc->bootaddr); > >> > >> return 0; > >> > >> diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h > >> index bee559330204..1683d6c386a6 100644 > >> --- a/include/linux/remoteproc.h > >> +++ b/include/linux/remoteproc.h > >> @@ -382,7 +382,7 @@ struct rproc_ops { > >> struct rproc *rproc, const struct firmware *fw); > >> int (*load)(struct rproc *rproc, const struct firmware *fw); > >> int (*sanity_check)(struct rproc *rproc, const struct firmware *fw); > >> - u32 (*get_boot_addr)(struct rproc *rproc, const struct firmware *fw); > >> + u64 (*get_boot_addr)(struct rproc *rproc, const struct firmware *fw); > >> }; > >> > >> /** > >> @@ -498,7 +498,7 @@ struct rproc { > >> int num_traces; > >> struct list_head carveouts; > >> struct list_head mappings; > >> - u32 bootaddr; > >> + u64 bootaddr; > >> struct list_head rvdevs; > >> struct list_head subdevs; > >> struct idr notifyids; > >> -- > >> 2.15.0.276.g89ea799