From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4668EC2D0F0 for ; Fri, 27 Mar 2020 01:08:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13ADF208E0 for ; Fri, 27 Mar 2020 01:08:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="3kOrAlvV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727689AbgC0BHO (ORCPT ); Thu, 26 Mar 2020 21:07:14 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60766 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727547AbgC0BHO (ORCPT ); Thu, 26 Mar 2020 21:07:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=slYTqywddxrf0q3UZbv67p05DHILUfdrIqKZxFHxC1E=; b=3kOrAlvVmmPPwwZfajoPD2PdsW OFFOFEQMtbPAifE8/t3CqUlvoCAtih0bSDE5zz/ccmsMTN6WZTihEAGP43vYv7O3wOLoD7aIbJpP5 fvSEs3iEaIEbaZfK84Pmq7WzeZLDfwTvVEuI8tvzJuY65HsS9SzKY7PkCwZFjDqG75ao=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jHdSk-0005Ku-Cl; Fri, 27 Mar 2020 02:07:06 +0100 Date: Fri, 27 Mar 2020 02:07:06 +0100 From: Andrew Lunn To: Florinel Iordache Cc: davem@davemloft.net, netdev@vger.kernel.org, f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, kuba@kernel.org, corbet@lwn.net, shawnguo@kernel.org, leoyang.li@nxp.com, madalin.bucur@oss.nxp.com, ioana.ciornei@nxp.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 6/9] net: phy: add backplane kr driver support Message-ID: <20200327010706.GN3819@lunn.ch> References: <1585230682-24417-1-git-send-email-florinel.iordache@nxp.com> <1585230682-24417-7-git-send-email-florinel.iordache@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1585230682-24417-7-git-send-email-florinel.iordache@nxp.com> Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org > +static u32 le_ioread32(void __iomem *reg) > +{ > + return ioread32(reg); > +} > + > +static void le_iowrite32(u32 value, void __iomem *reg) > +{ > + iowrite32(value, reg); > +} > + > +static u32 be_ioread32(void __iomem *reg) > +{ > + return ioread32be(reg); > +} > + > +static void be_iowrite32(u32 value, void __iomem *reg) > +{ > + iowrite32be(value, reg); > +} This is very surprising to me. I've not got my head around the structure of this code yet, but i'm surprised to see memory mapped access functions in generic code. Andrew