From: Jonathan Corbet <corbet@lwn.net>
To: Puranjay Mohan <puranjay12@gmail.com>
Cc: skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Security: Documentation: Replace deprecated :c:func: Usage
Date: Mon, 6 Jul 2020 14:31:04 -0600 [thread overview]
Message-ID: <20200706143104.48fa2bd1@lwn.net> (raw)
In-Reply-To: <20200706184956.6928-1-puranjay12@gmail.com>
On Tue, 7 Jul 2020 00:19:56 +0530
Puranjay Mohan <puranjay12@gmail.com> wrote:
> Replace :c:func: with ``func()`` as the previous usage is deprecated.
> Remove an extra ')' to fix broken cross reference.
>
> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
> ---
> V2: Remove ``quotes`` around function names
> V1: Change the subject line and remove deprecated :c:func: usage
> ---
> Documentation/security/credentials.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/security/credentials.rst b/Documentation/security/credentials.rst
> index 282e79feee6a..15175b11336c 100644
> --- a/Documentation/security/credentials.rst
> +++ b/Documentation/security/credentials.rst
> @@ -453,9 +453,9 @@ still at this point.
>
> When replacing the group list, the new list must be sorted before it
> is added to the credential, as a binary search is used to test for
> -membership. In practice, this means :c:func:`groups_sort` should be
> -called before :c:func:`set_groups` or :c:func:`set_current_groups`.
> -:c:func:`groups_sort)` must not be called on a ``struct group_list`` which
> +membership. In practice, this means groups_sort() should be
> +called before set_groups() or set_current_groups().
> +groups_sort() must not be called on a ``struct group_list`` which
> is shared as it may permute elements as part of the sorting process
> even if the array is already sorted.
I've applied this, many thanks.
jon
prev parent reply other threads:[~2020-07-06 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 18:49 [PATCH v2] Security: Documentation: Replace deprecated :c:func: Usage Puranjay Mohan
2020-07-06 20:31 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706143104.48fa2bd1@lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay12@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).