From: SeongJae Park <sjpark@amazon.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: SeongJae Park <sjpark@amazon.com>, <akpm@linux-foundation.org>,
"SeongJae Park" <sjpark@amazon.de>, <Jonathan.Cameron@huawei.com>,
<aarcange@redhat.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <amit@kernel.org>,
<benh@kernel.crashing.org>, <brendan.d.gregg@gmail.com>,
<brendanhiggins@google.com>, <cai@lca.pw>,
<colin.king@canonical.com>, <corbet@lwn.net>, <david@redhat.com>,
<dwmw@amazon.com>, <foersleo@amazon.de>, <irogers@google.com>,
<jolsa@redhat.com>, <kirill@shutemov.name>,
<mark.rutland@arm.com>, <mgorman@suse.de>, <minchan@kernel.org>,
<mingo@redhat.com>, <namhyung@kernel.org>, <peterz@infradead.org>,
<rdunlap@infradead.org>, <riel@surriel.com>,
<rientjes@google.com>, <rostedt@goodmis.org>, <sblbir@amazon.com>,
<shakeelb@google.com>, <shuah@kernel.org>, <sj38.park@gmail.com>,
<snu@amazon.de>, <vbabka@suse.cz>, <vdavydov.dev@gmail.com>,
<yang.shi@linux.alibaba.com>, <ying.huang@intel.com>,
<linux-damon@amazon.com>, <linux-mm@kvack.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: Re: Re: [PATCH v18 01/14] mm/page_ext: Export lookup_page_ext() to GPL modules
Date: Mon, 13 Jul 2020 19:38:05 +0200 [thread overview]
Message-ID: <20200713173805.31923-1-sjpark@amazon.com> (raw)
In-Reply-To: <20200713171909.GD707159@kernel.org> (raw)
On Mon, 13 Jul 2020 20:19:09 +0300 Mike Rapoport <rppt@kernel.org> wrote:
> On Mon, Jul 13, 2020 at 02:21:43PM +0200, SeongJae Park wrote:
> > On Mon, 13 Jul 2020 15:08:42 +0300 Mike Rapoport <rppt@kernel.org> wrote:
> >
> > > Hi,
> > >
> > > On Mon, Jul 13, 2020 at 10:41:31AM +0200, SeongJae Park wrote:
> > > > From: SeongJae Park <sjpark@amazon.de>
> > > >
> > > > This commit exports 'lookup_page_ext()' to GPL modules. It will be used
> > > > by DAMON in following commit for the implementation of the region based
> > > > sampling.
> > >
> > > Maybe I'm missing something, but why is DAMON a module?
> >
> > I made it loadable just for easier adoption from downstream kernels. I could
> > drop the module build support if asked.
>
> Well, exporting core mm symbols to modules should be considred very
> carefully.
Agreed. I will drop the module support from the next spin.
>
> Why lookup_page_ext() is required for DAMON? It is not used anywhere in
> this patchset.
It's indirectly used. In the 6th patch, DAMON uses 'set_page_young()' to not
interfere with other PTE Accessed bit users. And, 'set_page_young()' uses
'lookup_page_ext()' if !CONFIG_64BIT. That's why I exported it.
Thanks,
SeongJae Park
next prev parent reply other threads:[~2020-07-13 17:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 8:41 [PATCH v18 00/14] Introduce Data Access MONitor (DAMON) SeongJae Park
2020-07-13 8:41 ` [PATCH v18 01/14] mm/page_ext: Export lookup_page_ext() to GPL modules SeongJae Park
2020-07-13 12:08 ` Mike Rapoport
2020-07-13 12:21 ` SeongJae Park
2020-07-13 17:19 ` Mike Rapoport
2020-07-13 17:38 ` SeongJae Park [this message]
2020-07-17 9:59 ` Re: " SeongJae Park
2020-07-13 8:41 ` [PATCH v18 02/14] mm: Introduce Data Access MONitor (DAMON) SeongJae Park
2020-07-18 2:47 ` Shakeel Butt
2020-07-18 13:31 ` SeongJae Park
2020-07-29 15:31 ` Shakeel Butt
2020-07-29 17:29 ` SeongJae Park
2020-07-13 8:41 ` [PATCH v18 03/14] mm/damon: Implement region based sampling SeongJae Park
2020-07-13 8:41 ` [PATCH v18 04/14] mm/damon: Adaptively adjust regions SeongJae Park
2020-07-13 8:41 ` [PATCH v18 05/14] mm/damon: Track dynamic monitoring target regions update SeongJae Park
2020-07-13 8:41 ` [PATCH v18 06/14] mm/damon: Implement callbacks for the virtual memory address spaces SeongJae Park
2020-07-17 0:46 ` Shakeel Butt
2020-07-17 6:53 ` SeongJae Park
2020-07-17 15:17 ` Shakeel Butt
2020-07-17 16:24 ` SeongJae Park
2020-07-18 2:23 ` Shakeel Butt
2020-07-18 2:51 ` SeongJae Park
2020-07-27 7:34 ` Greg Thelen
2020-07-27 9:02 ` SeongJae Park
2020-07-28 17:42 ` Shakeel Butt
2020-07-29 6:20 ` SeongJae Park
2020-07-13 8:41 ` [PATCH v18 07/14] mm/damon: Implement access pattern recording SeongJae Park
2020-07-13 8:41 ` [PATCH v18 08/14] mm/damon: Add a tracepoint SeongJae Park
2020-07-13 8:41 ` [PATCH v18 09/14] mm/damon: Implement a debugfs interface SeongJae Park
2020-07-22 10:36 ` SeongJae Park
2020-07-13 8:41 ` [PATCH v18 10/14] tools: Introduce a minimal user-space tool for DAMON SeongJae Park
2020-07-13 8:41 ` [PATCH v18 11/14] Documentation: Add documents " SeongJae Park
2020-07-27 7:19 ` Greg Thelen
2020-07-27 7:38 ` SeongJae Park
2020-07-13 8:41 ` [PATCH v18 12/14] mm/damon: Add kunit tests SeongJae Park
2020-07-13 8:41 ` [PATCH v18 13/14] mm/damon: Add user space selftests SeongJae Park
2020-07-13 8:41 ` [PATCH v18 14/14] MAINTAINERS: Update for DAMON SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713173805.31923-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=aarcange@redhat.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendan.d.gregg@gmail.com \
--cc=brendanhiggins@google.com \
--cc=cai@lca.pw \
--cc=colin.king@canonical.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwmw@amazon.com \
--cc=foersleo@amazon.de \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=sblbir@amazon.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=snu@amazon.de \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).