From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Alistair Delva <adelva@google.com>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] bootconfig: Add value override operator
Date: Thu, 16 Jul 2020 07:38:43 +0900 [thread overview]
Message-ID: <20200716073843.e7b1921aae962da9e5714fe0@kernel.org> (raw)
In-Reply-To: <20200715164504.3400efc5@oasis.local.home>
On Wed, 15 Jul 2020 16:45:04 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 16 Jul 2020 01:00:21 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > With this change, if the bootloader wants to change some value
> > in the default bootconfig, it doesn't need to parse the existing
> > bootconfig, but it can just append the new configs at the tail
> > of the bootconfig and update the footer (size, checksum and magic
> > word).
>
> I wonder if we should support multiple bootconfigs instead of updating
> the size/checksum/magic?
>
> So the end of the initrd would have:
>
> [data][size/checksum/magic][more-data][size/checksum/magic]
>
>
> And the kernel could do the following:
>
> 1. read the end of the initrd for bootconfig
> 2. If found parse the bootconfig data.
> 3. look at the content before the bootconfig
> 4. if another bootconfig exists, goto 2.
>
Yeah, that is possible. But since the total size of the bootconfig
is limited to 32KB (this means data + 1st footer + more-data),
I would like to give a chance of sanity check to the bootloader.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-07-15 22:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 16:00 [PATCH 0/3] bootconfig: Add value override operator Masami Hiramatsu
2020-07-15 16:00 ` [PATCH 1/3] lib/bootconfig: Add override operator support Masami Hiramatsu
2020-07-15 16:00 ` [PATCH 2/3] tools/bootconfig: Add testcases for value override operator Masami Hiramatsu
2020-07-15 16:00 ` [PATCH 3/3] Documentation: bootconfig: Add bootconfig " Masami Hiramatsu
2020-07-15 20:45 ` [PATCH 0/3] bootconfig: Add value " Steven Rostedt
2020-07-15 22:38 ` Masami Hiramatsu [this message]
2020-07-16 0:02 ` Steven Rostedt
2020-07-16 1:27 ` Masami Hiramatsu
2020-07-30 0:56 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716073843.e7b1921aae962da9e5714fe0@kernel.org \
--to=mhiramat@kernel.org \
--cc=adelva@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).