From: Leon Romanovsky <leon@kernel.org>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>
Cc: santosh.shilimkar@oracle.com, davem@davemloft.net,
kuba@kernel.org, corbet@lwn.net, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones
Date: Mon, 20 Jul 2020 07:56:26 +0300 [thread overview]
Message-ID: <20200720045626.GF127306@unreal> (raw)
In-Reply-To: <20200719155845.59947-1-grandmaster@al2klimov.de>
On Sun, Jul 19, 2020 at 05:58:45PM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
> ---
> Continuing my work started at 93431e0607e5.
> See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@al2klimov.de>' v5.7..master
> (Actually letting a shell for loop submit all this stuff for me.)
>
> If there are any URLs to be removed completely
> or at least not (just) HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also: https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See: https://lkml.org/lkml/2020/6/26/837
>
> If you apply the patch, please let me know.
>
> Sorry again to all maintainers who complained about subject lines.
> Now I realized that you want an actually perfect prefixes,
> not just subsystem ones.
> I tried my best...
> And yes, *I could* (at least half-)automate it.
> Impossible is nothing! :)
>
>
> Documentation/networking/rds.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Why can't it be done in one mega-patch?
It is insane to see patch for every file/link.
We have more than 4k files with http:// in it.
➜ kernel git:(m/hw-cleanup) git grep -c http: | tr -d ':[:digit:]' | sort | uniq |wc -l
4292
>
> diff --git a/Documentation/networking/rds.rst b/Documentation/networking/rds.rst
> index 44936c27ab3a..c80d832509e2 100644
> --- a/Documentation/networking/rds.rst
> +++ b/Documentation/networking/rds.rst
> @@ -11,7 +11,7 @@ This readme tries to provide some background on the hows and whys of RDS,
> and will hopefully help you find your way around the code.
>
> In addition, please see this email about RDS origins:
> -http://oss.oracle.com/pipermail/rds-devel/2007-November/000228.html
> +https://oss.oracle.com/pipermail/rds-devel/2007-November/000228.html
>
> RDS Architecture
> ================
> --
> 2.27.0
>
next prev parent reply other threads:[~2020-07-20 4:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 15:58 [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones Alexander A. Klimov
2020-07-20 4:56 ` Leon Romanovsky [this message]
2020-07-20 13:58 ` Jonathan Corbet
2020-07-20 14:07 ` Leon Romanovsky
2020-07-20 14:36 ` Jonathan Corbet
2020-07-20 16:48 ` Leon Romanovsky
2020-07-20 21:34 ` Alexander A. Klimov
2020-07-21 6:05 ` Leon Romanovsky
2020-07-21 6:43 ` Alexander A. Klimov
2020-07-21 8:54 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720045626.GF127306@unreal \
--to=leon@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=grandmaster@al2klimov.de \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).