Linux-Doc Archive on lore.kernel.org
 help / color / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: watch_queue.rst: fix malformed inline literal
Date: Thu, 23 Jul 2020 14:22:42 -0600
Message-ID: <20200723142242.5fd5760f@lwn.net> (raw)
In-Reply-To: <20200718165107.625847-2-dwlsalmeida@gmail.com>

On Sat, 18 Jul 2020 13:50:56 -0300
"Daniel W. S. Almeida" <dwlsalmeida@gmail.com> wrote:

>  To manage a watch list, the following functions are provided:
>  
> -  * ``void init_watch_list(struct watch_list *wlist,
> -			   void (*release_watch)(struct watch *wlist));``
> +  * ``void init_watch_list(struct watch_list *wlist, void (*release_watch)(struct watch *wlist));``
>  
>      Initialise a watch list.  If ``release_watch`` is not NULL, then this
>      indicates a function that should be called when the watch_list object is
> @@ -182,9 +181,9 @@ The following functions are provided to manage watches:
>      driver-settable fields in the watch struct must have been set before this
>      is called.
>  
> -  * ``int remove_watch_from_object(struct watch_list *wlist,
> -				   struct watch_queue *wqueue,
> -				   u64 id, false);``
> +  * ``int remove_watch_from_object(struct watch_list *wlist,``
> +				 ``struct watch_queue *wqueue,``
> +				 ``u64 id, false);``

This is very much the wrong fix; please just put the text into a literal
block instead.

Thanks,

jon

  reply index

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18 16:50 [PATCH] docs: admin-guide/mm/index: Fix reference to nonexistent document Daniel W. S. Almeida
2020-07-18 16:50 ` [PATCH] docs: watch_queue.rst: fix malformed inline literal Daniel W. S. Almeida
2020-07-23 20:22   ` Jonathan Corbet [this message]
2020-07-18 16:50 ` [PATCH] docs: kvm/api.rst: Fix indentation Daniel W. S. Almeida
2020-07-18 16:50 ` [PATCH] docs: staging/tee.rst: convert into definition list Daniel W. S. Almeida
2020-07-23 20:25   ` Jonathan Corbet
2020-07-18 16:50 ` [PATCH] docs: process/index.rst: Fix reference to nonexistent document Daniel W. S. Almeida
2020-07-20  1:02   ` Kees Cook
2020-07-20 12:39   ` Stephen Kitt
2020-07-23 20:26   ` Jonathan Corbet
2020-07-18 16:51 ` [PATCH] docs: admin-guide/index.rst: Add pstore-blk.rst Daniel W. S. Almeida
2020-07-20  1:01   ` Kees Cook
2020-07-23 20:20   ` Jonathan Corbet
2020-07-18 16:51 ` [PATCH] docs: firmware-guide/acpi/index.rst: Add intel-pmc-mux.rst Daniel W. S. Almeida
2020-07-18 16:51 ` [PATCH] docs: trace/index.rst: add histogram-design.rst Daniel W. S. Almeida
2020-07-23 20:16   ` Jonathan Corbet
     [not found] ` <20200718165107.625847-8-dwlsalmeida@gmail.com>
2020-07-18 17:45   ` [PATCH] docs: core-api/printk-formats.rst: use literal block syntax Andy Shevchenko
2020-07-19  2:55   ` Sergey Senozhatsky
2020-07-21 14:02   ` Sergey Senozhatsky
2020-07-21 14:24     ` Jonathan Corbet
2020-07-21 14:27       ` Sergey Senozhatsky
2020-07-23 20:29   ` Jonathan Corbet
     [not found] ` <20200718165107.625847-13-dwlsalmeida@gmail.com>
2020-07-23 20:14   ` [PATCH] docs: index.rst: Add watch_queue Jonathan Corbet
     [not found] ` <20200718165107.625847-10-dwlsalmeida@gmail.com>
2020-07-23 20:17   ` [PATCH] docs: bpf/index.rst: Add ringbuf.rst Jonathan Corbet
2020-07-23 20:21 ` [PATCH] docs: admin-guide/mm/index: Fix reference to nonexistent document Jonathan Corbet
     [not found] ` <20200718165107.625847-6-dwlsalmeida@gmail.com>
2020-07-23 20:27   ` [PATCH] docs: bpf/bpf_devel_QA.rst: fix " Jonathan Corbet
     [not found] ` <20200718165107.625847-7-dwlsalmeida@gmail.com>
2020-07-23 20:36   ` [PATCH] docs: bpf/ringbuf.rst: " Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723142242.5fd5760f@lwn.net \
    --to=corbet@lwn.net \
    --cc=dwlsalmeida@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Doc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-doc/0 linux-doc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-doc linux-doc/ https://lore.kernel.org/linux-doc \
		linux-doc@vger.kernel.org
	public-inbox-index linux-doc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-doc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git