From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: Jonathan Corbet <corbet@lwn.net>,
kernel-janitors@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: filesystems: vfs: correct flag name
Date: Sun, 26 Jul 2020 18:49:20 -0700 [thread overview]
Message-ID: <20200727014920.GN7625@magnolia> (raw)
In-Reply-To: <1595789020-12941-1-git-send-email-Julia.Lawall@inria.fr>
On Sun, Jul 26, 2020 at 08:43:40PM +0200, Julia Lawall wrote:
> There is no flag REMAP_CAN_SHORTEN. Commit eca3654e3cc7 ("vfs: enable
> remap callers that can handle short operations") that introduces this
> text also introduces the flag REMAP_FILE_CAN_SHORTEN. Change the name
> in the documentation accordingly.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
D'oh. Good catch!
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> ---
> Documentation/filesystems/vfs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/vfs.rst b/Documentation/filesystems/vfs.rst
> index da4b735..d08357d 100644
> --- a/Documentation/filesystems/vfs.rst
> +++ b/Documentation/filesystems/vfs.rst
> @@ -1116,7 +1116,7 @@ otherwise noted.
> before any bytes were remapped. The remap_flags parameter
> accepts REMAP_FILE_* flags. If REMAP_FILE_DEDUP is set then the
> implementation must only remap if the requested file ranges have
> - identical contents. If REMAP_CAN_SHORTEN is set, the caller is
> + identical contents. If REMAP_FILE_CAN_SHORTEN is set, the caller is
> ok with the implementation shortening the request length to
> satisfy alignment or EOF requirements (or any other reason).
>
>
next prev parent reply other threads:[~2020-07-27 1:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 18:43 [PATCH] docs: filesystems: vfs: correct flag name Julia Lawall
2020-07-27 1:49 ` Darrick J. Wong [this message]
2020-07-27 22:20 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727014920.GN7625@magnolia \
--to=darrick.wong@oracle.com \
--cc=Julia.Lawall@inria.fr \
--cc=corbet@lwn.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).