From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 991B2C43457 for ; Tue, 13 Oct 2020 20:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46E0E20EDD for ; Tue, 13 Oct 2020 20:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602621975; bh=3ApEKt0+9kZ4IhsU+7nj2jOoMK/qjUd5zeELYHUzVq8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=xdvnjSY77++RE4jfi/si4zvBpIxAnnBRld8ACmjFSdN0GvK3T7Klk/ktc4bxUt5pX 99ctiOIeKADti/YGERwJH6UJJvewAtFALLCTwzvh8ZB/cGvHCBdxD9hZ4BfOFNcnpD pLdCpCJ9SGtJdo597YAZTQjPofOzfU6IMbYeMIcU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727875AbgJMUqO (ORCPT ); Tue, 13 Oct 2020 16:46:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:36950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727397AbgJMUqO (ORCPT ); Tue, 13 Oct 2020 16:46:14 -0400 Received: from coco.lan (ip5f5ad5b2.dynamic.kabel-deutschland.de [95.90.213.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A34220878; Tue, 13 Oct 2020 20:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602621973; bh=3ApEKt0+9kZ4IhsU+7nj2jOoMK/qjUd5zeELYHUzVq8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ku0ra5WvDYWyqb8GnTCE7GaYItgoQaFxgtVOCIdaVX3aNVUwJTlsD4UopO6VkrWff TeiTqe+HFvXQsleMtPC1wvwKTPtEfdfBMOja08rKjg5oET76aYazFOqtKztZaV95JP 21DC9p+X9K7XURU3/XcManTFm50SveGkDTl5RzIE= Date: Tue, 13 Oct 2020 22:46:08 +0200 From: Mauro Carvalho Chehab To: "Paul E. McKenney" Cc: Linux Doc Mailing List , Jonathan Corbet , "Uladzislau Rezki (Sony)" , Joel Fernandes , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Steven Rostedt , linux-kernel@vger.kernel.org, rcu@vger.kernel.org Subject: Re: [PATCH v6 70/80] rcu/tree: docs: document bkvcache new members at struct kfree_rcu_cpu Message-ID: <20201013224608.30dd1bc9@coco.lan> In-Reply-To: <20201013163404.GP3249@paulmck-ThinkPad-P72> References: <6dd0804d6fd567f11e4c6efb767e91acca659d1f.1602589096.git.mchehab+huawei@kernel.org> <20201013163404.GP3249@paulmck-ThinkPad-P72> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Em Tue, 13 Oct 2020 09:34:04 -0700 "Paul E. McKenney" escreveu: > On Tue, Oct 13, 2020 at 01:54:25PM +0200, Mauro Carvalho Chehab wrote: > > Changeset 53c72b590b3a ("rcu/tree: cache specified number of objects") > > added new members for struct kfree_rcu_cpu, but didn't add the > > corresponding at the kernel-doc markup, as repoted when doing > > "make htmldocs": > > ./kernel/rcu/tree.c:3113: warning: Function parameter or member 'bkvcache' not described in 'kfree_rcu_cpu' > > ./kernel/rcu/tree.c:3113: warning: Function parameter or member 'nr_bkv_objs' not described in 'kfree_rcu_cpu' > > > > So, move the description for bkvcache to kernel-doc, and add a > > description for nr_bkv_objs. > > > > Fixes: 53c72b590b3a ("rcu/tree: cache specified number of objects") > > Signed-off-by: Mauro Carvalho Chehab > > Queued for review and testing, likely target v5.11. Hi Paul, I would prefer if we could get those on 5.10, if possible. We're aiming to have 5.10 free of docs warnings ;-) If you prefer, I can send those patches to Linus with your ack. Regards, Mauro > > Thanx, Paul > > > --- > > kernel/rcu/tree.c | 14 ++++++-------- > > 1 file changed, 6 insertions(+), 8 deletions(-) > > > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > > index f78ee759af9c..03c54c3478b7 100644 > > --- a/kernel/rcu/tree.c > > +++ b/kernel/rcu/tree.c > > @@ -3022,6 +3022,12 @@ struct kfree_rcu_cpu_work { > > * @monitor_todo: Tracks whether a @monitor_work delayed work is pending > > * @initialized: The @rcu_work fields have been initialized > > * @count: Number of objects for which GP not started > > + * @bkvcache: > > + * A simple cache list that contains objects for reuse purpose. > > + * In order to save some per-cpu space the list is singular. > > + * Even though it is lockless an access has to be protected by the > > + * per-cpu lock. > > + * @nr_bkv_objs: number of allocated objects at @bkvcache. > > * > > * This is a per-CPU structure. The reason that it is not included in > > * the rcu_data structure is to permit this code to be extracted from > > @@ -3037,14 +3043,6 @@ struct kfree_rcu_cpu { > > bool monitor_todo; > > bool initialized; > > int count; > > - > > - /* > > - * A simple cache list that contains objects for > > - * reuse purpose. In order to save some per-cpu > > - * space the list is singular. Even though it is > > - * lockless an access has to be protected by the > > - * per-cpu lock. > > - */ > > struct llist_head bkvcache; > > int nr_bkv_objs; > > }; > > -- > > 2.26.2 > > Thanks, Mauro