From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1699FC63697 for ; Wed, 18 Nov 2020 14:25:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 954AA246B2 for ; Wed, 18 Nov 2020 14:25:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QZFQ9NMj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbgKROZ5 (ORCPT ); Wed, 18 Nov 2020 09:25:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbgKROZ5 (ORCPT ); Wed, 18 Nov 2020 09:25:57 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BF9AC0613D4 for ; Wed, 18 Nov 2020 06:25:56 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id w24so2909455wmi.0 for ; Wed, 18 Nov 2020 06:25:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M3TahTJ7BjaCKL6cCJzT4YU2/8yPvTg3NC9HtjjwB6E=; b=QZFQ9NMjk1u7iGKZodsPpAnv4GlhVxHP8yp3CWAfrgMAFbKO6nrCYfFkg+HMWylVQy 4xwD0VvkN7cxe+o3TpUlsr0F0spio0q+/q9/CytGbvrKuOW6e2SVvNhL1cG+BP9zGKNv BIj2bn9jiVUoV6HSPLoZZs/rv8hIxQB7+6vjE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M3TahTJ7BjaCKL6cCJzT4YU2/8yPvTg3NC9HtjjwB6E=; b=DZYPYB0ffeynf/ODlUnvAM+Rww34Qra3f4zkENksOgli+fA/o0txXNJO75dGEg4oE7 VVyEKRzaJe1j58/BARuJa+dPtQZ1DsTMoQ2uLVRqo4OwNXHciGvOrsNBJOYKvX4ihK1c 9jh6KOUmt3fMxJ00zjkbvFfp9iVfZ3BUcdglUint4SGwgO7lDCh/jrpvDfJA7rFwpoci VoVdJEi8k+CfYroVKa4GqH33faysQgudjG+WOG46sUk4iwYUsT5W0yyJ+/++X7NCdddQ 1STAQkMU5UzOgYApcGB4/41sZX93R0i6iMwSRiCd2BWt4Gc//2/VFFkxAx9l8cF4p5gx x0Gw== X-Gm-Message-State: AOAM533wchHo8duMkGXpBXCV7hoRX+IiUhoomugomNeLv6m1uX9Grktm VnwUdNaQy/+cEhtEl0dbBtDWmw== X-Google-Smtp-Source: ABdhPJwIJfDIcqzIaOjyyYLoJOkj2Cs5fEWxJOZTYwXsOeX7KufPglMZqaylZEbPYySTYkeFoUw2eg== X-Received: by 2002:a1c:7f90:: with SMTP id a138mr292131wmd.61.1605709555144; Wed, 18 Nov 2020 06:25:55 -0800 (PST) Received: from alco.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id o4sm491028wmh.33.2020.11.18.06.25.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 06:25:54 -0800 (PST) From: Ricardo Ribalda To: Christoph Hellwig , Mauro Carvalho Chehab , Marek Szyprowski , IOMMU DRIVERS , Joerg Roedel , Robin Murphy , Linux Doc Mailing List , Linux Kernel Mailing List , Linux Media Mailing List , Tomasz Figa Cc: Ricardo Ribalda Subject: [PATCH] WIP! media: uvcvideo: Use dma_alloc_noncontiguos API Date: Wed, 18 Nov 2020 15:25:46 +0100 Message-Id: <20201118142546.170621-1-ribalda@chromium.org> X-Mailer: git-send-email 2.29.2.299.gdc1121823c-goog In-Reply-To: <20200930160917.1234225-9-hch@lst.de> References: <20200930160917.1234225-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On architectures where the is no coherent caching such as ARM use the dma_alloc_noncontiguos API and handle manually the cache flushing using dma_sync_single(). With this patch on the affected architectures we can measure up to 20x performance improvement in uvc_video_copy_data_work(). Signed-off-by: Ricardo Ribalda --- This patch depends on dma_alloc_contiguous API1315351diffmboxseries https://lore.kernel.org/patchwork/patch/1315351/#1535182 drivers/media/usb/uvc/uvc_video.c | 69 +++++++++++++++++++++++++------ drivers/media/usb/uvc/uvcvideo.h | 1 + 2 files changed, 58 insertions(+), 12 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index ff624bb857d3..ef1b029b8576 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -1641,6 +1641,11 @@ static void uvc_video_encode_bulk(struct uvc_urb *uvc_urb, urb->transfer_buffer_length = stream->urb_size - len; } +static inline struct device *stream_to_dmadev(struct uvc_streaming *stream) +{ + return stream->dev->udev->bus->controller->parent; +} + static void uvc_video_complete(struct urb *urb) { struct uvc_urb *uvc_urb = urb->context; @@ -1693,6 +1698,11 @@ static void uvc_video_complete(struct urb *urb) * Process the URB headers, and optionally queue expensive memcpy tasks * to be deferred to a work queue. */ + if (uvc_urb->pages) + dma_sync_single_for_cpu(stream_to_dmadev(stream), + urb->transfer_dma, + urb->transfer_buffer_length, + DMA_FROM_DEVICE); stream->decode(uvc_urb, buf, buf_meta); /* If no async work is needed, resubmit the URB immediately. */ @@ -1723,8 +1733,15 @@ static void uvc_free_urb_buffers(struct uvc_streaming *stream) continue; #ifndef CONFIG_DMA_NONCOHERENT - usb_free_coherent(stream->dev->udev, stream->urb_size, - uvc_urb->buffer, uvc_urb->dma); + if (uvc_urb->pages) { + vunmap(uvc_urb->buffer); + dma_free_noncontiguous(stream_to_dmadev(stream), + stream->urb_size, + uvc_urb->pages, uvc_urb->dma); + } else { + usb_free_coherent(stream->dev->udev, stream->urb_size, + uvc_urb->buffer, uvc_urb->dma); + } #else kfree(uvc_urb->buffer); #endif @@ -1734,6 +1751,42 @@ static void uvc_free_urb_buffers(struct uvc_streaming *stream) stream->urb_size = 0; } +#ifndef CONFIG_DMA_NONCOHERENT +static bool uvc_alloc_urb_buffer(struct uvc_streaming *stream, struct uvc_urb *uvc_urb, + gfp_t gfp_flags) +{ + struct device *dma_dev = dma_dev = stream_to_dmadev(stream); + + if (!dma_can_alloc_noncontiguous(dma_dev)) { + uvc_urb->buffer = usb_alloc_coherent(stream->dev->udev, stream->urb_size, + gfp_flags | __GFP_NOWARN, &uvc_urb->dma); + return uvc_urb->buffer != NULL; + } + + uvc_urb->pages = dma_alloc_noncontiguous(dma_dev, stream->urb_size, + &uvc_urb->dma, gfp_flags | __GFP_NOWARN, 0); + if (!uvc_urb->pages) + return false; + + uvc_urb->buffer = vmap(uvc_urb->pages, PAGE_ALIGN(stream->urb_size) >> PAGE_SHIFT, + VM_DMA_COHERENT, PAGE_KERNEL); + if (!uvc_urb->buffer) { + dma_free_noncontiguous(dma_dev, stream->urb_size, uvc_urb->pages, uvc_urb->dma); + return false; + } + + return true; +} +#else +static bool uvc_alloc_urb_buffer(struct uvc_streaming *stream, struct uvc_urb *uvc_urb, + gfp_t gfp_flags) +{ + uvc_urb->buffer = kmalloc(stream->urb_size, gfp_flags | __GFP_NOWARN); + + return uvc_urb->buffer != NULL; +} +#endif + /* * Allocate transfer buffers. This function can be called with buffers * already allocated when resuming from suspend, in which case it will @@ -1764,19 +1817,11 @@ static int uvc_alloc_urb_buffers(struct uvc_streaming *stream, /* Retry allocations until one succeed. */ for (; npackets > 1; npackets /= 2) { + stream->urb_size = psize * npackets; for (i = 0; i < UVC_URBS; ++i) { struct uvc_urb *uvc_urb = &stream->uvc_urb[i]; - stream->urb_size = psize * npackets; -#ifndef CONFIG_DMA_NONCOHERENT - uvc_urb->buffer = usb_alloc_coherent( - stream->dev->udev, stream->urb_size, - gfp_flags | __GFP_NOWARN, &uvc_urb->dma); -#else - uvc_urb->buffer = - kmalloc(stream->urb_size, gfp_flags | __GFP_NOWARN); -#endif - if (!uvc_urb->buffer) { + if (!uvc_alloc_urb_buffer(stream, uvc_urb, gfp_flags)) { uvc_free_urb_buffers(stream); break; } diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h index 60d830d74ac1..80eeeaf3cd06 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -544,6 +544,7 @@ struct uvc_urb { char *buffer; dma_addr_t dma; + struct page **pages; unsigned int async_operations; struct uvc_copy_op copy_operations[UVC_MAX_PACKETS]; -- 2.29.2.299.gdc1121823c-goog