From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1EFAC64E8A for ; Wed, 2 Dec 2020 15:42:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8601720B1F for ; Wed, 2 Dec 2020 15:42:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387396AbgLBPmF (ORCPT ); Wed, 2 Dec 2020 10:42:05 -0500 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:47801 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728308AbgLBPmF (ORCPT ); Wed, 2 Dec 2020 10:42:05 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 458EC580387; Wed, 2 Dec 2020 10:40:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 02 Dec 2020 10:40:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=9Gmw2R9k0ECc5QddBoAVCGV1sXx zmzO4YbJmiIaU4YY=; b=XTaU5h2f3WAixKnXCS97j2KVWpPWFVh0YhT+m4Nj3CM d8fTiUZiwPxy0O5RDJhyFigFAz8sZz+tbotDWcC+lmTl53Ikj9hzxkoHOvZx4Hdg FHl+5ybpwHd/CInVL1bT07psyo33xntHw9gOTFFJX3XlcgTC7hIttoxNqcv+uUeo LZQPJSK/VNUNsS9C/ou1MotSZMMX0hGIUtSeitIqp/teQgRTE1jozqWsg2tNM+Vn USR1udlNMb86zaufmPt12VFdaaCvyfDp4yC4U8VFzxXM7WpMW7JKENwMOH/bGpX3 WtGeRMbpE+ekTaVlvtl49Bm8G884l6R2RuIACX1pO4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9Gmw2R 9k0ECc5QddBoAVCGV1sXxzmzO4YbJmiIaU4YY=; b=GObBsEcZzgssNLZ33qx0AJ GhlgBV+VE8PDXxHuIwxRZtWVbtBsMqOVYwL3HUiCeUs7vY8qYe7eEgG24NXTJrw5 eJgCZirNGC/0NxuBWDfYbSsxr1R9Xq00iLJEo3mFb51sjeL9PGDCc09ibc4NbLEd 0KooxPvuwHzHE0LxBpGNgx7SCw9X4xddpdRZbhog0DNe1o2WVVFV9AoU8bzzO1NL UW3xSz6z9XM5YMvkD0pfQlzsIhp4ctFCnj2JwxMvQpMw4wAqOGvL5a3BMOQT1teW JwGpgNnv8qyoHrp5w/jg0fLjmzY+6Be9L1HWOP9B78yeu9+bujjcrxCKZT4ofyvQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeigedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id D6D14108005B; Wed, 2 Dec 2020 10:40:54 -0500 (EST) Date: Wed, 2 Dec 2020 16:40:53 +0100 From: Maxime Ripard To: Paul Kocialkowski Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devel@driverdev.osuosl.org, linux-sunxi@googlegroups.com, Yong Deng , Mauro Carvalho Chehab , Rob Herring , Chen-Yu Tsai , Jernej Skrabec , Jonathan Corbet , Kishon Vijay Abraham I , Vinod Koul , Helen Koike , Dafna Hirschfeld , Greg Kroah-Hartman , Philipp Zabel , Sakari Ailus , Hans Verkuil , Thomas Petazzoni , kevin.lhopital@hotmail.com Subject: Re: [PATCH v2 07/19] media: sun6i-csi: Add support for MIPI CSI-2 bridge input Message-ID: <20201202154053.3fcxiift2uyqnjvp@gilmour> References: <20201128142839.517949-1-paul.kocialkowski@bootlin.com> <20201128142839.517949-8-paul.kocialkowski@bootlin.com> <20201201121241.cyafjhot45puusfc@gilmour> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="45hcbhhgcfnzxspi" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org --45hcbhhgcfnzxspi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 02, 2020 at 03:19:11PM +0100, Paul Kocialkowski wrote: > Hi, >=20 > On Tue 01 Dec 20, 13:12, Maxime Ripard wrote: > > Hi, > >=20 > > On Sat, Nov 28, 2020 at 03:28:27PM +0100, Paul Kocialkowski wrote: > > > The A31 CSI controller supports a MIPI CSI-2 bridge input, which has > > > its own dedicated port in the fwnode graph. > > >=20 > > > Support for this input is added with this change: > > > - two pads are defined for the media entity instead of one > > > and only one needs to be connected at a time; > > > - the pads currently match the fwnode graph representation; > > > - links are created between our pads and the subdevs for each > > > interface and are no longer immutable so that userspace can select > > > which interface to use in case both are bound to a subdev; > > > - fwnode endpoints are parsed and stored for each interface; > > > - the active subdev (and fwnode endpoint) is retrieved when validating > > > the media link at stream on time and cleared at stream off; > > > - an error is raised if both links are active at the same time; > > > - the MIPI interface bit is set if the MIPI CSI-2 bridge endpoint is > > > active. > > >=20 > > > In the future, the media entity representation might evolve to: > > > - distinguish the internal parallel bridge and data formatter; > > > - represent each of the 4 internal channels that can exist between > > > the parallel bridge (for BT656 time-multiplex) and MIPI CSI-2 > > > (internal channels can be mapped to virtual channels); > > > - connect the controller's output to the ISP instead of its > > > DMA engine. > > >=20 > > > Finally note that the MIPI CSI-2 bridges should not be linked in > > > the fwnode graph unless they have a sensor subdev attached. > >=20 > > I'll leave most of the review to Laurent and Sakari, but I'm not quite > > sure what you meant in the last paragraph. Did you mean that the > > MIPI-CSI controller in the Allwinner SoC should only be linked if it has > > a sensor attached, or did you mean that any MIPI-CSI2 bridge cannot be > > attached to the controller? >=20 > So the use of plural was a mistake and your first understanding is the co= rrect > one: if the bridge is linked to the CSI controller in the OF graph but the > bridge doesn't have a sensor attached, the CSI controller driver will fail > to probe, as far as I could see. I'm not sure it's reasonable to not link it in the DTSI then, we'll want to reduce as much the boilerplate from the board DTS as possible, and the MIPI-CSI controller is always there anyway. However, we should definitely have it disabled if there's no sensor, which should solve your probe issue Maxime --45hcbhhgcfnzxspi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX8e1hQAKCRDj7w1vZxhR xUmfAQDrnEGoBdbQg8pcpjrHuleZtMVcXIe+BVlxHlRQPOZFXwEAjruXhWd67Q5L aw25nh4z4WBzD8T8dUj7t5A/R28hows= =crGk -----END PGP SIGNATURE----- --45hcbhhgcfnzxspi--