From: Jonathan Corbet <corbet@lwn.net>
To: JaeSang Yoo <js.yoo.5b@gmail.com>
Cc: jsyoo5b@gmail.com, mchehab+huawei@kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.org,
markus.heiser@darmarit.de
Subject: Re: [PATCH] docs: update requirements to install six module
Date: Wed, 9 Dec 2020 17:29:03 -0700 [thread overview]
Message-ID: <20201209172903.7990f71b@lwn.net> (raw)
In-Reply-To: <20201208014628.GA1361@JSYoo5B-Base.localdomain>
On Tue, 8 Dec 2020 10:46:28 +0900
JaeSang Yoo <js.yoo.5b@gmail.com> wrote:
> On the update of Sphinx version to 2.4.4, the "six" library won't be
> installed automatically. (which is required by kfigure.py)
>
> Main reason of this issue were occurred by the requirements changed from
> the sphinx library. In Sphinx v1.7.9, six was listed on the
> install_requires, but it has been removed since 2.x
>
> The kfigure.py uses six library explicitly, adding six to
> requirements.txt seems reasonable
>
> Signed-off-by: JaeSang Yoo <jsyoo5b@gmail.com>
> ---
> Documentation/sphinx/requirements.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/sphinx/requirements.txt b/Documentation/sphinx/requirements.txt
> index 489f6626de67..5030d346d23b 100644
> --- a/Documentation/sphinx/requirements.txt
> +++ b/Documentation/sphinx/requirements.txt
> @@ -1,3 +1,4 @@
> docutils
> Sphinx==2.4.4
> sphinx_rtd_theme
> +six
Sigh...what we really need to do is to leave Python 2 behind. Until then,
though, we need to install "six". Patch applied, thanks.
jon
next prev parent reply other threads:[~2020-12-10 0:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 1:46 [PATCH] docs: update requirements to install six module JaeSang Yoo
2020-12-08 6:28 ` Mauro Carvalho Chehab
2020-12-10 0:29 ` Jonathan Corbet [this message]
2020-12-10 3:39 ` JaeSang Yoo
2020-12-10 23:02 ` Jonathan Corbet
2020-12-11 1:15 ` JaeSang Yoo
2020-12-11 20:55 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209172903.7990f71b@lwn.net \
--to=corbet@lwn.net \
--cc=js.yoo.5b@gmail.com \
--cc=jsyoo5b@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.org \
--cc=markus.heiser@darmarit.de \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).