linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [lwn:docs-next 127/127] drivers/scsi/fnic/fnic_fcs.c:299: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
@ 2021-04-16  2:54 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-04-16  2:54 UTC (permalink / raw)
  To: Aditya Srivastava
  Cc: kbuild-all, clang-built-linux, linux-doc, Jonathan Corbet

[-- Attachment #1: Type: text/plain, Size: 6580 bytes --]

tree:   git://git.lwn.net/linux-2.6 docs-next
head:   f9bbc12ccb35ac8b3fa01cec1a19cb523a7707c7
commit: f9bbc12ccb35ac8b3fa01cec1a19cb523a7707c7 [127/127] scripts: kernel-doc: improve parsing for kernel-doc comments syntax
config: x86_64-randconfig-a015-20210415 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6a18cc23efad410db48a3ccfc233d215de7d4cb9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        git remote add lwn git://git.lwn.net/linux-2.6
        git fetch --no-tags lwn docs-next
        git checkout f9bbc12ccb35ac8b3fa01cec1a19cb523a7707c7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/fnic/fnic_fcs.c:299: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Check if the Received FIP FLOGI frame is rejected


vim +299 drivers/scsi/fnic/fnic_fcs.c

d3c995f1dcf938 Hiral Patel 2013-02-25  297  
d3c995f1dcf938 Hiral Patel 2013-02-25  298  /**
d3c995f1dcf938 Hiral Patel 2013-02-25 @299   * Check if the Received FIP FLOGI frame is rejected
d3c995f1dcf938 Hiral Patel 2013-02-25  300   * @fip: The FCoE controller that received the frame
d3c995f1dcf938 Hiral Patel 2013-02-25  301   * @skb: The received FIP frame
d3c995f1dcf938 Hiral Patel 2013-02-25  302   *
d3c995f1dcf938 Hiral Patel 2013-02-25  303   * Returns non-zero if the frame is rejected with unsupported cmd with
d3c995f1dcf938 Hiral Patel 2013-02-25  304   * insufficient resource els explanation.
d3c995f1dcf938 Hiral Patel 2013-02-25  305   */
d3c995f1dcf938 Hiral Patel 2013-02-25  306  static inline int is_fnic_fip_flogi_reject(struct fcoe_ctlr *fip,
d3c995f1dcf938 Hiral Patel 2013-02-25  307  					 struct sk_buff *skb)
d3c995f1dcf938 Hiral Patel 2013-02-25  308  {
d3c995f1dcf938 Hiral Patel 2013-02-25  309  	struct fc_lport *lport = fip->lp;
d3c995f1dcf938 Hiral Patel 2013-02-25  310  	struct fip_header *fiph;
d3c995f1dcf938 Hiral Patel 2013-02-25  311  	struct fc_frame_header *fh = NULL;
d3c995f1dcf938 Hiral Patel 2013-02-25  312  	struct fip_desc *desc;
d3c995f1dcf938 Hiral Patel 2013-02-25  313  	struct fip_encaps *els;
d3c995f1dcf938 Hiral Patel 2013-02-25  314  	u16 op;
d3c995f1dcf938 Hiral Patel 2013-02-25  315  	u8 els_op;
d3c995f1dcf938 Hiral Patel 2013-02-25  316  	u8 sub;
d3c995f1dcf938 Hiral Patel 2013-02-25  317  
d3c995f1dcf938 Hiral Patel 2013-02-25  318  	size_t rlen;
d3c995f1dcf938 Hiral Patel 2013-02-25  319  	size_t dlen = 0;
d3c995f1dcf938 Hiral Patel 2013-02-25  320  
d3c995f1dcf938 Hiral Patel 2013-02-25  321  	if (skb_linearize(skb))
d3c995f1dcf938 Hiral Patel 2013-02-25  322  		return 0;
d3c995f1dcf938 Hiral Patel 2013-02-25  323  
d3c995f1dcf938 Hiral Patel 2013-02-25  324  	if (skb->len < sizeof(*fiph))
d3c995f1dcf938 Hiral Patel 2013-02-25  325  		return 0;
d3c995f1dcf938 Hiral Patel 2013-02-25  326  
d3c995f1dcf938 Hiral Patel 2013-02-25  327  	fiph = (struct fip_header *)skb->data;
d3c995f1dcf938 Hiral Patel 2013-02-25  328  	op = ntohs(fiph->fip_op);
d3c995f1dcf938 Hiral Patel 2013-02-25  329  	sub = fiph->fip_subcode;
d3c995f1dcf938 Hiral Patel 2013-02-25  330  
d3c995f1dcf938 Hiral Patel 2013-02-25  331  	if (op != FIP_OP_LS)
d3c995f1dcf938 Hiral Patel 2013-02-25  332  		return 0;
d3c995f1dcf938 Hiral Patel 2013-02-25  333  
d3c995f1dcf938 Hiral Patel 2013-02-25  334  	if (sub != FIP_SC_REP)
d3c995f1dcf938 Hiral Patel 2013-02-25  335  		return 0;
d3c995f1dcf938 Hiral Patel 2013-02-25  336  
d3c995f1dcf938 Hiral Patel 2013-02-25  337  	rlen = ntohs(fiph->fip_dl_len) * 4;
d3c995f1dcf938 Hiral Patel 2013-02-25  338  	if (rlen + sizeof(*fiph) > skb->len)
d3c995f1dcf938 Hiral Patel 2013-02-25  339  		return 0;
d3c995f1dcf938 Hiral Patel 2013-02-25  340  
d3c995f1dcf938 Hiral Patel 2013-02-25  341  	desc = (struct fip_desc *)(fiph + 1);
d3c995f1dcf938 Hiral Patel 2013-02-25  342  	dlen = desc->fip_dlen * FIP_BPW;
d3c995f1dcf938 Hiral Patel 2013-02-25  343  
d3c995f1dcf938 Hiral Patel 2013-02-25  344  	if (desc->fip_dtype == FIP_DT_FLOGI) {
d3c995f1dcf938 Hiral Patel 2013-02-25  345  
d3c995f1dcf938 Hiral Patel 2013-02-25  346  		if (dlen < sizeof(*els) + sizeof(*fh) + 1)
d3c995f1dcf938 Hiral Patel 2013-02-25  347  			return 0;
d3c995f1dcf938 Hiral Patel 2013-02-25  348  
d3c995f1dcf938 Hiral Patel 2013-02-25  349  		els = (struct fip_encaps *)desc;
d3c995f1dcf938 Hiral Patel 2013-02-25  350  		fh = (struct fc_frame_header *)(els + 1);
d3c995f1dcf938 Hiral Patel 2013-02-25  351  
d3c995f1dcf938 Hiral Patel 2013-02-25  352  		if (!fh)
d3c995f1dcf938 Hiral Patel 2013-02-25  353  			return 0;
d3c995f1dcf938 Hiral Patel 2013-02-25  354  
d3c995f1dcf938 Hiral Patel 2013-02-25  355  		/*
d3c995f1dcf938 Hiral Patel 2013-02-25  356  		 * ELS command code, reason and explanation should be = Reject,
d3c995f1dcf938 Hiral Patel 2013-02-25  357  		 * unsupported command and insufficient resource
d3c995f1dcf938 Hiral Patel 2013-02-25  358  		 */
d3c995f1dcf938 Hiral Patel 2013-02-25  359  		els_op = *(u8 *)(fh + 1);
d3c995f1dcf938 Hiral Patel 2013-02-25  360  		if (els_op == ELS_LS_RJT) {
d3c995f1dcf938 Hiral Patel 2013-02-25  361  			shost_printk(KERN_INFO, lport->host,
d3c995f1dcf938 Hiral Patel 2013-02-25  362  				  "Flogi Request Rejected by Switch\n");
d3c995f1dcf938 Hiral Patel 2013-02-25  363  			return 1;
d3c995f1dcf938 Hiral Patel 2013-02-25  364  		}
d3c995f1dcf938 Hiral Patel 2013-02-25  365  		shost_printk(KERN_INFO, lport->host,
d3c995f1dcf938 Hiral Patel 2013-02-25  366  				"Flogi Request Accepted by Switch\n");
d3c995f1dcf938 Hiral Patel 2013-02-25  367  	}
d3c995f1dcf938 Hiral Patel 2013-02-25  368  	return 0;
d3c995f1dcf938 Hiral Patel 2013-02-25  369  }
d3c995f1dcf938 Hiral Patel 2013-02-25  370  

:::::: The code at line 299 was first introduced by commit
:::::: d3c995f1dcf938f1084388d92b8fb97bec366566 [SCSI] fnic: FIP VLAN Discovery Feature Support

:::::: TO: Hiral Patel <hiralpat@cisco.com>
:::::: CC: James Bottomley <JBottomley@Parallels.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36363 bytes --]

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2021-04-16  2:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16  2:54 [lwn:docs-next 127/127] drivers/scsi/fnic/fnic_fcs.c:299: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).