linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: admin-guide: update description for kernel.hotplug sysctl
@ 2021-04-20 12:06 Rasmus Villemoes
  2021-05-06 13:06 ` Rasmus Villemoes
  2021-05-13 15:23 ` Jonathan Corbet
  0 siblings, 2 replies; 3+ messages in thread
From: Rasmus Villemoes @ 2021-04-20 12:06 UTC (permalink / raw)
  To: Jonathan Corbet, Kay Sievers, Greg Kroah-Hartman
  Cc: Rasmus Villemoes, linux-doc, linux-kernel

It's been a few releases since this defaulted to /sbin/hotplug. Update
the text, and include pointers to the two CONFIG_UEVENT_HELPER{,_PATH}
config knobs whose help text could provide more info, but also hint
that the user probably doesn't need to care at all.

Fixes: 7934779a69f1 ("Driver-Core: disable /sbin/hotplug by default")
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 Documentation/admin-guide/sysctl/kernel.rst | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
index 1d56a6b73a4e..c24f57f2c782 100644
--- a/Documentation/admin-guide/sysctl/kernel.rst
+++ b/Documentation/admin-guide/sysctl/kernel.rst
@@ -333,7 +333,12 @@ hotplug
 =======
 
 Path for the hotplug policy agent.
-Default value is "``/sbin/hotplug``".
+Default value is ``CONFIG_UEVENT_HELPER_PATH``, which in turn defaults
+to the empty string.
+
+This file only exists when ``CONFIG_UEVENT_HELPER`` is enabled. Most
+modern systems rely exclusively on the netlink-based uevent source and
+don't need this.
 
 
 hung_task_all_cpu_backtrace
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: admin-guide: update description for kernel.hotplug sysctl
  2021-04-20 12:06 [PATCH] docs: admin-guide: update description for kernel.hotplug sysctl Rasmus Villemoes
@ 2021-05-06 13:06 ` Rasmus Villemoes
  2021-05-13 15:23 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Rasmus Villemoes @ 2021-05-06 13:06 UTC (permalink / raw)
  To: Jonathan Corbet, Kay Sievers, Greg Kroah-Hartman; +Cc: linux-doc, linux-kernel

On 20/04/2021 14.06, Rasmus Villemoes wrote:
> It's been a few releases since this defaulted to /sbin/hotplug. Update
> the text, and include pointers to the two CONFIG_UEVENT_HELPER{,_PATH}
> config knobs whose help text could provide more info, but also hint
> that the user probably doesn't need to care at all.
> 
> Fixes: 7934779a69f1 ("Driver-Core: disable /sbin/hotplug by default")
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Ping.

> ---
>  Documentation/admin-guide/sysctl/kernel.rst | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
> index 1d56a6b73a4e..c24f57f2c782 100644
> --- a/Documentation/admin-guide/sysctl/kernel.rst
> +++ b/Documentation/admin-guide/sysctl/kernel.rst
> @@ -333,7 +333,12 @@ hotplug
>  =======
>  
>  Path for the hotplug policy agent.
> -Default value is "``/sbin/hotplug``".
> +Default value is ``CONFIG_UEVENT_HELPER_PATH``, which in turn defaults
> +to the empty string.
> +
> +This file only exists when ``CONFIG_UEVENT_HELPER`` is enabled. Most
> +modern systems rely exclusively on the netlink-based uevent source and
> +don't need this.
>  
>  
>  hung_task_all_cpu_backtrace
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: admin-guide: update description for kernel.hotplug sysctl
  2021-04-20 12:06 [PATCH] docs: admin-guide: update description for kernel.hotplug sysctl Rasmus Villemoes
  2021-05-06 13:06 ` Rasmus Villemoes
@ 2021-05-13 15:23 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2021-05-13 15:23 UTC (permalink / raw)
  To: Rasmus Villemoes, Kay Sievers, Greg Kroah-Hartman
  Cc: Rasmus Villemoes, linux-doc, linux-kernel

Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:

> It's been a few releases since this defaulted to /sbin/hotplug. Update
> the text, and include pointers to the two CONFIG_UEVENT_HELPER{,_PATH}
> config knobs whose help text could provide more info, but also hint
> that the user probably doesn't need to care at all.
>
> Fixes: 7934779a69f1 ("Driver-Core: disable /sbin/hotplug by default")
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>  Documentation/admin-guide/sysctl/kernel.rst | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
> index 1d56a6b73a4e..c24f57f2c782 100644
> --- a/Documentation/admin-guide/sysctl/kernel.rst
> +++ b/Documentation/admin-guide/sysctl/kernel.rst
> @@ -333,7 +333,12 @@ hotplug
>  =======
>  
>  Path for the hotplug policy agent.
> -Default value is "``/sbin/hotplug``".
> +Default value is ``CONFIG_UEVENT_HELPER_PATH``, which in turn defaults
> +to the empty string.
> +
> +This file only exists when ``CONFIG_UEVENT_HELPER`` is enabled. Most
> +modern systems rely exclusively on the netlink-based uevent source and
> +don't need this.

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-13 15:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 12:06 [PATCH] docs: admin-guide: update description for kernel.hotplug sysctl Rasmus Villemoes
2021-05-06 13:06 ` Rasmus Villemoes
2021-05-13 15:23 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).