linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Beata Michalska <beata.michalska@arm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@redhat.com, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, valentin.schneider@arm.com,
	dietmar.eggemann@arm.com, corbet@lwn.net,
	linux-doc@vger.kernel.org
Subject: Re: [RFC PATCH v2 3/3] sched/doc: Update the CPU capacity asymmetry bits
Date: Mon, 10 May 2021 17:33:29 +0100	[thread overview]
Message-ID: <20210510163329.GA8567@e120325.cambridge.arm.com> (raw)
In-Reply-To: <79223641-6b3e-6b48-50df-3a9c73c003cd@infradead.org>

On Wed, Apr 28, 2021 at 10:19:10AM -0700, Randy Dunlap wrote:
> On 4/28/21 2:32 AM, Beata Michalska wrote:
> > Update the documentation bits referring to capacity aware scheduling
> > with regards to newly introduced SD_ASYM_CPUCAPACITY_FULL shed_domain
> 
>                                                             sched_domain
> I guess.
> 
> > flag.
> > 
> > Signed-off-by: Beata Michalska <beata.michalska@arm.com>
> > ---
> >  Documentation/scheduler/sched-capacity.rst | 6 ++++--
> >  Documentation/scheduler/sched-energy.rst   | 2 +-
> >  2 files changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/scheduler/sched-capacity.rst b/Documentation/scheduler/sched-capacity.rst
> > index 9b7cbe4..92d16e7 100644
> > --- a/Documentation/scheduler/sched-capacity.rst
> > +++ b/Documentation/scheduler/sched-capacity.rst
> > @@ -284,8 +284,10 @@ whether the system exhibits asymmetric CPU capacities. Should that be the
> >  case:
> >  
> >  - The sched_asym_cpucapacity static key will be enabled.
> > -- The SD_ASYM_CPUCAPACITY flag will be set at the lowest sched_domain level that
> > -  spans all unique CPU capacity values.
> > +- The SD_ASYM_CPUCAPACITY_FULL flag will be set at the lowest sched_domain
> > +  level that spans all unique CPU capacity values.
> > +- The SD_ASYM_CPUCAPACITY flag will be set for any sched_domain that spans
> > +  cpus with any range of asymmetry.
> 
>      CPUs
> please.
> 
> >  
> >  The sched_asym_cpucapacity static key is intended to guard sections of code that
> >  cater to asymmetric CPU capacity systems. Do note however that said key is
> > diff --git a/Documentation/scheduler/sched-energy.rst b/Documentation/scheduler/sched-energy.rst
> > index afe02d3..8fbce5e 100644
> > --- a/Documentation/scheduler/sched-energy.rst
> > +++ b/Documentation/scheduler/sched-energy.rst
> > @@ -328,7 +328,7 @@ section lists these dependencies and provides hints as to how they can be met.
> >  
> >  As mentioned in the introduction, EAS is only supported on platforms with
> >  asymmetric CPU topologies for now. This requirement is checked at run-time by
> > -looking for the presence of the SD_ASYM_CPUCAPACITY flag when the scheduling
> > +looking for the presence of the SD_ASYM_CPUCAPACITY_FULL flag when the scheduling
> >  domains are built.
> >  
> >  See Documentation/scheduler/sched-capacity.rst for requirements to be met for this
> > 
>

Thank you for having a look!
Fixes applied to v3.

---
BR
B.

> thanks.
> -- 
> ~Randy
> 

  reply	other threads:[~2021-05-10 16:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  9:32 [RFC PATCH v2 0/3] Rework CPU capacity asymmetry detection Beata Michalska
2021-04-28  9:32 ` [RFC PATCH v2 1/3] sched/core: Introduce SD_ASYM_CPUCAPACITY_FULL sched_domain flag Beata Michalska
2021-04-28  9:32 ` [RFC PATCH v2 2/3] sched/topology: Rework CPU capacity asymmetry detection Beata Michalska
2021-05-05 18:17   ` Valentin Schneider
2021-04-28  9:32 ` [RFC PATCH v2 3/3] sched/doc: Update the CPU capacity asymmetry bits Beata Michalska
2021-04-28 17:19   ` Randy Dunlap
2021-05-10 16:33     ` Beata Michalska [this message]
2021-05-05 18:17 ` [RFC PATCH v2 0/3] Rework CPU capacity asymmetry detection Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210510163329.GA8567@e120325.cambridge.arm.com \
    --to=beata.michalska@arm.com \
    --cc=corbet@lwn.net \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    --subject='Re: [RFC PATCH v2 3/3] sched/doc: Update the CPU capacity asymmetry bits' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).