From: Guenter Roeck <linux@roeck-us.net>
To: Erik Rosen <erik.rosen@metormote.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] hwmon: (pmbus) Add support for additional Flex BMR converters to the pmbus driver
Date: Mon, 10 May 2021 09:38:25 -0700 [thread overview]
Message-ID: <20210510163825.GA838760@roeck-us.net> (raw)
In-Reply-To: <20210507194023.61138-1-erik.rosen@metormote.com>
On Fri, May 07, 2021 at 09:40:20PM +0200, Erik Rosen wrote:
> Some Flex pmbus converters (BMR310, BMR458, BMR80, BMR490 and BMR491)
> end up in an undefined state when trying to read a register that does
> not exist in the chip. This causes the following chip access to also
> fail even if it is a valid register read or write. This will mess up the
> pmbus driver auto-detection process.
>
> One way to reset the pmbus state machine to a known state is to read
> a register that is known to exist. This read will fail but will also
> reset the chip into a known state.
>
> For such chips we suggest adding a new pmbus flag:
> PMBUS_READ_STATUS_AFTER_FAILED_CHECK
> By setting this flag the driver will try to read the STATUS register
> after each failed register check. This read may fail, but it will put
> the chip into a known state so that the auto-detection process can
> proceed correctly.
>
> Add support for Flex BMR310, BMR456, BMR457, BMR458, BMR480, BMR490,
> BMR491 and BMR492 to the pmbus driver
>
> This patch has been tested with Flex BMR310, BMR456, BMR457, BMR458,
> BMR480, BMR490, BMR491 and BMR492 converter modules
>
> v2
> -Copy all flags to pmbus_platform_data struct instead of one by one
> -Fix code formatting in pmbus_core documentation
> -Add documentation for flag NO_CAPABILITY
> -Fix sorting of chip names and prefix in pmbus documentation
>
Series applied, with minor whitespace fixes in documentation.
Guenter
prev parent reply other threads:[~2021-05-10 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 19:40 [PATCH v2 0/3] hwmon: (pmbus) Add support for additional Flex BMR converters to the pmbus driver Erik Rosen
2021-05-07 19:40 ` [PATCH v2 1/3] hwmon: (pmbus) Add new flag PMBUS_READ_STATUS_AFTER_FAILED_CHECK Erik Rosen
2021-05-07 19:40 ` [PATCH v2 2/3] hwmon: (pmbus) Add documentation for new flags Erik Rosen
2021-05-07 19:40 ` [PATCH v2 3/3] hwmon: (pmbus) Add support for additional Flex BMR converters to pmbus Erik Rosen
2021-05-10 16:38 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510163825.GA838760@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=erik.rosen@metormote.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).