From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47ECFC433ED for ; Thu, 13 May 2021 09:31:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2637A61438 for ; Thu, 13 May 2021 09:31:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231954AbhEMJcr (ORCPT ); Thu, 13 May 2021 05:32:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232617AbhEMJco (ORCPT ); Thu, 13 May 2021 05:32:44 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E62DC061761 for ; Thu, 13 May 2021 02:31:34 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id m9so26280485wrx.3 for ; Thu, 13 May 2021 02:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=K2KX3N3qEtXhLRhml3Iacue6w4dhQzMo6cc0mTtnvQM=; b=r0pHg9wLk+EkYR5JCrgzCwvxfLOJCEKZ7rlImrKtZJl/RFxusIlb/dHrHqumPtHekw TuV6M6W+5C+88MZcMWoYC03FLTQRmP+HZMlOaDrQZ05FPxs039l9uS8pmlV0dKcHMLz5 CUqwLbiwuftKZoH8oiGOepbGAFDSG4Xu5+/lPafGcdhEnhzFZdCxQq3GbaAARfd4JsuT kHeqskEgSV555dWibYEfk/fmA7mMm6ZrQ1QRkSy9E8MD6r3u6nR2yInb8/OXA+SqhpjS pZLrEoh296DZ+mareJMyQNItfC2RAfn4QvCt91FAO4gpzmeg8UIwAnQk+eaJMz+vsqlG BA4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=K2KX3N3qEtXhLRhml3Iacue6w4dhQzMo6cc0mTtnvQM=; b=eU1+0Xk/R6IWmGjNzVv893J3uJB4mYIB3oceHQDv07r2/HW1Y3otzpQlsOWo0L6Jij 1jVNk2rXOWUqjY3wn9FfWu0zcqeXezfS5sa9epT88PVoQmza/Ru9mA7+DKtAHrnFQuUO PREDOQwkaPCPJBd3IUhGU7moLk66nRfUoodYa2I2Gj9sdfhD9vK3UmD+plNRI8yFYcfU diGX0OZoQCVqJKEcFmxvklQ1EIW3HlWanH+BaYYQKBuhOJKa41SmG+w5C0bP00wy3Dyv eJdNDPtKLfYuLfYfwV7LPDG/QX5k+M7SFg3+Rti94LSvcXq9HiP/DdsXlZUDMmpDv9Lq jzyw== X-Gm-Message-State: AOAM530jm+cs2KWPsxukx98sRoAH4tyL15vReJSafyVj1tnNOB03Lho4 WWsMyIL5OsfeJi1yGxXouUEdYA== X-Google-Smtp-Source: ABdhPJwmID9w2Hp1ruXNrBudSly/39AHF+tVW4EuRSQip8bKri1BbA6tswXSbk2m1ujO+jkvowzwUw== X-Received: by 2002:a05:6000:2cf:: with SMTP id o15mr15604521wry.243.1620898293114; Thu, 13 May 2021 02:31:33 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id f3sm2252580wrp.7.2021.05.13.02.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 02:31:32 -0700 (PDT) Date: Thu, 13 May 2021 10:31:30 +0100 From: Daniel Thompson To: Andy Shevchenko Cc: Petr Mladek , JC Kuo , Joe Perches , Sumit Garg , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-nilfs@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Jonathan Corbet , Mathias Nyman , Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter , Ryusuke Konishi , Jason Wessel , Douglas Anderson Subject: Re: [PATCH v2 2/4] kdb: Switch to use %ptTs Message-ID: <20210513093130.qzbh6tm7lbclgayh@maple.lan> References: <20210511153958.34527-1-andriy.shevchenko@linux.intel.com> <20210511153958.34527-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511153958.34527-2-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, May 11, 2021 at 06:39:56PM +0300, Andy Shevchenko wrote: > Use %ptTs instead of open-coded variant to print contents > of time64_t type in human readable form. > > Cc: Jason Wessel > Cc: Daniel Thompson > Cc: kgdb-bugreport@lists.sourceforge.net > Signed-off-by: Andy Shevchenko > Reviewed-by: Petr Mladek > Reviewed-by: Douglas Anderson Reviewed-by: Daniel Thompson Any clue what route this will take into the kernel? I'm certainly happy for someone else to take the kdb bits alongside the vsprintf stuff (so here's an acked-by too in case they are fussy about that sort of thing ;-) ): Acked-by: Daniel Thompson Daniel. > --- > v2: collected tags > kernel/debug/kdb/kdb_main.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c > index 1baa96a2ecb8..622410c45da1 100644 > --- a/kernel/debug/kdb/kdb_main.c > +++ b/kernel/debug/kdb/kdb_main.c > @@ -2488,7 +2488,6 @@ static void kdb_sysinfo(struct sysinfo *val) > static int kdb_summary(int argc, const char **argv) > { > time64_t now; > - struct tm tm; > struct sysinfo val; > > if (argc) > @@ -2502,13 +2501,7 @@ static int kdb_summary(int argc, const char **argv) > kdb_printf("domainname %s\n", init_uts_ns.name.domainname); > > now = __ktime_get_real_seconds(); > - time64_to_tm(now, 0, &tm); > - kdb_printf("date %04ld-%02d-%02d %02d:%02d:%02d " > - "tz_minuteswest %d\n", > - 1900+tm.tm_year, tm.tm_mon+1, tm.tm_mday, > - tm.tm_hour, tm.tm_min, tm.tm_sec, > - sys_tz.tz_minuteswest); > - > + kdb_printf("date %ptTs tz_minuteswest %d\n", &now, sys_tz.tz_minuteswest); > kdb_sysinfo(&val); > kdb_printf("uptime "); > if (val.uptime > (24*60*60)) { > -- > 2.30.2 >