From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46FFAC47092 for ; Tue, 1 Jun 2021 19:13:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D08060FEE for ; Tue, 1 Jun 2021 19:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234671AbhFATPH (ORCPT ); Tue, 1 Jun 2021 15:15:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233853AbhFATPG (ORCPT ); Tue, 1 Jun 2021 15:15:06 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7A28C061574 for ; Tue, 1 Jun 2021 12:13:23 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id g18so275751pfr.2 for ; Tue, 01 Jun 2021 12:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F2nIYNp74XkoIbaKwSbgXhOoOC//P+XAXbK1h22Ceac=; b=lkbfMl1Gmq+Nf/7ubjo1OqC7uT9K9Mr6mhUY2FEZSmrJPHAB0auG9k9uCBtbvFW7E+ f0Q4vvjVo8XzLVCG/jM1Z4nwD1CiBbxVqshZ7h96EbGppBXf8gK9pANmLngrz86A9IVM wK3esYJdGgKwBvpr7YAwjV41Fe0DLQWWzprys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F2nIYNp74XkoIbaKwSbgXhOoOC//P+XAXbK1h22Ceac=; b=X/lMS6Y+xlpX+AeGID3B1di+IcZU+gLtMz5+Kz6nZknaogYK3sdabjAhAWrSyoU5OM n+hBDK0Wfb981oOdYl0rfapGcJGOjTESZhfJJiD5wy+l50tKV3GpL4jpbn689bX2bsQ3 6NYH0Ozl9YCT+imIOUsHoJEfAEMLxl2fYCQ0N3SyAz6Cq8hQB1YmaukzihWYwewaUvbE 56yrOsJLFgcVwvoFyebGvTtoLV6NCFI/jQ0MKaljEayWeQS7Uu1+ifTW1ZoJ6OH1oCP5 ariwVmgHNd6+u5Le1vU899qDad6wPeMddmK17NQIuxbPxcbssrghfJ1/VE643l291AP9 Ditg== X-Gm-Message-State: AOAM532RFgWv0mO5fCm+H1JkyZQDZHAQVUKwNFWvC7ImNj6u7a+covKw N6tV5iklZjUpSNUrUUTdxkFtEA== X-Google-Smtp-Source: ABdhPJz37ayunvn9ok1+ENdFPwZxrGi7OsloH6vD2nAp9cdyVRqX1z2+Tmk0IHTTo9v7cTVgjj829w== X-Received: by 2002:a05:6a00:14cb:b029:2be:1466:5a28 with SMTP id w11-20020a056a0014cbb02902be14665a28mr23125434pfu.55.1622574803092; Tue, 01 Jun 2021 12:13:23 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u18sm5029856pfl.9.2021.06.01.12.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 12:13:22 -0700 (PDT) Date: Tue, 1 Jun 2021 12:13:21 -0700 From: Kees Cook To: Bill Wendling Cc: Nathan Chancellor , Jonathan Corbet , Masahiro Yamada , Linux Doc Mailing List , LKML , Linux Kbuild mailing list , clang-built-linux , Andrew Morton , Nick Desaulniers , Jarmo Tiitto Subject: Re: [PATCH] pgo: rename the raw profile file to vmlinux.profraw Message-ID: <202106011210.B5A8881214@keescook> References: <20210531202044.426578-1-morbo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Jun 01, 2021 at 01:24:39AM -0700, 'Bill Wendling' via Clang Built Linux wrote: > On Mon, May 31, 2021 at 1:29 PM Nathan Chancellor wrote: > > > > On 5/31/2021 1:20 PM, Bill Wendling wrote: > > > Future PGO features may create other files in /sys/kernel/debug/pgo. So > > > rename the kernel's raw profile data file to "vmlinux.profraw" to make > > > which part of the kernel the file is for more explicit. > > > > > > Note that future files in /sys/kernel/debug/pgo should follow a similar > > > naming convention. > > > > > > Signed-off-by: Bill Wendling > > > > Guess this clears up my confusion around the module patches :) > > > To clarify, Jarmo did those patches on his own. I just wanted to > clarify the naming convention. :-) Is the expectation that there would be 1 file per module in /sys/kernel/debug/pgo/ after the modules patch? > > -bw > > > Reviewed-by: Nathan Chancellor > > > > > --- > > > Documentation/dev-tools/pgo.rst | 6 +++--- > > > kernel/pgo/Kconfig | 7 ++++--- > > > kernel/pgo/fs.c | 2 +- > > > 3 files changed, 8 insertions(+), 7 deletions(-) > > > > > > diff --git a/Documentation/dev-tools/pgo.rst b/Documentation/dev-tools/pgo.rst > > > index b7f11d8405b7..0200449c4843 100644 > > > --- a/Documentation/dev-tools/pgo.rst > > > +++ b/Documentation/dev-tools/pgo.rst > > > @@ -76,7 +76,7 @@ The PGO kernel support creates the following files in debugfs: > > > ``/sys/kernel/debug/pgo/reset`` > > > Global reset file: resets all coverage data to zero when written to. > > > > > > -``/sys/kernel/debug/profraw`` > > > +``/sys/kernel/debug/pgo/vmlinux.profraw`` > > > The raw PGO data that must be processed with ``llvm_profdata``. > > > > > > > > > @@ -108,7 +108,7 @@ using the result to optimize the kernel: > > > > > > .. code-block:: sh > > > > > > - $ cp -a /sys/kernel/debug/pgo/profraw /tmp/vmlinux.profraw > > > + $ cp -a /sys/kernel/debug/pgo/vmlinux.profraw /tmp/vmlinux.profraw And if so, these instructions would change (in the future) to something like: $ cp -a /sys/kernel/debug/pgo/*.profraw /tmp/prof/ ? -Kees -- Kees Cook