From: Guenter Roeck <linux@roeck-us.net>
To: Erik Rosen <erik.rosen@metormote.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Daniel Nilsson <daniel.nilsson@flex.com>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/5] hwmon: (pmbus/pim4328) Add new pmbus flag NO_WRITE_PROTECT
Date: Wed, 2 Jun 2021 05:12:48 -0700 [thread overview]
Message-ID: <20210602121248.GB2901466@roeck-us.net> (raw)
In-Reply-To: <20210601164320.2907-2-erik.rosen@metormote.com>
On Tue, Jun 01, 2021 at 06:43:16PM +0200, Erik Rosen wrote:
> Some PMBus chips respond with invalid data when reading the WRITE_PROTECT
> register. For such chips, this flag should be set so that the PMBus core
> driver doesn't use the WRITE_PROTECT command to determine it's behavior.
>
> Signed-off-by: Erik Rosen <erik.rosen@metormote.com>
Couple of nits, otherwise, for my reference,
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/pmbus/pmbus_core.c | 9 ++++++---
> include/linux/pmbus.h | 9 +++++++++
> 2 files changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index bbd745178147..cb885efc4fba 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -2226,9 +2226,12 @@ static int pmbus_init_common(struct i2c_client *client, struct pmbus_data *data,
> * faults, and we should not try it. Also, in that case, writes into
> * limit registers need to be disabled.
> */
> - ret = i2c_smbus_read_byte_data(client, PMBUS_WRITE_PROTECT);
> - if (ret > 0 && (ret & PB_WP_ANY))
> - data->flags |= PMBUS_WRITE_PROTECTED | PMBUS_SKIP_STATUS_CHECK;
> + if (!(data->flags & PMBUS_NO_WRITE_PROTECT)) {
> + ret = i2c_smbus_read_byte_data(client, PMBUS_WRITE_PROTECT);
> + if (ret > 0 && (ret & PB_WP_ANY))
> + data->flags |= PMBUS_WRITE_PROTECTED
> + | PMBUS_SKIP_STATUS_CHECK;
Line length limit is now 100 columns, thus the line split above is not needed.
> + }
>
> if (data->info->pages)
> pmbus_clear_faults(client);
> diff --git a/include/linux/pmbus.h b/include/linux/pmbus.h
> index 12cbbf305969..f720470b1bab 100644
> --- a/include/linux/pmbus.h
> +++ b/include/linux/pmbus.h
> @@ -43,6 +43,15 @@
> */
> #define PMBUS_NO_CAPABILITY BIT(2)
>
> +/*
> + * PMBUS_NO_WRITE_PROTECT
> + *
> + * Some PMBus chips respond with invalid data when reading the WRITE_PROTECT
> + * register. For such chips, this flag should be set so that the PMBus core
> + * driver doesn't use the WRITE_PROTECT command to determine it's behavior.
its
> + */
> +#define PMBUS_NO_WRITE_PROTECT BIT(4)
> +
> struct pmbus_platform_data {
> u32 flags; /* Device specific flags */
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-06-02 12:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 16:43 [PATCH v4 0/6] hwmon: (pmbus/pim4328) Add pim4328 PMBus driver Erik Rosen
2021-06-01 16:43 ` [PATCH v4 1/5] hwmon: (pmbus/pim4328) Add new pmbus flag NO_WRITE_PROTECT Erik Rosen
2021-06-02 12:12 ` Guenter Roeck [this message]
2021-06-01 16:43 ` [PATCH v4 2/5] hwmon: (pmbus/pim4328) Add support for reading direct mode coefficients Erik Rosen
2021-06-02 12:15 ` Guenter Roeck
2021-06-01 16:43 ` [PATCH v4 3/5] hwmon: (pmbus/pim4328) Allow phase function even if it's not on page Erik Rosen
2021-06-02 12:10 ` Guenter Roeck
2021-06-01 16:43 ` [PATCH v4 4/5] hwmon: (pmbus/pim4328) Add PMBus driver for PIM4006, PIM4328 and PIM4820 Erik Rosen
2021-06-02 12:16 ` Guenter Roeck
2021-06-01 16:43 ` [PATCH v4 5/5] hwmon: (pmbus/pim4328) Add documentation for the pim4328 PMBus driver Erik Rosen
2021-06-02 8:51 ` Daniel Nilsson
2021-06-02 10:56 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602121248.GB2901466@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=daniel.nilsson@flex.com \
--cc=erik.rosen@metormote.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).