[PATCH] documentation-file-ref-check: Make git check work for multiple working directories

[PATCH] documentation-file-ref-check: Make git check work for multiple working directories

[Rob Herring]

With multiple git working directories, '.git' may also be a text file
linking to the actual git tree instead of a directory.

Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 scripts/documentation-file-ref-check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/documentation-file-ref-check b/scripts/documentation-file-ref-check
index c71832b2312b..7187ea5e5149 100755
--- a/scripts/documentation-file-ref-check
+++ b/scripts/documentation-file-ref-check
@@ -24,7 +24,7 @@ my $help = 0;
 my $fix = 0;
 my $warn = 0;
 
-if (! -d ".git") {
+if (! -e ".git") {
 	printf "Warning: can't check if file exists, as this is not a git tree\n";
 	exit 0;
 }
-- 
2.27.0

Re: [PATCH] documentation-file-ref-check: Make git check work for multiple working directories

[Mauro Carvalho Chehab]

Em Wed,  2 Jun 2021 20:28:06 -0500
Rob Herring <robh@kernel.org> escreveu:

> With multiple git working directories, '.git' may also be a text file
> linking to the actual git tree instead of a directory.

Good catch! Never tested inside a git worktree, as I use a separate git
for docs patches due to a different [format] settings (due to a
different c/c list).

> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Tested-by: Mauro Carvalho Chehab <mchehab@kernel.org>

> ---
>  scripts/documentation-file-ref-check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/documentation-file-ref-check b/scripts/documentation-file-ref-check
> index c71832b2312b..7187ea5e5149 100755
> --- a/scripts/documentation-file-ref-check
> +++ b/scripts/documentation-file-ref-check
> @@ -24,7 +24,7 @@ my $help = 0;
>  my $fix = 0;
>  my $warn = 0;
>  
> -if (! -d ".git") {
> +if (! -e ".git") {
>  	printf "Warning: can't check if file exists, as this is not a git tree\n";
>  	exit 0;
>  }



Thanks,
Mauro

Re: [PATCH] documentation-file-ref-check: Make git check work for multiple working directories

[Jonathan Corbet]

Rob Herring <robh@kernel.org> writes:

> With multiple git working directories, '.git' may also be a text file
> linking to the actual git tree instead of a directory.
>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  scripts/documentation-file-ref-check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/documentation-file-ref-check b/scripts/documentation-file-ref-check
> index c71832b2312b..7187ea5e5149 100755
> --- a/scripts/documentation-file-ref-check
> +++ b/scripts/documentation-file-ref-check
> @@ -24,7 +24,7 @@ my $help = 0;
>  my $fix = 0;
>  my $warn = 0;
>  
> -if (! -d ".git") {
> +if (! -e ".git") {
>  	printf "Warning: can't check if file exists, as this is not a git tree\n";
>  	exit 0;

Applied, thanks.

jon