From: Dejin Zheng <zhengdejin5@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
corbet@lwn.net, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, rric@kernel.org,
bhelgaas@google.com, wsa@kernel.org, Sanket.Goswami@amd.com,
linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v7 1/4] PCI: Introduce pcim_alloc_irq_vectors()
Date: Tue, 8 Jun 2021 22:23:38 +0800 [thread overview]
Message-ID: <20210608142338.GB1030842@nuc8i5> (raw)
In-Reply-To: <20210607171451.GA2507298@bjorn-Precision-5520>
On Mon, Jun 07, 2021 at 12:14:51PM -0500, Bjorn Helgaas wrote:
> On Mon, Jun 07, 2021 at 07:12:34PM +0300, Andy Shevchenko wrote:
> > On Mon, Jun 07, 2021 at 11:39:13PM +0800, Dejin Zheng wrote:
> > > Introduce pcim_alloc_irq_vectors(), a device-managed version of
> > > pci_alloc_irq_vectors(). Introducing this function can simplify
> > > the error handling path in many drivers.
> > >
> > > And use pci_free_irq_vectors() to replace some code in pcim_release(),
> > > they are equivalent, and no functional change. It is more explicit
> > > that pcim_alloc_irq_vectors() is a device-managed function.
> >
> > ...
> >
> > > When CONFIG_PCI=n, there is no stub for pci_is_managed(), but
> > > pcim_alloc_irq_vectors() will use it, so add one like other similar stubs.
> > > Otherwise there can be build errors, as here by kernel test robot
> > > reported:
> > > include/linux/pci.h: In function 'pcim_alloc_irq_vectors':
> > > >> include/linux/pci.h:1847:7: error: implicit declaration of function 'pci_is_managed' [-Werror=implicit-function-declaration]
> > > 1847 | if (!pci_is_managed(dev))
> > > | ^~~~~~~~~~~~~~
> >
> > This is rather changelog related material. No need to pollute commit message
> > with this.
> >
> > ...
> >
> > > Reported-by: kernel test robot <lkp@intel.com>
> >
> > It's new functionality. Why this tag is here?
> > Use comments (similar location than changelog) to give a credit if you wish.
>
> Agreed, I'll tidy that up, so no need to repost for this.
Bjorn, Thank you very much, you are so nice!
BR,
Dejin
next prev parent reply other threads:[~2021-06-08 14:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 15:39 [PATCH v7 0/4] Introduce pcim_alloc_irq_vectors() Dejin Zheng
2021-06-07 15:39 ` [PATCH v7 1/4] PCI: " Dejin Zheng
2021-06-07 16:12 ` Andy Shevchenko
2021-06-07 17:14 ` Bjorn Helgaas
2021-06-08 14:23 ` Dejin Zheng [this message]
2021-06-08 14:20 ` Dejin Zheng
2021-06-10 22:41 ` Bjorn Helgaas
2021-06-11 9:37 ` Andy Shevchenko
2021-06-16 19:25 ` Bjorn Helgaas
2021-06-17 13:20 ` Andy Shevchenko
2021-06-17 15:58 ` Bjorn Helgaas
2022-12-16 8:34 ` Andy Shevchenko
2021-06-17 17:17 ` Dejin Zheng
2022-02-24 11:07 ` Christoph Hellwig
2021-06-07 15:39 ` [PATCH v7 2/4] Documentation: devres: Add pcim_alloc_irq_vectors() Dejin Zheng
2021-06-07 16:13 ` Andy Shevchenko
2021-06-07 15:39 ` [PATCH v7 3/4] i2c: designware: Use pcim_alloc_irq_vectors() to allocate IRQ vectors Dejin Zheng
2021-11-29 19:15 ` Wolfram Sang
2021-06-07 15:39 ` [PATCH v7 4/4] i2c: thunderx: " Dejin Zheng
2021-11-29 19:16 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608142338.GB1030842@nuc8i5 \
--to=zhengdejin5@gmail.com \
--cc=Sanket.Goswami@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=helgaas@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rric@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).