From: David Disseldorp <ddiss@suse.de>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
willy@infradead.org
Subject: Re: [PATCH 1/5] initramfs: move unnecessary memcmp from hot path
Date: Thu, 23 Sep 2021 09:33:23 +0200 [thread overview]
Message-ID: <20210923093323.5632a534@suse.de> (raw)
In-Reply-To: <YUu91kH8kOcVHxyb@zeniv-ca.linux.org.uk>
On Wed, 22 Sep 2021 23:35:50 +0000, Al Viro wrote:
> On Wed, Sep 22, 2021 at 01:52:18PM +0200, David Disseldorp wrote:
> > do_header() is called for each cpio entry and first checks for "newc"
> > magic before parsing further. The magic check includes a special case
> > error message if POSIX.1 ASCII (cpio -H odc) magic is detected. This
> > special case POSIX.1 check needn't be done in the hot path, so move it
> > under the non-newc-magic error path.
>
> You keep refering to hot paths; do you have any data to support that
> assertion?
The code-path is run for every single initramfs entry on every single
boot. Calling that "hot" is reasonable IMO.
> How much does that series buy you on average, and what kind of dispersion
> do you get before and after it?
I withdrew the perf claims for this patch after you rightly pointed out
that my previous numbers weren't statistically significant. After doing
further checks I noticed that there was more to be gained via the
INITRAMFS_PRESERVE_MTIME changes. Numbers for extraction performance
with and without mtime preservation can be found in [PATCH 5/5] of this
series.
> I'm not saying I hate the patches themselves, but those references in commit
> messages ping my BS detectors every time I see them ;-/
I'll try harder to strip anything that might be considered buzzwordy in
future, sorry.
Cheers, David
prev parent reply other threads:[~2021-09-23 7:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 11:52 [PATCH 1/5] initramfs: move unnecessary memcmp from hot path David Disseldorp
2021-09-22 11:52 ` [PATCH 2/5] initramfs: print helpful cpio error on "crc" magic David Disseldorp
2021-09-22 11:52 ` [PATCH v2 3/5] docs: remove mention of "crc" cpio format support David Disseldorp
2021-09-22 11:52 ` [PATCH 4/5] initramfs: use do_utime() wrapper consistently David Disseldorp
2021-09-22 11:52 ` [PATCH 5/5] initramfs: add INITRAMFS_PRESERVE_MTIME Kconfig option David Disseldorp
2021-09-22 23:28 ` [PATCH 1/5] initramfs: move unnecessary memcmp from hot path Chaitanya Kulkarni
2021-09-23 7:43 ` David Disseldorp
2021-09-22 23:35 ` Al Viro
2021-09-22 23:51 ` Chaitanya Kulkarni
2021-09-23 7:33 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923093323.5632a534@suse.de \
--to=ddiss@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).