From: Guenter Roeck <linux@roeck-us.net>
To: Cosmin Tanislav <demonsingur@gmail.com>
Cc: cosmin.tanislav@analog.com, Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] hwmon: Add debugfs register access
Date: Tue, 28 Dec 2021 09:09:59 -0800 [thread overview]
Message-ID: <20211228170959.GH1225572@roeck-us.net> (raw)
In-Reply-To: <9b82bdf9-25a0-46cd-cfed-b86f114dc303@gmail.com>
On Tue, Dec 28, 2021 at 06:51:40PM +0200, Cosmin Tanislav wrote:
>
>
> On 12/28/21 18:13, Guenter Roeck wrote:
> > On 12/27/21 2:42 PM, Cosmin Tanislav wrote:
> > > From: Cosmin Tanislav <cosmin.tanislav@analog.com>
> > >
> > > Similar to IIO, create a device directory inside debugfs
> > > mount point, and create a direct_reg_access file inside
> > > that directory, if debugfs_reg_access callback is defined
> > > inside hwmon_ops.
> > >
> >
> > Patch looks good afaics. I don't want to apply it now (ie for 5.17),
> > though, because it is getting close and we don't have a use case.
> > If you have one in mind, I'd suggest to submit it together with
> > this patch, or we'll have to wait until there is a user.
> >
> > Guenter
>
> As I mentioned previously I have a local patch on top of the ADT7X10
> refactor that uses this. I tested your modifications to my patchset on
> the ADT7420 part and it seems to work just fine. I can push it on top of
> either this patch or that patchset, your choice.
>
The adt7x10 patches won't make it into 5.17 either, so all that will
have to wait until 5.18. If I don't get a use case by then I may write
one myself, but that won't happen now because I am about to be away
from my computers for the next two weeks.
Guenter
prev parent reply other threads:[~2021-12-28 17:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 22:42 [PATCH v2 0/1] Add hwmon debugfs register access Cosmin Tanislav
2021-12-27 22:42 ` [PATCH v2 1/1] hwmon: Add " Cosmin Tanislav
2021-12-28 16:13 ` Guenter Roeck
2021-12-28 16:51 ` Cosmin Tanislav
2021-12-28 17:09 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211228170959.GH1225572@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=cosmin.tanislav@analog.com \
--cc=demonsingur@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).