From: cgel.zte@gmail.com
To: davem@davemloft.net
Cc: kuba@kernel.org, corbet@lwn.net, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
xu xin <xu.xin16@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>
Subject: [PATCH linux-next] Documentation: fix outdated interpretation of ip_no_pmtu_disc
Date: Wed, 29 Dec 2021 03:12:45 +0000 [thread overview]
Message-ID: <20211229031245.582451-1-xu.xin16@zte.com.cn> (raw)
From: xu xin <xu.xin16@zte.com.cn>
The updating way of pmtu has changed, but documentation is still in the
old way. See commit-id 28d35bcdd3925e7293408cdb8aa5f2aac5f0d6e3. So This
patch fix interpretation of ip_no_pmtu_disc.
Besides, min_pmtu seems not to be discoverd, but set.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: xu xin <xu.xin16@zte.com.cn>
---
Documentation/networking/ip-sysctl.rst | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
index c04431144f7a..dd5e53318805 100644
--- a/Documentation/networking/ip-sysctl.rst
+++ b/Documentation/networking/ip-sysctl.rst
@@ -25,9 +25,11 @@ ip_default_ttl - INTEGER
ip_no_pmtu_disc - INTEGER
Disable Path MTU Discovery. If enabled in mode 1 and a
fragmentation-required ICMP is received, the PMTU to this
- destination will be set to min_pmtu (see below). You will need
- to raise min_pmtu to the smallest interface MTU on your system
- manually if you want to avoid locally generated fragments.
+ destination will be set to the smallest of the old MTU
+ and ip_rt_min_pmtu (see __ip_rt_update_pmtu() in
+ net/ipv4/route.c). You will need to raise min_pmtu to the
+ smallest interface MTU on your system manually if you want to
+ avoid locally generated fragments.
In mode 2 incoming Path MTU Discovery messages will be
discarded. Outgoing frames are handled the same as in mode 1,
@@ -49,7 +51,7 @@ ip_no_pmtu_disc - INTEGER
Default: FALSE
min_pmtu - INTEGER
- default 552 - minimum discovered Path MTU
+ default 552 - minimum set Path MTU
ip_forward_use_pmtu - BOOLEAN
By default we don't trust protocol path MTUs while forwarding
--
2.25.1
next reply other threads:[~2021-12-29 3:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 3:12 cgel.zte [this message]
2021-12-29 20:15 ` [PATCH linux-next] Documentation: fix outdated interpretation of ip_no_pmtu_disc Jakub Kicinski
2021-12-30 3:28 ` [PATCH v2] " cgel.zte
2021-12-30 13:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211229031245.582451-1-xu.xin16@zte.com.cn \
--to=cgel.zte@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xu.xin16@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).