From: Eduardo Valentin <evalenti@kernel.org>
To: eduval@amazon.com, linux-pm@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/7] thermal: stats: introduce thermal zone stats/min_gradient
Date: Thu, 18 May 2023 20:27:16 -0700 [thread overview]
Message-ID: <20230519032719.2581689-5-evalenti@kernel.org> (raw)
In-Reply-To: <20230519032719.2581689-1-evalenti@kernel.org>
From: Eduardo Valentin <eduval@amazon.com>
The patch adds a statistic to track
the minimum gradient (dT/dt) to the thermal zone
stats/ folder.
Samples:
$ echo 1000 > emul_temp
$ cat stats/min_gradient
0
$ echo 2000 > emul_temp
$ echo 1000 > emul_temp
$ cat stats/min_gradient
-3460
Cc: "Rafael J. Wysocki" <rafael@kernel.org> (supporter:THERMAL)
Cc: Daniel Lezcano <daniel.lezcano@linaro.org> (supporter:THERMAL)
Cc: Amit Kucheria <amitk@kernel.org> (reviewer:THERMAL)
Cc: Zhang Rui <rui.zhang@intel.com> (reviewer:THERMAL)
Cc: Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION)
Cc: linux-pm@vger.kernel.org (open list:THERMAL)
Cc: linux-doc@vger.kernel.org (open list:DOCUMENTATION)
Cc: linux-kernel@vger.kernel.org (open list)
Signed-off-by: Eduardo Valentin <eduval@amazon.com>
---
.../driver-api/thermal/sysfs-api.rst | 1 +
drivers/thermal/thermal_sysfs.c | 23 +++++++++++++++++++
2 files changed, 24 insertions(+)
diff --git a/Documentation/driver-api/thermal/sysfs-api.rst b/Documentation/driver-api/thermal/sysfs-api.rst
index 18140dbb1ce1..ed5e6ba4e0d7 100644
--- a/Documentation/driver-api/thermal/sysfs-api.rst
+++ b/Documentation/driver-api/thermal/sysfs-api.rst
@@ -358,6 +358,7 @@ Thermal zone device sys I/F, created once it's registered::
|---stats: Directory containing thermal zone device's stats
|---stats/reset_tz_stats: Writes to this file resets the statistics.
|---stats/max_gradient: The maximum recorded dT/dt in uC/ms.
+ |---stats/min_gradient: The minimum recorded dT/dt in uC/ms.
Thermal cooling device sys I/F, created once it's registered::
diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c
index aa28c1cae916..f89ec9a7e8c8 100644
--- a/drivers/thermal/thermal_sysfs.c
+++ b/drivers/thermal/thermal_sysfs.c
@@ -542,6 +542,7 @@ static void destroy_trip_attrs(struct thermal_zone_device *tz)
struct thermal_zone_device_stats {
spinlock_t lock; /* protects this struct */
s64 max_gradient;
+ s64 min_gradient;
ktime_t last_time;
};
@@ -569,6 +570,10 @@ static void temperature_stats_update(struct thermal_zone_device *tz)
/* update fastest temperature rise from our perspective */
if (cur_gradient > stats->max_gradient)
stats->max_gradient = cur_gradient;
+
+ /* update fastest temperature decay from our perspective */
+ if (cur_gradient < stats->min_gradient)
+ stats->min_gradient = cur_gradient;
}
void thermal_zone_device_stats_update(struct thermal_zone_device *tz)
@@ -595,6 +600,21 @@ static ssize_t max_gradient_show(struct device *dev,
return ret;
}
+static ssize_t min_gradient_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct thermal_zone_device *tz = to_thermal_zone(dev);
+ struct thermal_zone_device_stats *stats = tz->stats;
+ int ret;
+
+ spin_lock(&stats->lock);
+ temperature_stats_update(tz);
+ ret = snprintf(buf, PAGE_SIZE, "%lld\n", stats->min_gradient);
+ spin_unlock(&stats->lock);
+
+ return ret;
+}
+
static ssize_t
reset_tz_stats_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
@@ -604,6 +624,7 @@ reset_tz_stats_store(struct device *dev, struct device_attribute *attr,
spin_lock(&stats->lock);
+ stats->min_gradient = 0;
stats->max_gradient = 0;
stats->last_time = ktime_get();
@@ -612,10 +633,12 @@ reset_tz_stats_store(struct device *dev, struct device_attribute *attr,
return count;
}
+static DEVICE_ATTR_RO(min_gradient);
static DEVICE_ATTR_RO(max_gradient);
static DEVICE_ATTR_WO(reset_tz_stats);
static struct attribute *thermal_zone_device_stats_attrs[] = {
+ &dev_attr_min_gradient.attr,
&dev_attr_max_gradient.attr,
&dev_attr_reset_tz_stats.attr,
NULL
--
2.34.1
next prev parent reply other threads:[~2023-05-19 3:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 3:27 [PATCH 0/7] thermal: enhancements on thermal stats Eduardo Valentin
2023-05-19 3:27 ` [PATCH 1/7] thermal: stats: track time each dev changes due to tz Eduardo Valentin
2023-06-20 13:43 ` Rafael J. Wysocki
2023-06-21 4:37 ` Eduardo Valentin
2023-05-19 3:27 ` [PATCH 2/7] thermal: stats: track number of change requests " Eduardo Valentin
2023-06-20 17:12 ` Rafael J. Wysocki
2023-06-21 4:40 ` Eduardo Valentin
2023-05-19 3:27 ` [PATCH 3/7] thermal: stats: introduce thermal zone stats/ directory Eduardo Valentin
2023-05-19 3:27 ` Eduardo Valentin [this message]
2023-06-20 17:17 ` [PATCH 4/7] thermal: stats: introduce thermal zone stats/min_gradient Rafael J. Wysocki
2023-05-19 3:27 ` [PATCH 5/7] thermal: stats: introduce tz time in trip Eduardo Valentin
2023-06-20 17:27 ` Rafael J. Wysocki
2023-06-21 4:45 ` Eduardo Valentin
2023-06-23 16:40 ` Rafael J. Wysocki
2023-06-28 20:00 ` Eduardo Valentin
2023-05-19 3:27 ` [PATCH 6/7] ythermal: core: report errors to governors Eduardo Valentin
2023-06-20 17:29 ` Rafael J. Wysocki
2023-06-21 4:49 ` Eduardo Valentin
2023-05-19 3:27 ` [PATCH 7/7] thermal: stats: add error accounting to thermal zone Eduardo Valentin
2023-06-20 17:32 ` Rafael J. Wysocki
2023-06-21 4:50 ` Eduardo Valentin
2023-05-24 18:22 ` [PATCH 0/7] thermal: enhancements on thermal stats Rafael J. Wysocki
2023-06-05 23:28 ` Eduardo Valentin
2023-06-20 19:05 ` Daniel Lezcano
2023-06-21 4:24 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519032719.2581689-5-evalenti@kernel.org \
--to=evalenti@kernel.org \
--cc=amitk@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=eduval@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).