From: Dave Anderson <anderson@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Kazuhito Hagio <k-hagio@ab.jp.nec.com>,
Lianbo Jiang <lijiang@redhat.com>,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
akpm@linux-foundation.org, bhe@redhat.com, dyoung@redhat.com,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation
Date: Mon, 14 Jan 2019 13:58:32 -0500 (EST) [thread overview]
Message-ID: <2126185079.69727846.1547492312033.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190114180142.GO2773@zn.tnic>
----- Original Message -----
> On Mon, Jan 14, 2019 at 05:48:48PM +0000, Kazuhito Hagio wrote:
> > As for makedumpfile, it will be not impossible to remove the
> > init_uts_ns.name.relase (OSRELEASE), but some fixes are needed.
> > Because historically OSRELEASE has been a kind of a mandatory entry
> > in vmcoreinfo from the beginning of vmcoreinfo, so makedumpfile uses
> > its existence to check whether a vmcoreinfo is sane.
>
> Well, init_uts_ns is exported in vmcoreinfo anyway - makedumpfile
> can simply test init_uts_ns.name.release just as well. And the
> "historically" argument doesn't matter because vmcoreinfo is not an ABI.
>
> So makedumpfile needs to be changed to check that new export.
>
> > Also, I think crash also will need to be fixed if it is removed.
Preferably it would be left as-is. The crash utility has a "crash --osrelease vmcore"
option that only looks at the dumpfile header, and just dump the string. With respect
to compressed kdumps, crash could alternatively look at the utsname data that is stored
in the diskdump_header.utsname field, but with ELF vmcores, there is no such back-up.
What's the problem with leaving it alone?
Dave
>
> Yes, I'm expecting user tools to be fixed and then exports removed.
>
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
>
next prev parent reply other threads:[~2019-01-14 18:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 12:19 [PATCH 0/2 v6] kdump,vmcoreinfo: Export the value of sme mask to vmcoreinfo Lianbo Jiang
2019-01-10 12:19 ` [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation Lianbo Jiang
2019-01-11 12:33 ` Borislav Petkov
2019-01-14 1:52 ` lijiang
2019-01-14 9:10 ` Borislav Petkov
2019-01-14 17:48 ` Kazuhito Hagio
2019-01-14 18:01 ` Borislav Petkov
2019-01-14 18:58 ` Dave Anderson [this message]
2019-01-14 19:21 ` Borislav Petkov
2019-01-14 19:36 ` Dave Anderson
2019-01-14 19:59 ` Borislav Petkov
2019-01-14 20:07 ` Dave Anderson
2019-01-14 20:18 ` Borislav Petkov
2019-01-14 20:26 ` Dave Anderson
2019-01-14 20:35 ` Borislav Petkov
2019-01-14 20:49 ` Dave Anderson
2019-01-15 10:06 ` Borislav Petkov
2019-01-15 11:00 ` lijiang
2019-01-11 14:56 ` Borislav Petkov
2019-01-14 5:30 ` lijiang
2019-01-14 9:15 ` Borislav Petkov
2019-01-15 9:41 ` lijiang
2019-01-10 12:19 ` [PATCH 2/2 v6] kdump,vmcoreinfo: Export the value of sme mask to vmcoreinfo Lianbo Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2126185079.69727846.1547492312033.JavaMail.zimbra@redhat.com \
--to=anderson@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=k-hagio@ab.jp.nec.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).