linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>,
	Randy Dunlap <rdunlap@infradead.org>,
	Coccinelle <cocci@systeme.lip6.fr>,
	linux-doc@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Gilles Muller <Gilles.Muller@lip6.fr>
Subject: Re: [v2] Documentation: Coccinelle: fix typos and command example
Date: Thu, 2 Jul 2020 08:01:59 +0200	[thread overview]
Message-ID: <33b47421-5966-2b5a-17ec-d55a1169d30b@web.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2007012232510.2540@hadrien>

>>> Julia, Markus- can you tell me how to run coccicheck on one source file?
>>
>> You can choose between two methods.
>>
>> * Use the documented build target with appropriate parameters.
>>   (How many Linux software modules do consist of only a single source file?)
>
> This is a useless piece of information.  What are "appropriate parameters".

I propose to take another look at details from the discussed software documentation
for the desired selection of useful settings.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=cd77006e01b3198c75fb7819b3d0ff89709539bb#n167

It is mentioned there that the make variable “M” can be used
to apply Coccinelle to a specific directory.

* Which existing directories will contain a single source file for a while?

* You can create folders on demand with one source file (or equivalent
  symbolic links), can't you?


>> * Do you get further ideas from another concrete command example?
>>   https://lore.kernel.org/linux-arm-kernel/5b693ee0-0cb1-7ff3-b562-bac6bcb6aae8@web.de/
>>   https://lkml.org/lkml/2020/6/29/357
>>
>>   elfring@Sonne:~/Projekte/Linux/next-patched> make J=1 C=1 CHECK='scripts/coccicheck' MODE=context COCCI=~/Projekte/Linux/next-patched/scripts/coccinelle/null/show_pointer_usage_before_null_check-20200701.cocci drivers/usb/mtu3/mtu3_gadget.o
>
> This is not what is intended.

I am curious how corresponding intentions will be adjusted.


> What is intended has never worked.

I wonder about this view.
Did I get inappropriate impressions from the presented test example?


> The coccicheck script expects that the file name is received on its command
> line, and that is not the case.  I have asked the person who wrote the
> code if he knows how to fix it.

I am also curious how this area might evolve further.

Regards,
Markus

  parent reply	other threads:[~2020-07-02  6:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29 21:16 [PATCH v2] Documentation: Coccinelle: fix typos and command example Randy Dunlap
2020-06-30  8:04 ` Markus Elfring
2020-06-30 12:23 ` Markus Elfring
2020-06-30 15:11   ` Randy Dunlap
2020-07-01 11:56     ` Markus Elfring
2020-07-01 13:20       ` Randy Dunlap
2020-07-01 13:32         ` [v2] " Markus Elfring
2020-07-01 14:52           ` Randy Dunlap
2020-07-01 15:02             ` Markus Elfring
2020-07-01 15:07               ` Randy Dunlap
2020-07-01 15:15                 ` Markus Elfring
2020-07-01 15:19                   ` Jonathan Corbet
2020-07-01 15:23                     ` Markus Elfring
2020-07-01 15:15                 ` Markus Elfring
2020-07-01 15:19                   ` Randy Dunlap
2020-07-01 15:32                     ` Markus Elfring
2020-07-01 17:32                     ` Markus Elfring
2020-07-01 19:15                       ` Randy Dunlap
2020-07-01 20:10                         ` Markus Elfring
     [not found]                           ` <alpine.DEB.2.22.394.2007012232510.2540@hadrien>
2020-07-02  6:01                             ` Markus Elfring [this message]
2020-07-02  8:22                             ` Markus Elfring
2020-07-02  0:08             ` Matthew Wilcox
2020-07-02  5:40               ` Julia Lawall
2020-07-01 15:29 ` [Cocci] [PATCH v2] " Julia Lawall
2020-07-01 16:06   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33b47421-5966-2b5a-17ec-d55a1169d30b@web.de \
    --to=markus.elfring@web.de \
    --cc=Gilles.Muller@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=corbet@lwn.net \
    --cc=julia.lawall@inria.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).