From: David Laight <David.Laight@ACULAB.COM>
To: 'Steven Rostedt' <rostedt@goodmis.org>
Cc: 'Stephen Boyd' <swboyd@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Baoquan He <bhe@redhat.com>, "Borislav Petkov" <bp@alien8.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Young <dyoung@redhat.com>, Evan Green <evgreen@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Ingo Molnar <mingo@redhat.com>, Jessica Yu <jeyu@kernel.org>,
Jiri Olsa <jolsa@kernel.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
Sasha Levin <sashal@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Vivek Goyal <vgoyal@redhat.com>, Will Deacon <will@kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
peter enderborg <peter.enderborg@sony.com>
Subject: RE: [PATCH v6 00/13] Add build ID to stacktraces
Date: Tue, 11 May 2021 12:58:47 +0000 [thread overview]
Message-ID: <37ca7834a8514a5695ed002e073a83b6@AcuMS.aculab.com> (raw)
In-Reply-To: <20210511085235.09bc38a7@gandalf.local.home>
From: Steven Rostedt
> Sent: 11 May 2021 13:53
>
> On Tue, 11 May 2021 12:36:06 +0000
> David Laight <David.Laight@ACULAB.COM> wrote:
>
> > > x1 : ffffff93fef15788 x0 : ffffffe3622352e0
> > > Call trace:
> > > lkdtm_WARNING+0x28/0x30 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e]
> > > direct_entry+0x16c/0x1b4 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e]
> > > full_proxy_write+0x74/0xa4
> >
> > Is there any way to get it to print each module ID only once?
>
> If there's a trivial way to do that, then perhaps it should be done, but for
> now, this patch series isn't as obnoxious as the previous versions. It only
> affects stack traces, and I'm fine with that.
True. Printing the id in the module list was horrid.
The real downside is all the extra text that will overflow the
in-kernel buffer.
At least it shouldn't be extra lines causing screen wrap.
Unless the variable names are long - hi rust :-)
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-05-11 12:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 0:38 [PATCH v6 00/13] Add build ID to stacktraces Stephen Boyd
2021-05-11 0:38 ` [PATCH v6 05/13] module: Add printk formats to add module " Stephen Boyd
2021-05-11 11:35 ` Petr Mladek
2021-05-11 16:51 ` Stephen Boyd
2021-05-11 11:48 ` [PATCH v6 00/13] Add " Petr Mladek
2021-05-11 12:36 ` David Laight
2021-05-11 12:52 ` Steven Rostedt
2021-05-11 12:58 ` David Laight [this message]
2021-05-11 14:21 ` Petr Mladek
2021-05-11 14:31 ` David Laight
2021-05-11 14:35 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ca7834a8514a5695ed002e073a83b6@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ast@kernel.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dyoung@redhat.com \
--cc=evgreen@chromium.org \
--cc=hch@infradead.org \
--cc=hsinyi@chromium.org \
--cc=jeyu@kernel.org \
--cc=jolsa@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=peter.enderborg@sony.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).