From: Atish Patra <Atish.Patra@wdc.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"merker@debian.org" <merker@debian.org>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"palmer@sifive.com" <palmer@sifive.com>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>
Subject: Re: [PATCH] RISC-V: Typo fixes in image header and documentation.
Date: Tue, 26 Nov 2019 22:02:20 +0000 [thread overview]
Message-ID: <4912c007ab6c19321c8c988ae2328efbfb3e582d.camel@wdc.com> (raw)
In-Reply-To: <20191009010637.9955-1-atish.patra@wdc.com>
On Tue, 2019-10-08 at 18:06 -0700, Atish Patra wrote:
> There are some typos in boot image header and riscv boot
> documentation.
>
> Fix the typos.
>
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
> ---
> Documentation/riscv/boot-image-header.rst | 4 ++--
> arch/riscv/include/asm/image.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/riscv/boot-image-header.rst
> b/Documentation/riscv/boot-image-header.rst
> index 7b4d1d747585..8efb0596a33f 100644
> --- a/Documentation/riscv/boot-image-header.rst
> +++ b/Documentation/riscv/boot-image-header.rst
> @@ -22,7 +22,7 @@ The following 64-byte header is present in
> decompressed Linux kernel image::
> u64 res2 = 0; /* Reserved */
> u64 magic = 0x5643534952; /* Magic number, little endian,
> "RISCV" */
> u32 magic2 = 0x56534905; /* Magic number 2, little endian,
> "RSC\x05" */
> - u32 res4; /* Reserved for PE COFF offset */
> + u32 res3; /* Reserved for PE COFF offset */
>
> This header format is compliant with PE/COFF header and largely
> inspired from
> ARM64 header. Thus, both ARM64 & RISC-V header can be combined into
> one common
> @@ -34,7 +34,7 @@ Notes
> - This header can also be reused to support EFI stub for RISC-V in
> future. EFI
> specification needs PE/COFF image header in the beginning of the
> kernel image
> in order to load it as an EFI application. In order to support EFI
> stub,
> - code0 should be replaced with "MZ" magic string and res5(at offset
> 0x3c) should
> + code0 should be replaced with "MZ" magic string and res3(at offset
> 0x3c) should
> point to the rest of the PE/COFF header.
>
> - version field indicate header version number
> diff --git a/arch/riscv/include/asm/image.h
> b/arch/riscv/include/asm/image.h
> index 344db5244547..4f8061a5ac4a 100644
> --- a/arch/riscv/include/asm/image.h
> +++ b/arch/riscv/include/asm/image.h
> @@ -42,7 +42,7 @@
> * @res2: reserved
> * @magic: Magic number (RISC-V specific; deprecated)
> * @magic2: Magic number 2 (to match the ARM64 'magic'
> field pos)
> - * @res4: reserved (will be used for PE COFF offset)
> + * @res3: reserved (will be used for PE COFF offset)
> *
> * The intention is for this header format to be shared betweenres4
> multiple
> * architectures to avoid a proliferation of image header formats.
> @@ -59,7 +59,7 @@ struct riscv_image_header {
> u64 res2;
> u64 magic;
> u32 magic2;
> - u32 res4;
> + u32 res3;
> };
> #endif /* __ASSEMBLY__ */
> #endif /* __ASM_IMAGE_H */
ping ?
--
Regards,
Atish
next prev parent reply other threads:[~2019-11-26 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 1:06 [PATCH] RISC-V: Typo fixes in image header and documentation Atish Patra
2019-11-26 22:02 ` Atish Patra [this message]
2019-12-05 23:03 ` Palmer Dabbelt
2019-12-10 14:29 ` Jonathan Corbet
2020-01-09 23:42 ` Palmer Dabbelt
2020-01-10 17:17 ` Jonathan Corbet
2020-01-11 0:20 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4912c007ab6c19321c8c988ae2328efbfb3e582d.camel@wdc.com \
--to=atish.patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mchehab+samsung@kernel.org \
--cc=merker@debian.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).