From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35C84C2D0CE for ; Tue, 21 Jan 2020 15:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 084D024125 for ; Tue, 21 Jan 2020 15:34:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lvsQrUsO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729152AbgAUPeo (ORCPT ); Tue, 21 Jan 2020 10:34:44 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:57050 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727508AbgAUPeo (ORCPT ); Tue, 21 Jan 2020 10:34:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vA3uUy3GrF8RYVPYOTynNZKRmmcxfIVUNw9zl1QYAEI=; b=lvsQrUsO5T59sixx/qC96PxtO ZcwZGmusAGkrzdC/8G9yEFW27ewMBeAAOTc831iHAZfqx4PgzHaI7410ncfix8I74I2qkyUPKMxTo dO6KG76adZRu7OBvg67WItfWHjTOHcp0ChxgZ5+ayi/EukK3cxO8qToC7fbd1qjev1sfb/xbqseZp ry7Q3Oi2QzLRtfHTocUZWjYMR5kwmXnxSY9g6qChRQbYLVM5aZjOO8ySGre3+z+fe+Zo/PAXjYKsG JJTzGa5dfc3sfWOM0S7cconEixjBW4lxUWNGDC141a+kXcznVaDoGKCsnfiLP5iyIGr36doj7qBLf EBIu3ClsQ==; Received: from [2601:1c0:6280:3f0::ed68] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1itvY8-00077j-7k; Tue, 21 Jan 2020 15:34:40 +0000 Subject: Re: [PATCH v1 06/11] Documentation: pstore/blk: blkoops: create document for pstore_blk To: liaoweixiong , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Greg Kroah-Hartman , Jonathan Cameron Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org References: <1579482233-2672-1-git-send-email-liaoweixiong@allwinnertech.com> <1579482233-2672-7-git-send-email-liaoweixiong@allwinnertech.com> <40d7f57a-119e-e51f-99a5-63e85ab5ab91@infradead.org> <3337f687-a668-c058-178b-a1438641c519@allwinnertech.com> From: Randy Dunlap Message-ID: <597e2b49-667a-490e-91b6-641ca25401d8@infradead.org> Date: Tue, 21 Jan 2020 07:34:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <3337f687-a668-c058-178b-a1438641c519@allwinnertech.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 1/21/20 12:19 AM, liaoweixiong wrote: > hi Randy Dunlap, > > On 2020/1/21 2:36 PM, Randy Dunlap wrote: >> On 1/20/20 9:23 PM, liaoweixiong wrote: >>> hi Randy Dunlap, >>> >>> On 2020/1/21 PM12:13, Randy Dunlap wrote: >>>> Hi, >>>> >>>> I have some documentation comments for you: >>>> >>>> >>>> On 1/19/20 5:03 PM, WeiXiong Liao wrote: >>>>> The document, at Documentation/admin-guide/pstore-block.rst, tells us >>>>> how to use pstore/blk and blkoops. >>>>> >>>>> Signed-off-by: WeiXiong Liao >>>>> --- >>>>>   Documentation/admin-guide/pstore-block.rst | 278 +++++++++++++++++++++++++++++ >>>>>   MAINTAINERS                                |   1 + >>>>>   fs/pstore/Kconfig                          |   2 + >>>>>   3 files changed, 281 insertions(+) >>>>>   create mode 100644 Documentation/admin-guide/pstore-block.rst >>>>> >>>>> diff --git a/Documentation/admin-guide/pstore-block.rst b/Documentation/admin-guide/pstore-block.rst >>>>> new file mode 100644 >>>>> index 000000000000..58418d429c55 >>>>> --- /dev/null >>>>> +++ b/Documentation/admin-guide/pstore-block.rst >>>>> + >>>>> + >>>>> +dmesg_size >>>>> +~~~~~~~~~~ >>>>> + >>>>> +The chunk size in bytes for dmesg(oops/panic). It **MUST** be a multiple of >>>>> +4096. If you don't need it, safely set it 0 or ignore it. >>>> >>>>                                        set it to 0 or ignore it. >>>> >>> >>> I will fix it, thank you. >>> >>>> The example above is:  blkoops.dmesg_size=64 >>>> where 64 is not a multiple of 4096. (?) >>>> >>> >>> The module parameter dmesg_size is in unit KB. >> >> I didn't see that documented anywhere. >> > > Oh, sorry, that is my oversight. It seems that not only the other size introductions but also introductions on Kconfig should be corrected. Thank you very much and is the following modification OK? > > The chunk size in KB for dmesg(oops/panic). It **MUST** be a multiple of 4. OK. >>>>> +Compression and header >>>>> +---------------------- >>>>> + >>>>> +Block device is large enough for uncompressed dmesg data. Actually we do not >>>>> +recommend data compression because pstore/blk will insert some information into >>>>> +the first line of dmesg data. For example:: >>>>> + >>>>> +        Panic: Total 16 times >>>>> + >>>>> +It means that it's the 16th times panic log since the first booting. Sometimes >>>> >>>>                                 time of a panic log since ... >>>> >>> >>> Should it be like this? >>> It means the time of a panic log since the first booting. >> >> That sounds like clock time, not the number of instances or occurrences. >> > > It is an oops/panic counter too. How about this? > > It means that it's OOPS/PANIC for the 16th time since the first booting. since the last booting {or boot}. thanks. -- ~Randy