From: Markus Elfring <Markus.Elfring@web.de>
To: Dejin Zheng <zhengdejin5@gmail.com>,
kernel-janitors@vger.kernel.org, linux-doc@vger.kernel.org,
linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Coccinelle <cocci@systeme.lip6.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Jonathan Corbet <corbet@lwn.net>,
Michal Simek <michal.simek@xilinx.com>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH v3 1/2] drivers: provide devm_platform_request_irq()
Date: Wed, 27 May 2020 20:45:09 +0200 [thread overview]
Message-ID: <5dad9b19-ceb5-1606-9f62-7626e5677971@web.de> (raw)
> It will call devm_request_irq() after platform_get_irq() function
> in many drivers, sometimes, it is not right for the error handling
> of these two functions in some drivers. so provide this function
> to simplify the driver.
I recommend to improve also this change description.
How do you think about a wording variant like the following?
The function “devm_request_irq” is called after the
function “platform_get_irq” in many drivers.
The exception handling is incomplete there sometimes.
Thus add a corresponding wrapper function for the simplification
of the drivers.
Will a companion script for the semantic patch language (Coccinelle software)
become helpful for further support of collateral evolution?
Regards,
Markus
next reply other threads:[~2020-05-27 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 18:45 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-27 14:26 [PATCH v3 1/2] drivers: provide devm_platform_request_irq() Dejin Zheng
2020-07-17 14:30 ` Dejin Zheng
2020-07-17 14:59 ` Greg KH
2020-07-17 15:06 ` Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dad9b19-ceb5-1606-9f62-7626e5677971@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).