From: Akira Yokosawa <akiyks@gmail.com>
To: Vegard Nossum <vegard.nossum@oracle.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Akira Yokosawa <akiyks@gmail.com>
Subject: Re: docs: requirements.txt has stopped working again
Date: Thu, 25 Jan 2024 00:02:20 +0900 [thread overview]
Message-ID: <6e4b66fe-dbb3-4149-ac7e-8ae333d6fc9d@gmail.com> (raw)
In-Reply-To: <2018acaa-a6ce-4074-b3e1-1a12018573fb@oracle.com>
On Tue, 23 Jan 2024 14:21:32 +0100, Vegard Nossum wrote:
> On 23/01/2024 13:30, Jani Nikula wrote:
>> On the other hand, if you're using a virtual environment, what's the
>> point in holding back to a version as old as 2.4.4? You might just as
>> well go for latest, specifying only the top level dependencies,
>
> Performance... Specifying exact package requirements like 2.4.4 is
> useful since 2.4.4 is by far the fastest Sphinx version that builds our
> documentation correctly (AFAICT) and build speed matters a lot when the
> difference is 10 minutes vs 30 minutes.
>
I've never observed such a huge difference, probably because I almost
always do clean build of the document, i.e., run "make cleandocs" before
running "make htmldocs".
So I assumed the performance regression Vegard are emphasizing should
be in incremental builds.
Here are some of the results comparing v2.4.5, v4.3.2 (of ubuntu jammy),
and v7.2.6. (v2.4.5 needs "make -j2 htmldocs" to avoid OOM.)
Incremental builds are done after moving from v6.7 to v6.8-rc1.
VM spec used: memory: 8GB, threads: 4, ubuntu jammy
data in each cell: elapsed time, max resident memory
v2.4.5 v4.3.2 v7.2.6
============================= ============ ============ ============
clean build at v6.7 10m08s 3.3GB 10m31s 1.1GB 10m14s 1.2GB
incremental build at v6.8-rc1 11m22s 3.3GB 18m55s 1.2GB 19m50s 1.4GB
clean build at v6.8-rc1 10m45s 3.2GB 10m32s 1.2GB 10m13s 1.3GB
empty make at v6.8-rc1 3.3s 6.6s 7.0s
============================= ============ ============ ============
I took only one sample for each run, so these numbers should not be
taken as representative, but they can still show tendencies.
This means the slowness in incremental build is not improved in v7.2.6,
which contradicts what Vegard said earlier in this thread.
I think incremental build is what Jon uses in his merging.
So I'm afraid the performance regression might be troublesome in Jon's
workflow.
HTH, Akira
next prev parent reply other threads:[~2024-01-24 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 4:14 docs: requirements.txt has stopped working again Akira Yokosawa
2024-01-23 7:43 ` Vegard Nossum
2024-01-23 12:30 ` Jani Nikula
2024-01-23 13:21 ` Vegard Nossum
2024-01-23 16:19 ` Jonathan Corbet
2024-01-24 15:02 ` Akira Yokosawa [this message]
2024-01-24 15:25 ` Jonathan Corbet
2024-01-24 15:43 ` Akira Yokosawa
2024-01-26 14:42 ` Akira Yokosawa
2024-01-24 19:56 ` Vegard Nossum
2024-01-23 16:53 ` Jani Nikula
2024-01-23 18:11 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e4b66fe-dbb3-4149-ac7e-8ae333d6fc9d@gmail.com \
--to=akiyks@gmail.com \
--cc=corbet@lwn.net \
--cc=jani.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).