From: Jonathan Corbet <corbet@lwn.net>
To: Aditya Srivastava <yashsri421@gmail.com>
Cc: yashsri421@gmail.com, lukas.bulwahn@gmail.com,
willy@infradead.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC v4] scripts: kernel-doc: reduce repeated regex expressions into variables
Date: Mon, 17 May 2021 11:49:08 -0600 [thread overview]
Message-ID: <878s4d45ez.fsf@meer.lwn.net> (raw)
In-Reply-To: <20210514144244.25341-1-yashsri421@gmail.com>
Aditya Srivastava <yashsri421@gmail.com> writes:
> There are some regex expressions in the kernel-doc script, which are used
> repeatedly in the script.
>
> Reduce such expressions into variables, which can be used everywhere.
>
> A quick manual check found that no errors and warnings were added/removed
> in this process.
>
> Suggested-by: Jonathan Corbet <corbet@lwn.net>
> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
> ---
> Changes in v4:
> - Fix htmldocs warning at function parsing, involving repeated $type2 identifiers capture
> - Re-tested against all files in kernel tree
Applied, thanks for stickint with this.
jon
next prev parent reply other threads:[~2021-05-17 17:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 19:18 [RFC] scripts: kernel-doc: reduce repeated regex expressions into variables Aditya Srivastava
[not found] ` <CAKXUXMx9q57cWXkcezKKo-uuh21Sd-Si9M9KydzFEMQ0ELYEng@mail.gmail.com>
2021-04-23 12:20 ` Aditya Srivastava
2021-04-23 13:21 ` Matthew Wilcox
2021-04-24 11:57 ` Aditya Srivastava
2021-04-24 12:47 ` [RFC v2] " Aditya Srivastava
2021-04-27 15:55 ` Jonathan Corbet
2021-04-27 16:56 ` Matthew Wilcox
2021-04-29 6:37 ` [RFC v3] " Aditya Srivastava
2021-04-29 23:39 ` Jonathan Corbet
2021-04-30 2:03 ` Joe Perches
2021-05-01 9:30 ` Aditya Srivastava
2021-05-01 15:03 ` Jonathan Corbet
2021-05-14 14:42 ` [RFC v4] " Aditya Srivastava
2021-05-14 15:10 ` Aditya Srivastava
2021-05-17 17:49 ` Jonathan Corbet [this message]
2021-05-01 15:43 ` [RFC v3] " Matthew Wilcox
2021-05-14 16:17 ` Aditya Srivastava
2021-04-26 17:31 ` [RFC] " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s4d45ez.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=willy@infradead.org \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).