From: NeilBrown <neilb@suse.de>
To: Fox Chen <foxhlchen@gmail.com>
Cc: Fox Chen <foxhlchen@gmail.com>,
corbet@lwn.net, vegard.nossum@oracle.com,
viro@zeniv.linux.org.uk, rdunlap@infradead.org,
grandmaster@al2klimov.de, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 09/12] docs: path-lookup: no get_link()
Date: Mon, 19 Apr 2021 11:41:00 +1000 [thread overview]
Message-ID: <87v98j126r.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20210316054727.25655-10-foxhlchen@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1965 bytes --]
On Tue, Mar 16 2021, Fox Chen wrote:
> no get_link() anymore. we have step_into() and pick_link().
>
> walk_component() will call step_into(), in turn call pick_link,
> and return symlink name.
>
> Signed-off-by: Fox Chen <foxhlchen@gmail.com>
> ---
> Documentation/filesystems/path-lookup.rst | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/filesystems/path-lookup.rst b/Documentation/filesystems/path-lookup.rst
> index 8ab95dd9046e..0d41c61f7e4f 100644
> --- a/Documentation/filesystems/path-lookup.rst
> +++ b/Documentation/filesystems/path-lookup.rst
> @@ -1103,12 +1103,10 @@ doesn't need to notice. Getting this ``name`` variable on and off the
> stack is very straightforward; pushing and popping the references is
> a little more complex.
>
> -When a symlink is found, ``walk_component()`` returns the value ``1``
> -(``0`` is returned for any other sort of success, and a negative number
> -is, as usual, an error indicator). This causes ``get_link()`` to be
> -called; it then gets the link from the filesystem. Providing that
> -operation is successful, the old path ``name`` is placed on the stack,
> -and the new value is used as the ``name`` for a while. When the end of
> +When a symlink is found, ``walk_component()`` calls ``pick_link()``,
walk_component() calls pick_link() via step_into()
??
> +it then gets the link from the filesystem returning new path ``name``.
"which returns the link from the filesystem."
With those changes (assuming you agree with them)
Reviewed-by: NeilBrown <neilb@suse.de>
Thanks,
NeilBrown
> +Providing that operation is successful, the old path ``name`` is placed on the
> +stack, and the new value is used as the ``name`` for a while. When the end of
> the path is found (i.e. ``*name`` is ``'\0'``) the old ``name`` is restored
> off the stack and path walking continues.
>
> --
> 2.30.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]
next prev parent reply other threads:[~2021-04-19 1:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 5:47 [PATCH v2 00/12] docs: path-lookup: Update pathlookup docs Fox Chen
2021-03-16 5:47 ` [PATCH v2 01/12] docs: path-lookup: update follow_managed() part Fox Chen
2021-04-19 0:52 ` NeilBrown
2021-04-19 2:17 ` Matthew Wilcox
2021-04-19 2:33 ` Fox Chen
2021-04-19 3:25 ` Matthew Wilcox
2021-04-19 3:33 ` Fox Chen
2021-04-19 19:22 ` Jonathan Corbet
2021-04-20 1:12 ` Fox Chen
2021-03-16 5:47 ` [PATCH v2 02/12] docs: path-lookup: update path_to_nameidata() part Fox Chen
2021-04-19 1:00 ` NeilBrown
2021-03-16 5:47 ` [PATCH v2 03/12] docs: path-lookup: update path_mountpoint() part Fox Chen
2021-04-19 1:03 ` NeilBrown
2021-03-16 5:47 ` [PATCH v2 04/12] docs: path-lookup: update do_last() part Fox Chen
2021-04-19 1:17 ` NeilBrown
2021-03-16 5:47 ` [PATCH v2 05/12] docs: path-lookup: remove filename_mountpoint Fox Chen
2021-04-19 1:20 ` NeilBrown
2021-03-16 5:47 ` [PATCH v2 06/12] docs: path-lookup: Add macro name to symlink limit description Fox Chen
2021-04-19 1:22 ` NeilBrown
2021-03-16 5:47 ` [PATCH v2 07/12] docs: path-lookup: i_op->follow_link replaced with i_op->get_link Fox Chen
2021-04-19 1:28 ` NeilBrown
2021-03-16 5:47 ` [PATCH v2 08/12] docs: path-lookup: update i_op->put_link and cookie description Fox Chen
2021-04-19 1:37 ` NeilBrown
2021-03-16 5:47 ` [PATCH v2 09/12] docs: path-lookup: no get_link() Fox Chen
2021-04-19 1:41 ` NeilBrown [this message]
2021-03-16 5:47 ` [PATCH v2 10/12] docs: path-lookup: update WALK_GET, WALK_PUT desc Fox Chen
2021-04-19 1:47 ` NeilBrown
2021-03-16 5:47 ` [PATCH v2 11/12] docs: path-lookup: update get_link() ->follow_link description Fox Chen
2021-04-19 1:54 ` NeilBrown
2021-03-16 5:47 ` [PATCH v2 12/12] docs: path-lookup: update symlink description Fox Chen
2021-04-19 1:59 ` NeilBrown
2021-04-19 2:34 ` Fox Chen
2021-04-13 21:18 ` [PATCH v2 00/12] docs: path-lookup: Update pathlookup docs Jonathan Corbet
2021-04-13 22:26 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v98j126r.fsf@notabene.neil.brown.name \
--to=neilb@suse.de \
--cc=corbet@lwn.net \
--cc=foxhlchen@gmail.com \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=vegard.nossum@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).