From: Bagas Sanjaya <bagasdotme@gmail.com>
To: наб <nabijaczleweli@nabijaczleweli.xyz>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Federico Vaga" <federico.vaga@vaga.pv.it>,
"Alex Shi" <alexs@kernel.org>,
"Yanteng Si" <siyanteng@loongson.cn>,
"Hu Haowen" <src.res@email.cn>,
"Thomas Sailer" <t.sailer@alumni.ethz.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kiciński" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Kees Cook" <keescook@chromium.org>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc-tw-discuss@lists.sourceforge.net,
linux-hams@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 11/15] hdlcdrv: remove HDLCDRV_MAGIC
Date: Fri, 28 Oct 2022 20:54:40 +0700 [thread overview]
Message-ID: <9386b19f-dd99-3601-9e87-3056100dfe53@gmail.com> (raw)
In-Reply-To: <ad19b20f5867e845a843884bbb0f107e7ea7e11a.1666822928.git.nabijaczleweli@nabijaczleweli.xyz>
On 10/27/22 05:43, наб wrote:
> We have largely moved away from this approach,
> and we have better debugging instrumentation nowadays: kill it
>
Same reply as [1].
> Additionally, ~half HDLCDRV_MAGIC checks just early-exit instead
> of noting the bug, so they're detrimental, if anything
>
"... instead of handling the magic number"?
Thanks.
[1]: https://lore.kernel.org/linux-doc/80c998ec-435f-158c-9b45-4e6844f7861b@gmail.com/
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-10-28 13:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 22:42 [PATCH 01/15] hamradio: baycom: remove BAYCOM_MAGIC наб
2022-10-26 22:42 ` [PATCH 02/15] hamradio: yam: remove YAM_MAGIC наб
2022-10-28 13:19 ` Bagas Sanjaya
2022-10-28 13:44 ` Dan Carpenter
2022-10-26 22:42 ` [PATCH 03/15] pcmcia: synclink_cs: remove MGSLPC_MAGIC наб
2022-10-28 13:21 ` Bagas Sanjaya
2022-10-26 22:42 ` [PATCH 05/15] coda: remove CODA_MAGIC наб
2022-10-28 13:23 ` Bagas Sanjaya
2022-10-28 16:54 ` Jan Harkes
2022-10-26 22:43 ` [PATCH 06/15] Documentation: PG_MAGIC isn't a magic number наб
2022-10-28 13:39 ` Bagas Sanjaya
2022-10-26 22:43 ` [PATCH 07/15] MIPS: IP27: clean out sn/nmi.h наб
2022-10-27 12:26 ` Jason A. Donenfeld
2022-10-28 13:40 ` Bagas Sanjaya
2022-10-26 22:43 ` [PATCH 08/15] MIPS: IP27: remove KV_MAGIC наб
2022-10-28 13:42 ` Bagas Sanjaya
2022-10-26 22:43 ` [PATCH 09/15] x86/APM: remove APM_BIOS_MAGIC наб
2022-10-28 13:45 ` Bagas Sanjaya
2022-10-26 22:43 ` [PATCH 10/15] scsi: acorn: remove QUEUE_MAGIC_{FREE,USED} наб
2022-10-28 13:48 ` Bagas Sanjaya
2022-10-26 22:43 ` [PATCH 11/15] hdlcdrv: remove HDLCDRV_MAGIC наб
2022-10-28 13:54 ` Bagas Sanjaya [this message]
2022-10-26 22:43 ` [PATCH 12/15] drivers: net: slip: remove SLIP_MAGIC наб
2022-10-27 13:11 ` Oliver Hartkopp
2022-10-27 13:45 ` наб
2022-10-28 13:57 ` Bagas Sanjaya
2022-10-26 22:43 ` [PATCH 13/15] fcntl: remove FASYNC_MAGIC наб
2022-10-28 13:59 ` Bagas Sanjaya
2022-10-26 22:43 ` [PATCH 14/15] scsi: ncr53c8xx: replace CCB_MAGIC with bool busy наб
2022-10-28 14:01 ` Bagas Sanjaya
2022-10-26 22:43 ` [PATCH 15/15] Documentation: bury magic-number, now devoid of content наб
2022-10-28 14:04 ` Bagas Sanjaya
2022-10-27 1:37 ` [PATCH 01/15] hamradio: baycom: remove BAYCOM_MAGIC Jakub Kicinski
2022-10-28 1:54 ` Bagas Sanjaya
2022-10-28 13:13 ` Bagas Sanjaya
2022-10-28 13:43 ` Dan Carpenter
2022-10-28 13:50 ` Bagas Sanjaya
2022-10-28 14:07 ` Dan Carpenter
2022-10-28 21:43 ` наб
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9386b19f-dd99-3601-9e87-3056100dfe53@gmail.com \
--to=bagasdotme@gmail.com \
--cc=Jason@zx2c4.com \
--cc=alexs@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=federico.vaga@vaga.pv.it \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-doc-tw-discuss@lists.sourceforge.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=siyanteng@loongson.cn \
--cc=src.res@email.cn \
--cc=t.sailer@alumni.ethz.ch \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).