From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E70DC04E30 for ; Tue, 10 Dec 2019 02:22:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A30920726 for ; Tue, 10 Dec 2019 02:22:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726608AbfLJCWD (ORCPT ); Mon, 9 Dec 2019 21:22:03 -0500 Received: from out30-56.freemail.mail.aliyun.com ([115.124.30.56]:50650 "EHLO out30-56.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726598AbfLJCWD (ORCPT ); Mon, 9 Dec 2019 21:22:03 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07486;MF=yun.wang@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0TkUheNY_1575944515; Received: from testdeMacBook-Pro.local(mailfrom:yun.wang@linux.alibaba.com fp:SMTPD_---0TkUheNY_1575944515) by smtp.aliyun-inc.com(127.0.0.1); Tue, 10 Dec 2019 10:21:58 +0800 Subject: Re: [PATCH v5 0/2] sched/numa: introduce numa locality From: =?UTF-8?B?546L6LSH?= To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Luis Chamberlain , Kees Cook , Iurii Zaikin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, "Paul E. McKenney" , Randy Dunlap , Jonathan Corbet References: <743eecad-9556-a241-546b-c8a66339840e@linux.alibaba.com> <207ef46c-672c-27c8-2012-735bd692a6de@linux.alibaba.com> <040def80-9c38-4bcc-e4a8-8a0d10f131ed@linux.alibaba.com> <25cf7ef5-e37e-7578-eea7-29ad0b76c4ea@linux.alibaba.com> <443641e7-f968-0954-5ff6-3b7e7fed0e83@linux.alibaba.com> Message-ID: <96342524-142e-c616-1e7e-ce05dfd9ca09@linux.alibaba.com> Date: Tue, 10 Dec 2019 10:19:58 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <443641e7-f968-0954-5ff6-3b7e7fed0e83@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Peter, Ingo We have reformed the implementation for several times, now it's very simple and easy to use, there are also a document to guide admin on how to use not only the NUMA locality, but also other per-cgroup NUMA statistics, we hope this could make things easier for other NUMA users. As now there are no more comments, would you please take a look at this patch set, see if it's good enough to be picked? Regards, Michael Wang On 2019/12/5 下午2:53, 王贇 wrote: > Since v4: > * improved documentation > Since v3: > * fix comments and improved documentation > Since v2: > * simplified the locality concept & implementation > Since v1: > * improved documentation > > Modern production environment could use hundreds of cgroup to control > the resources for different workloads, along with the complicated > resource binding. > > On NUMA platforms where we have multiple nodes, things become even more > complicated, we hope there are more local memory access to improve the > performance, and NUMA Balancing keep working hard to achieve that, > however, wrong memory policy or node binding could easily waste the > effort, result a lot of remote page accessing. > > We need to notice such problems, then we got chance to fix it before > there are too much damages, however, there are no good monitoring > approach yet to help catch the mouse who introduced the remote access. > > This patch set is trying to fill in the missing pieces， by introduce > the per-cgroup NUMA locality info, with this new statistics, we could > achieve the daily monitoring on NUMA efficiency, to give warning when > things going too wrong. > > Please check the second patch for more details. > > Michael Wang (2): > sched/numa: introduce per-cgroup NUMA locality info > sched/numa: documentation for per-cgroup numa statistics > > Documentation/admin-guide/cg-numa-stat.rst | 178 ++++++++++++++++++++++++ > Documentation/admin-guide/index.rst | 1 + > Documentation/admin-guide/kernel-parameters.txt | 4 + > Documentation/admin-guide/sysctl/kernel.rst | 9 ++ > include/linux/sched.h | 15 ++ > include/linux/sched/sysctl.h | 6 + > init/Kconfig | 11 ++ > kernel/sched/core.c | 75 ++++++++++ > kernel/sched/fair.c | 62 +++++++++ > kernel/sched/sched.h | 12 ++ > kernel/sysctl.c | 11 ++ > 11 files changed, 384 insertions(+) > create mode 100644 Documentation/admin-guide/cg-numa-stat.rst >