From: Ivan Teterevkov <ivan.teterevkov@nutanix.com>
To: David Rientjes <rientjes@google.com>
Cc: Chris Down <chris@chrisdown.name>,
Matthew Wilcox <willy@infradead.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"pawan.kumar.gupta@linux.intel.com"
<pawan.kumar.gupta@linux.intel.com>,
"jgross@suse.com" <jgross@suse.com>,
"oneukum@suse.com" <oneukum@suse.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: RE: [PATCH] mm/vmscan: add vm_swappiness configuration knobs
Date: Mon, 16 Mar 2020 16:03:08 +0000 [thread overview]
Message-ID: <BL0PR02MB5601F1945BADC0AF46FC3962E9F90@BL0PR02MB5601.namprd02.prod.outlook.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2003131447220.242651@chino.kir.corp.google.com>
On Fri, 13 Mar 2020, David Rientjes wrote:
> I'll renew my suggestion of defaulting memcg->swappiness to -1 and then
> letting mem_cgroup_swappiness() return vm_swappiness when
> memcg->swappiness == -1.
>
> I don't think the act of creating a memcg and not initializing the
> swappiness value implies that the existing value meets your expectation.
>
Thanks, David, I haven't considered this point.
This point has made me realising that the existing behaviour, where
the swappiness is inherited from the parent, is not documented and,
apparently, just appears to be implemented that way.
In this case, the -1 approach looks less harmful in comparison with
the original patch, unless I underestimate a number of users "affected"
by the assumptions about how memcg->swappiness is getting propagated.
I'll send another patch implementing the -1 approach shortly,
perhaps with some clarifications in the "swappiness" documentation.
next prev parent reply other threads:[~2020-03-16 16:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 17:45 [PATCH] mm/vmscan: add vm_swappiness configuration knobs Ivan Teterevkov
2020-03-11 19:31 ` David Rientjes
2020-03-12 12:48 ` Ivan Teterevkov
2020-03-12 13:36 ` Matthew Wilcox
2020-03-12 14:03 ` Chris Down
2020-03-13 10:49 ` Ivan Teterevkov
2020-03-13 21:50 ` David Rientjes
2020-03-16 16:03 ` Ivan Teterevkov [this message]
2020-03-12 9:25 ` Michal Hocko
2020-03-12 12:54 ` Ivan Teterevkov
2020-03-12 13:26 ` Michal Hocko
2020-03-16 14:53 ` Vlastimil Babka
2020-03-16 16:14 ` Ivan Teterevkov
2020-03-17 8:29 ` Michal Hocko
2020-03-17 14:51 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR02MB5601F1945BADC0AF46FC3962E9F90@BL0PR02MB5601.namprd02.prod.outlook.com \
--to=ivan.teterevkov@nutanix.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=corbet@lwn.net \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mchehab+samsung@kernel.org \
--cc=oneukum@suse.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).