From: Dave Rodgman <dave.rodgman@arm.com>
To: "C. Masloch" <pushbx@ulukai.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Willy Tarreau <w@1wt.eu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] docs: lzo: fix incorrect statement about distance zero for EOS
Date: Fri, 22 May 2020 15:22:49 +0000 [thread overview]
Message-ID: <C3AF092B-2B39-45C9-8FE5-4069B3B34C11@arm.com> (raw)
In-Reply-To: <20200522141040.1353769-2-pushbx@ulukai.org>
Looks good to me, thanks
Dave
On 22/05/2020, 15:11, "C. Masloch" <pushbx@ulukai.org> wrote:
The encoded distance bits are zero, but the distance that is
calculated from this is actually equal to 16384. So correct
this statement to read that the 0001HLLL instruction means
EOS when a distance of 16384 is seen. This matches with the
description of the instruction itself later on.
Signed-off-by: C. Masloch <pushbx@ulukai.org>
---
Documentation/lzo.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/lzo.txt b/Documentation/lzo.txt
index f839d104d..dc9e876cb 100644
--- a/Documentation/lzo.txt
+++ b/Documentation/lzo.txt
@@ -65,9 +65,9 @@ Description
generally encoded in the last two bits of the instruction but may also be
taken from the last two bits of an extra operand (eg: distance).
- End of stream is declared when a block copy of distance 0 is seen. Only one
- instruction may encode this distance (0001HLLL), it takes one LE16 operand
- for the distance, thus requiring 3 bytes.
+ End of stream is declared when a block copy of distance 16384 is seen,
+ encoded in a certain instruction (0001HLLL) with the H and D bits all zero.
+ It takes one LE16 operand for the distance, thus requiring 3 bytes.
.. important::
--
2.26.2
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2020-05-22 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 14:10 [PATCH 1/2] docs: lzo: fix first byte interpretation off-by-one C. Masloch
2020-05-22 14:10 ` [PATCH 2/2] docs: lzo: fix incorrect statement about distance zero for EOS C. Masloch
2020-05-22 15:22 ` Dave Rodgman [this message]
2020-05-22 15:22 ` [PATCH 1/2] docs: lzo: fix first byte interpretation off-by-one Dave Rodgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C3AF092B-2B39-45C9-8FE5-4069B3B34C11@arm.com \
--to=dave.rodgman@arm.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pushbx@ulukai.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).